Main Koha release repository https://koha-community.org
Find a file
Galen Charlton 0010c27ea1 Bug 11108: fix duplicate display of basket whose receipt has just been cancelled
After receiving an order basket, before finishing receiving the shipment,
one has an option to cancel the receipt.  This patch fixes a bug where
a basket whose receipt was just cancelled displays on both the pending orders
and already received tabs.

This patch also fixes a minor unitialized variable warning.

To test:

[1] Create a basket with at least one order and close it.
[2] Receive the order, then on the row in the 'Already received'
    table, click the cancel receipt link.
[3] In the page that displays, the basket just cancelled displays
    on both tables.  Clicking the cancel receipt link again results
    in an error message.
[4] Apply the patch.
[5] Repeat steps 1 and 2.  This time, the cancelled basket displays
    only in the pending orders table, as expected.
[6] Verify that after applying the patch, the following no longer
    is logged in the Apache error log:

parcel.pl: Use of uninitialized value in string eq at acqui/parcel.pl line...

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ed Veal <ed.veal@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes test plan, all tests and QA script.
Works as described.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
2013-10-28 15:06:20 +00:00
acqui Bug 11108: fix duplicate display of basket whose receipt has just been cancelled 2013-10-28 15:06:20 +00:00
admin Bug 10038: (follow-up) fix tabs 2013-10-18 04:47:12 +00:00
authorities Bug 9282: (follow-up) remove log noise caused by authorities/ysearch.pl 2013-10-10 22:46:18 +00:00
basket Bug 10853: All existing routing to get a CSV should return a MARC csv 2013-10-11 02:16:33 +00:00
C4 Bug 11123: remove two unused routines from C4::Accounts 2013-10-24 16:55:36 +00:00
catalogue Bug 5645: improve converting simple search to Z39.50 search 2013-10-02 14:58:54 +00:00
cataloguing Bug 11034: remove incorrect return for BiblioAutoLink 2013-10-23 14:15:49 +00:00
circ Bug 10493: (follow-up) fix unitialized variable warning 2013-10-22 20:59:50 +00:00
course_reserves bug 8215: (followup) avoid spurious warning in Apache log 2013-05-21 16:01:08 -07:00
debian Bug 8798: (follow-up) add libdbix-class-schema-loader-perl to koha-perldeps 2013-10-14 21:21:30 +00:00
docs Bug 10550: Fix database typo wthdrawn 2013-09-08 01:58:41 +00:00
errors
etc Bug 9830: Fix some indexes in UNIMARC item indexing 2013-10-21 15:38:49 +00:00
install_misc Bug 8798: DBIx::Class base classes for all Koha tables 2013-10-14 21:07:24 +00:00
installer Bug 10889: fix comment describing biblioitems.serial 2013-10-23 14:13:41 +00:00
Koha Bug 10493: (follow-up) fix various QA issues 2013-10-22 17:05:53 +00:00
koha-tmpl Bug 11133: fix markup errors in OPAC place hold form HTML 2013-10-28 15:00:42 +00:00
labels Bug 10527: remove disused routine C4::Branch::get_branch_code_from_name 2013-07-12 20:20:20 +00:00
members Bug 10954: ensure that payment receipt displays the payment made 2013-10-22 05:48:33 +00:00
misc Bug 9192: let UNIMARC_sync_date_created_with_marc_biblio.pl create fields if needed 2013-10-23 14:20:14 +00:00
offline_circ Bug 10240: (follow-up) don't display patrons as lost or gone-no-address incorrectly 2013-10-11 01:57:05 +00:00
opac Bug 10829: fix browsing across pages breaks for OPAC bibs-linked-to-authority searches 2013-10-23 14:45:54 +00:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
patron_lists Bug 10565: (follow-up) add new user permission for patron list management 2013-10-14 22:43:03 +00:00
patroncards Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber 2013-10-14 21:08:02 +00:00
plugins Bug 7804 - Add Koha Plugin System - QA Followup 2 2013-03-20 14:50:19 -04:00
reports Bug 10718: fix items with no checkouts report 2013-09-08 20:04:43 +00:00
reserve Bug 10663: QA Followup: Typo in comment in renewscript 2013-08-16 01:39:16 +00:00
reviews
rotating_collections Bug 9605: rotating collections permissions are wrong 2013-03-30 22:11:05 -04:00
selenium Adding selenium tests for filterMembers 2009-09-30 11:30:37 +02:00
serials Bug 10723: Merge GetPendingOrders and SearchOrders routines 2013-10-21 18:24:32 +00:00
services Bug 7178: Acquisition item creation improvement 2012-03-26 11:07:23 +02:00
skel Bug 7804 - Add Koha Plugin System 2013-03-20 14:49:47 -04:00
sms
suggestion Bug 9307: QA Followup 2013-06-19 07:19:39 -07:00
svc Bug 7813: (follow-up) improvements for deleting local cover images 2013-09-21 18:11:13 +00:00
t Bug 10493: (follow-up) fix test errors 2013-10-23 04:25:34 +00:00
tags Bug 10730: Use DataTables on the tag review page 2013-09-25 16:47:59 +00:00
test Bug 5449: JSON malformed in Koha - Blocker with jQuery 1.4.x 2011-03-12 08:53:41 +13:00
tmp/modified_authorities
tools Bug 10565: Add a "Patron List" feature for storing and manipulating collections of patrons 2013-10-14 21:29:44 +00:00
virtualshelves Bug 10853: All existing routing to get a CSV should return a MARC csv 2013-10-11 02:16:33 +00:00
xt Bug 9802 - add test case to ensure man pages have correct XML 2013-03-20 15:11:10 -04:00
.htaccess
.mailmap
about.pl Bug 10915: (QA followup) warn if cannot read history.txt 2013-09-20 17:25:57 +00:00
changelanguage.pl Bug 6755 Problems with switching languages 2011-09-23 09:47:09 +12:00
edithelp.pl 7368 Typo in edithelp.pl warning 2013-04-18 09:47:58 -04:00
fix-perl-path.PL
help.pl Bug 10052: QA Followup 2013-05-23 08:55:12 -07:00
INSTALL Bug 7759, update of install files to use background indexing (and some whitespace tidy) 2012-04-20 16:11:52 +02:00
install-CPAN.pl
INSTALL.debian Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.fedora7 Bug 7440 - Remove NoZebra vestiges 2013-03-19 21:17:04 -04:00
INSTALL.opensuse Bug 7759, update of install files to use background indexing (and some whitespace tidy) 2012-04-20 16:11:52 +02:00
INSTALL.ubuntu Bug 7764: (follow-up) editorial tweaks 2013-10-04 16:27:55 +00:00
koha_perl_deps.pl bug 10548: fix count of missing required dependencies by koha_perl_deps.pl 2013-07-11 14:03:32 +00:00
kohaversion.pl Bug 5336: DBRev 3.13.00.032 2013-10-22 13:31:22 +00:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
mainpage.pl Bug 10080 - Change system pref IndependantBranches to IndependentBranches 2013-05-22 07:58:23 -07:00
Makefile.PL Bug 10565: (follow-up) ensure that new patron_lists/ CGI directory is installed 2013-10-14 22:44:23 +00:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.robots
rewrite-config.PL Bug 10712: Save missing config variables to install log 2013-08-13 14:14:30 +00:00

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 3 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/