Koha/tools
Kyle M Hall 5cd08373b1 Bug 26059: Create guarantor/guarantee links on patron import
The change to allow multiple guarantors was meant to maintain the
ability to import patrons with a Koha patron guarantor, but is not
working as intended.

A) Adding the guarantor simply doesn't work
B) We have two columns named 'relationship', one for the borrowers
table, and one for the guarantor relationships table. This clearly
doesn't work and will cause confusion. The one for the guarantor
relationships table should be renamed.
C) guarantor_firstname and guarantor_surname in the CSV file do nothing
and should be removed.

This patch also fixes a minor issue that causes warnings like:
CGI::param called in list context from
/kohadevbox/koha/tools/import_borrowers.pl line 124

Test Plan:
1) Create a CSV with contents like:
cardnumber,surname,firstname,branchcode,categorycode,guarantor_relationship,guarantor_id
bloop,gloop,froop,MPL,J,father,48
brim,flim,zim,MPL,J,father,48
2) Attempt to upload this file, ensure you have a borrowernumber 48 that
can have guarantors
3) Note the accounts are not linked
4) Apply this patch
5) Restart all the things!
6) Upload the file again
7) The patrons should now be linked!
8) Download the starter CSV file
9) Note the second relationship column is now guarantor_relationship
10) Note the columns guarantor_firstname and guarantor_surname are no longer present

Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com>

Signed-off-by: Marti Fuerst <mfuerst@hmcpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-02-12 12:14:50 +01:00
..
csv-profiles
access_files.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
ajax-inventory.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
automatic_item_modification_by_age.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
background-job-progress.pl
batch_delete_records.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
batch_extend_due_dates.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
batch_record_modification.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
batch_records_ajax.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
batchMod.pl Bug 23830: Adapt callers 2021-02-08 17:09:34 +01:00
cleanborrowers.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
copy-holidays.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
csv-profiles.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
exceptionHolidays.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
export.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
holidays.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
import_borrowers.pl Bug 26059: Create guarantor/guarantee links on patron import 2021-02-12 12:14:50 +01:00
inventory.pl Bug 4037: Add item type filter to inventory tool 2021-02-09 09:23:51 +01:00
koha-news.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
letter.pl Bug 22818: Add support for ILL notices 2020-11-11 08:35:10 +01:00
manage-marc-import.pl Bug 23019: Add profiles to stage-import-batch and magnage-import-batch pages 2020-11-11 15:55:49 +01:00
marc_modification_templates.pl Bug 26784: Silence warns about comparing undefined values for MARC modification templates 2020-10-26 00:14:41 +01:00
modborrowers.pl Bug 27413: Restore debarred and debarredcomment to batch patron mod tools 2021-01-19 15:32:01 +01:00
newHolidays.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
overduerules.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
picture-upload.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
problem-reports.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
quotes-upload.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
quotes.pl Bug 27251: Rewrite QOTD with the Koha REST API 2021-01-29 09:03:45 +01:00
scheduler.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
showdiffmarc.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
stage-marc-import.pl Bug 26854: Remove log of STDERR 2020-11-20 08:16:02 +01:00
stockrotation.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
tools-home.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
upload-cover-image.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
upload-file.pl
upload.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
viewlog.pl Bug 27486: Rename system preference delimiter to CSVDelimiter 2021-01-29 09:03:45 +01:00