Nick Clemens 03bb55f104 Bug 18146: Fix tests for OverduesBlockRenewing ... This pref was supposedly covered by tests, but the conditions were wrong and we didn't test the reasons we were failing so the code was being missed To test: 1 - Add a warn around in the conditional at line 2748: } elsif ( ($hasoverdues and $overduesblockrenewing eq 'block') || ($itemissue->{overdue} and $overduesblockrenewing eq 'blockitem') ) { warn "SUCCESS!" return ( 0, 'overdue'); } 2 - prove -v t/db_dependent/Circulation.t | grep SUCCESS 3 - No output 4 - Apply patch 5 - Repeat 6 - SUCCESS! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>		2021-02-15 11:59:24 +01:00
..
Acquisition	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
Biblio	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
Budgets	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
Circulation	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
db_dependent	Bug 18146: Fix tests for OverduesBlockRenewing	2021-02-15 11:59:24 +01:00
edi_testfiles
etc	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
External
Koha	Bug 23763: (QA follow-up) Add +x to Search.t file permissions	2021-02-08 17:09:32 +01:00
lib	Bug 27336: Fix xt/find-missing-filters.t	2021-01-11 10:27:37 +01:00
Members	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
Number	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
Search	Bug 12430: Add unit tests for C4::Search::buildQuery	2020-12-04 15:32:11 +01:00
Serials	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
SIP
Test	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
00-checkdatabase-version.t	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
00-deprecated.t
00-load.t	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
00-merge-conflict-markers.t	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
00-testcritic.t	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
00-valid-xml.t	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
Auth.t	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
Auth_with_shibboleth.t	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
AuthoritiesMarc_MARC21.t
AuthoritiesMarc_UNIMARC.t
Barcodes_annual.t
Barcodes_EAN13.t
Barcodes_hbyymmincr.t
Barcodes_incremental.t
Biblio.t	Bug 11299: (QA follow-up) Fix tests, spaces, and CSS update	2021-01-14 14:03:49 +01:00
Biblio2.t	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
Boolean.t
Budgets.t
Calendar.t	Bug 25802: Change addDate to addDuration	2021-01-22 14:59:27 +01:00
Charset.t
Circulation_barcodedecode.t	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
ClassSortRoutine.t
ClassSortRoutine_Dewey.t
ClassSortRoutine_Generic.t
ClassSortRoutine_LCC.t
ClassSource.t
Context.t	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
Contract.t
Creators.t
DateUtils.t	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
Debug.t
dummy.t	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
Edifact.t	Bug 18267: (QA follow-up) fix typo: overriden => overridden	2020-11-24 09:52:36 +01:00
EdiInvoice.t	Bug 18267: Refactored Edifact Price Calculations	2020-11-16 13:46:48 +01:00
Ediorder.t
Ediordrsp.t
EdiTransport.t	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
Form_MessagingPreferences.t
HtmlTags.t
ImportBatch.t	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
Installer_PerlModules.t
Installer_pm.t
ItemCirculationAlertPreference.t
Koha.t
Koha_MetadataRecord.t	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
Koha_SearchEngine_Elasticsearch_Browse.t
Koha_Template_Plugin_Cache.t	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
Koha_Template_Plugin_HtmlId.t	Bug 27336: Sanitize correctly HTML id	2021-01-11 10:27:37 +01:00
Koha_Template_Plugin_Koha.t	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
Koha_Util_FrameworkPlugin.t
Koha_Util_MARC.t
Labels.t	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
Labels_split_ccn.t
Labels_split_ddcn.t
Labels_split_lccn.t
Labels_split_Regex.t
Languages.t	Bug 27491: Fix t/Languages.t	2021-01-25 10:52:02 +01:00
Letters.t
Logger.t	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
Makefile.t	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
Matcher.t
Members_Messaging.t
OpenLibrarySearch.t	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
Output.t
Output_JSONStream.t	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
Patron.t
Patroncards.t
Patroncards_Batch.t
Patroncards_Lib.t
Patroncards_Patroncard.t
Patroncards_Profile.t
Patroncards_Template.t
Prices.t	Bug 27485: Rename system preference gist to TaxRates	2021-01-22 14:09:46 +01:00
RecordProcessor.t	Bug 25008: Tests for ->options	2020-04-14 08:31:22 +01:00
Ris.t
Scheduler.t	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
Scrubber.t
Search.t
Search_PazPar2.t
SimpleMARC.t	Bug 26781: Check for subfield defined rather than truth	2020-10-26 00:14:41 +01:00
SMS.t
SocialData.t	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
Stats.t
SuggestionEngine.t	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
SuggestionEngine_AuthorityFile.t	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
template_filters.t	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
timezones.t	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
TmplToken.t
Token.t	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
XSLT.t