Tomas Cohen Arazi 051f551986 Bug 15448: Filter out items hidden in OPAC on placing hold ... This patch leverages on bug 24254's Koha::Items->filter_by_visible_in_opac to filter out items that shouldn't be presented to the end user in the OPAC interface. To test: 1. Circulation and Fine rules for item-level holds are set to allow. 2. Setting the OpacHiddenItems preference to "ccode: [SUPPRESS]" 3. An item with collection Code Suppress is set. 4. Search for the title in the OPAC. => SUCCESS: The Suppress ccode item isn't shown. 5. View the detail page for the title. => SUCCESS: The suppress ccode item isn't shown. 6. Place a hold on the item: -- Click "Show more options" -- Select "A specific item" => FAIL: the ccode with the opachiddenitems rule has an item that appear in the list to place a hold 7. Apply this patch and repeat 6 => SUCCESS: The item doesn't show! 8. Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>		2021-01-14 14:03:49 +01:00
..
clubs	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
errors	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
external/overdrive	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
rss
sci	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
sco	Bug 24083: (follow-up) Make requested changes	2020-11-11 16:09:58 +01:00
svc	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
ilsdi.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
maintenance.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
oai.pl
opac-account-pay-paypal-return.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-account-pay-return.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-account-pay.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-account.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-addbybiblionumber.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-alert-subscribe.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-article-request-cancel.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-authorities-home.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-authoritiesdetail.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-basket.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-blocked.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-browse.pl	Bug 27200: (follow-up) Browse search interface update	2020-12-26 17:58:43 +01:00
opac-browser.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-changelanguage.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-course-details.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-course-reserves.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-detail.pl	Bug 26145: Allow multi covers per item	2020-10-12 11:28:41 +02:00
opac-discharge.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-downloadcart.pl	Bug 5087: Add server-side check	2020-07-23 11:17:27 +02:00
opac-downloadshelf.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-export.pl
opac-holdshistory.pl	Bug 20936: (follow-up) add biblio and item relation to old holds and set a limit on search holds	2020-11-11 15:55:48 +01:00
opac-ics.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-idref.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-illrequests.pl	Bug 22818: Add generation and sending of notices	2020-11-11 08:35:10 +01:00
opac-image.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-imageviewer.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-ISBDdetail.pl
opac-issue-note.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-library.pl
opac-main.pl	Bug 26123: Add message notification to patron dashboard	2021-01-12 16:40:41 +01:00
opac-MARCdetail.pl	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
opac-memberentry.pl	Bug 27148: Fix bug on self registration when user category is hidden	2020-12-26 17:58:33 +01:00
opac-messaging.pl	Bug 24663: Remove authnotrequired if set to 0	2020-09-03 10:40:35 +02:00
opac-modrequest-suspend.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-modrequest.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-mymessages.pl	Bug 24663: Remove authnotrequired if set to 0	2020-09-03 10:40:35 +02:00
opac-news-rss.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-overdrive-search.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-passwd.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-password-recovery.pl	Bug 26941: Fix OPAC password recovery error messages	2020-12-21 10:08:02 +01:00
opac-patron-consent.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-patron-image.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-privacy.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-ratings-ajax.pl
opac-ratings.pl
opac-readingrecord.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-recordedbooks-search.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-registration-verify.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-renew.pl	Bug 24083: Add support for unseen_renewals	2020-11-11 16:09:58 +01:00
opac-reportproblem.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-request-article.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-reserve.pl	Bug 15448: Filter out items hidden in OPAC on placing hold	2021-01-14 14:03:49 +01:00
opac-restrictedpage.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-retrieve-file.pl
opac-review.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-routing-lists.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-search-history.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-search.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-sendbasket.pl	Bug 22343: (QA follow-up) Wrap email creation inside the try/catch block	2020-10-02 10:54:41 +02:00
opac-sendshelf.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-serial-issues.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-shareshelf.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-shelves.pl	Bug 26752: Convert OPAC list download modal to dropdown	2020-10-26 00:04:18 +01:00
opac-showmarc.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-showreviews.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-suggestions.pl	Bug 27230: Display OPAC description for OPAC_SUG	2020-12-26 18:14:11 +01:00
opac-tags.pl	Bug 23276: Do not display tag if pref TagsEnabled is off	2020-06-15 10:32:29 +02:00
opac-tags_subject.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-topissues.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
opac-user.pl	Bug 24083: Add support for unseen_renewals	2020-11-11 16:09:58 +01:00
tracklinks.pl	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
unapi