Koha/koha-tmpl/intranet-tmpl/prog/en/modules
Kyle M Hall 0895eadd67 Bug 20798: Client side validation for for fund selection prevents adding only some records to a basket
Bug 19453 "fixed" the fund validation that never actually worked. This validation should be removed altogether instead. It is overly simplistic and simply checks to see if each record in the batch has a fund selected regardless of whether that record will be imported or not.

In addition, the code completely ignores items generated by MarcItemFieldsToOrder such that even if items on that page have a fund selected, the javascript forces the librarian to make a selection from the left-hand fund pulldown even though it will not be used.

Considering this bad validation is basically 'new' as it never worked before, the most sensible course of action would be to 'undo' the change and remove the validation.

Test Plan:
1) Add records to a basket from an import batch
2) Select only some of those items in the batch
3) Note Koha will not let you import them unless you set funds for *all*
   records in the batch
4) Apply this patch
5) Note Koha no longer forces a budget to be selected in the pulldown

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

https://bugs.koha-community.org/show_bug.cgi?id=20789
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-05-29 14:20:08 +00:00
..
acqui Bug 20798: Client side validation for for fund selection prevents adding only some records to a basket 2018-05-29 14:20:08 +00:00
admin Bug 20827: Display Fund's owner name when selected 2018-05-29 12:41:16 +00:00
authorities
basket
batch
catalogue Bug 20652: Fix result sorting after search on limit only 2018-05-29 12:14:19 +00:00
cataloguing Bug 20761: Fix some js includes in rancor 2018-05-29 14:16:56 +00:00
circ Bug 20822: (bug 18789 follow-up) Fix HOLD_SLIP 2018-05-29 11:58:54 +00:00
clubs
common
course_reserves
errors
help Bug 20706: Fix bad HTML link to help file 2018-05-16 11:31:14 -03:00
ill
installer
labels
members Bug 20752: Fix capitalization on the files tab for patron files 2018-05-29 13:27:30 +00:00
offline_circ
onboarding
patron_lists
patroncards
plugins
reports Bug 20774: Trivial HTML error in itemslost.tt 2018-05-29 13:34:02 +00:00
reserve
reviews
rotating_collections
serials Bug 7910: Give feedack when the subscriptions have been renewed 2018-05-11 11:04:44 -03:00
services
suggestion
tags
test
tools Bug 20791: Correct capitalization on 'Notices & slips' page 2018-05-29 13:27:01 +00:00
virtualshelves
about.tt Bug 7143: Update about page for documentation team 2018-05-16 13:13:09 -03:00
auth.tt
intranet-main.tt