Koha/koha-tmpl/intranet-tmpl/prog/en/includes
Katrin Fischer 50927bb9b5
Bug 26628: Fix access to clubs when user only has clubs permission
If a user only has the clubs and no permission from the tools section,
they can't access the patron clubs page by navigation. This patch
extends the permission checks for tools to include the clubs, that
live on the tools page, but have a top level permission.

To test:
- create a patron with only the catalogue and clubs permissions
- log in to the staff client as that patron
- navigate to a patron record, confirm you can see the Clubs tab in the patron account, can add patrons to and remove patrons from clubs
- confirm you don't have a link to the Tools module either on the Koha homepage or in the More menu
- enter the clubs URL manually (/cgi-bin/koha/clubs/clubs.pl), confirm you are allowed to open the page
- Apply patch
- The only changes should be:
  - You can now see the Tools entry in the More navigation menu
  - You can now see the Tools module link on the start page
  - Both take you to the tools page, only visible tools is 'Patron clubs'

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-01-31 10:50:52 -03:00
..
background_jobs Bug 31711: (bug 27421 follow-up) Fix add to basket from a new file 2022-11-15 18:44:30 -03:00
catalogue Bug 28327: Unify CSV delimiter special behavior for tabulation 2022-08-19 15:53:12 -03:00
csv_headers Bug 28327: Unify CSV delimiter special behavior for tabulation 2022-08-19 15:53:12 -03:00
mana Bug 30952: Undo change to Home breadcrumb for remaining templates 2022-10-12 16:00:50 -03:00
modals Bug 23838: (QA follow-up) Move include files 2022-07-22 12:53:50 -03:00
str Bug 24606: (QA follow-up) Remove string variable 2022-11-10 14:25:57 -03:00
virtualshelves/merge Bug 32097: Consistent classes for primary buttons: Lists 2022-11-10 10:27:17 -03:00
about-team.inc Bug 29602: Surround strings with span tag 2022-04-19 21:25:51 -10:00
accounts.inc Bug 23012: Show the PROCESSING_FOUND account credit type 2022-10-24 17:43:28 -03:00
acquisitions-add-to-basket.inc
acquisitions-menu.inc Bug 31115: (QA follow-up) Use more specific permission for sidebar link 2022-10-24 14:11:08 -03:00
acquisitions-search.inc Bug 31936: Restore link to advanced search in acquisitions header 2022-10-24 13:14:19 -03:00
acquisitions-toolbar.inc Bug 28082: Add acquisitions toolbar to vendors on vendor search page 2022-05-10 15:17:17 -10:00
additional-fields-display.inc
additional-fields-entry.inc Bug 31254: Add additional fields for accountlines 2022-09-21 18:58:28 -03:00
admin-items-search-field-form.inc Bug 32213: Reindent item search fields templates 2022-11-29 09:05:15 -03:00
admin-menu.inc Bug 31378: Rename Auth Provider to Identity Provider and add Client.t tests 2022-11-08 14:39:51 -03:00
adv-search.inc Bug 30952: Better header search bar on smaller screens 2022-10-12 16:14:45 -03:00
auth-finder-search.inc Bug 29434: add UNIMARC relationship codes for authorities 2022-08-09 07:42:21 -03:00
auth-two-factor.inc Bug 30588: Add missing include file 2022-10-21 11:36:58 -03:00
authorities-search-results.inc Bug 29602: Surround strings with span tag 2022-04-19 21:25:51 -10:00
authorities-search.inc Bug 30952: Better header search bar on smaller screens 2022-10-12 16:14:45 -03:00
authorities-toolbar.inc
authorities.inc
authorities_js.inc Bug 26019: Koha should set SameSite attribute on cookies 2022-04-13 15:55:38 +02:00
authority-detail-modal.inc
av-build-dropbox.inc Bug 30603: Display Sort1 and Sort2 as free text if no AV exists 2022-05-10 23:09:09 -10:00
biblio-title-head.inc
biblio-title.inc Bug 29602: (follow-up) Surround strings with span tag 2022-04-19 21:25:51 -10:00
biblio-view-menu.inc Bug 32005: Cleanup indenting 2022-11-10 09:21:50 -03:00
blocked-fines.inc Bug 30487: Convert checkout and patron details page tabs to Bootstrap 2022-10-17 08:06:34 -03:00
blocking_errors.inc
branch-selector.inc
budget_planning.inc Bug 30629: fix <span> in title of some pages 2022-06-01 16:28:28 -03:00
budgets-active-currency.inc
budgets-admin-search.inc Bug 30952: Better header search bar on smaller screens 2022-10-12 16:14:45 -03:00
budgets-admin-toolbar.inc
calendar.inc Bug 31261: Introduce flatpickr-futureinclusive 2022-11-14 09:15:51 -03:00
cat-menu.inc Bug 31417: Update and reference cat-menu.inc 2022-10-18 10:28:34 -03:00
cat-search.inc Bug 30952: Better header search bar on smaller screens 2022-10-12 16:14:45 -03:00
cat-toolbar.inc Bug 21978: (follow-up) Stop passing holdfor_cardnumber 2022-06-24 12:29:14 -03:00
catalog-strings.inc
cataloging-search.inc Bug 30952: Better header search bar on smaller screens 2022-10-12 16:14:45 -03:00
catalogue-search-box.inc Bug 32214: Prevent empty search option block in catalog search header 2022-11-16 16:29:05 -03:00
cateditor-ui.inc Bug 31818: Enable table elements in keyboard shortcuts popover 2022-11-09 10:03:04 -03:00
cateditor-widgets-marc21.inc Bug 32321: Pre-populate material type for 006 in advanced cataloging editor 2023-01-27 15:14:47 -03:00
category-out-of-age-limit.inc
chart.inc
checkin-search-box.inc Bug 30952: Header search - move tabs to the right (and other tweaks) 2022-10-12 16:14:31 -03:00
checkin-search.inc Bug 30952: Better header search bar on smaller screens 2022-10-12 16:14:45 -03:00
checkouts-table-footer.inc Bug 30718: Fix time display 2022-08-19 08:26:38 -03:00
checkouts-table.inc Bug 31728: Remove duplicate claims modal template markup 2022-10-20 11:44:03 -03:00
circ-menu.inc Bug 10950: (follow-up) Change display of pronoun fields 2022-10-03 15:01:34 -03:00
circ-nav.inc Bug 31404: (QA follow-up) Mostly whitespace fixes 2022-09-07 13:26:33 -07:00
circ-search.inc Bug 30952: Better header search bar on smaller screens 2022-10-12 16:14:45 -03:00
cities-admin-search.inc Bug 30952: Better header search bar on smaller screens 2022-10-12 16:14:45 -03:00
clubs-table.inc Bug 29602: (follow-up) Surround strings with span tag 2022-04-19 21:25:51 -10:00
columns_settings.inc Bug 31962: Add tooltip to 'configure' on datatable controls 2023-01-31 10:49:34 -03:00
contracts-admin-search.inc Bug 30952: Better header search bar on smaller screens 2022-10-12 16:14:45 -03:00
country-list.inc
currencies-admin-search.inc Bug 30952: Better header search bar on smaller screens 2022-10-12 16:14:45 -03:00
datatables.inc
date-format.inc
delimiter_text.inc
desks-admin-search.inc Bug 30952: Better header search bar on smaller screens 2022-10-12 16:14:45 -03:00
doc-head-close-receipt.inc
doc-head-close.inc Bug 29723: Add a "Configure table" button for KohaTable tables 2022-08-16 10:12:26 -03:00
doc-head-open.inc Bug 30543: Decouple DumpSearchQueryTemplate from other tempalte dump preferences 2022-08-09 08:44:14 -03:00
empty_line.inc
erm-search.inc Bug 32030: Add better icons 2022-11-08 09:44:41 -03:00
facets.inc Bug 17170: (follow-up) Use x instead of X 2022-10-21 11:15:24 -03:00
filter-orders.inc Bug 31991: Restore style of sidebar forms 2022-10-27 09:41:39 -03:00
form-blocks.inc
format_price.inc
greybox.inc
guided-reports-view.inc
header.inc Bug 26628: Fix access to clubs when user only has clubs permission 2023-01-31 10:50:52 -03:00
holds_table.inc Bug 31902: Next header row inside a thead 2022-11-09 14:01:53 -03:00
home-search.inc Bug 30952: Better header search bar on smaller screens 2022-10-12 16:14:45 -03:00
html_helpers.inc Bug 32109: Fix spacing in toolbars containing text links 2022-11-16 15:51:58 -03:00
i18n.inc
ill-availability-table.inc
ill-list-table-strings.inc
ill-list-table.inc Bug 32199: Add page-section to various patron pages 2022-11-16 09:28:58 -03:00
ill-toolbar.inc
installer-doc-head-close.inc Bug 30011: Update links to jQueryUI assets, remove datepicker references, etc. 2022-04-08 15:49:16 +02:00
installer-intranet-bottom.inc Bug 29155: Update links to jQuery and jQuery Migrate files 2022-04-25 10:00:22 -10:00
installer-strings.inc
intranet-bottom.inc
intranetstylesheet.inc
job_progress.inc Bug 31666: (QA follow-up) Add filters 2022-10-05 16:08:16 -03:00
js-biblio-format.inc Bug 31083: Fix part_name handling in js-biblio-format 2022-07-18 11:16:16 -03:00
js-date-format.inc Bug 30310: Fix date_to_rfc3339 2023-01-31 10:19:46 -03:00
js-patron-format-address.inc Bug 32570: Display patron.state correctly 2023-01-31 10:19:44 -03:00
js-patron-format.inc Bug 21978: Add support for middle name 2022-06-24 12:24:11 -03:00
js-patron-get-age.inc Bug 30059: Deal with timezones 2022-03-24 14:22:10 -10:00
js_includes.inc Bug 32520: Use DefaultPatronSearchFields in patron_autocomplete 2023-01-27 16:20:54 -03:00
keyboard_shortcuts.inc
labels-toolbar.inc
langmenu-staff-top.inc
last-borrower.inc Bug 30952: Staff interface redesign (header) 2022-10-12 15:58:16 -03:00
letters-search.inc Bug 30952: Better header search bar on smaller screens 2022-10-12 16:14:45 -03:00
member-alt-address-style.inc Bug 30603: Fix other occurrences 2022-05-10 23:09:09 -10:00
member-alt-contact-style.inc
member-display-address-style.inc
member-display-alt-address-style.inc
member-main-address-style.inc Bug 30603: Fix other occurrences 2022-05-10 23:09:09 -10:00
member-search-box.inc Bug 30952: Header search - move tabs to the right (and other tweaks) 2022-10-12 16:14:31 -03:00
members-toolbar.inc Bug 31713: (follow-up) Display print option for any outstanding 2022-11-03 10:05:10 -03:00
merge-record.inc Bug 29602: (follow-up) Surround strings with span tag 2022-04-19 21:25:51 -10:00
messaging-preference-form.inc Bug 31166: Digest option is not selectable for phone when PhoneNotification is enabled 2022-12-13 14:59:51 -03:00
modal-claims.inc Bug 29983: Fix xt/author/valid-templates.t 2022-08-08 11:13:59 -03:00
noadd-warnings.inc
onboarding_messages.inc
page-numbers.inc
password_check.inc
patron-age.inc
patron-article-requests.inc Bug 30487: Convert checkout and patron details page tabs to Bootstrap 2022-10-17 08:06:34 -03:00
patron-restrictions-tab.inc Bug 31095: Remove GetDebarments from circ/circulation.pl 2023-01-31 10:19:24 -03:00
patron-return-claims.inc Bug 30487: Convert checkout and patron details page tabs to Bootstrap 2022-10-17 08:06:34 -03:00
patron-search-box.inc Bug 30952: Header search - move tabs to the right (and other tweaks) 2022-10-12 16:14:31 -03:00
patron-search-header.inc Bug 30952: Better header search bar on smaller screens 2022-10-12 16:14:45 -03:00
patron-search.inc Bug 32517: lowercase category codes to avoid mismatch 2023-01-18 15:57:24 +00:00
patron-title.inc Bug 10950: (follow-up) Change display of pronoun fields 2022-10-03 15:01:34 -03:00
patron-toolbar.inc Bug 31421: Add a limited option to template plugin 2022-10-27 09:42:57 -03:00
patron_messages.inc Bug 18556: Clarify lost and gonenoaddress messages 2022-10-24 11:28:38 -03:00
patroncards-errors.inc
patroncards-toolbar.inc
patronfields.inc Bug 10950: Add intranet/OPAC form fields 2022-10-03 15:01:32 -03:00
patrons-admin-search.inc Bug 30952: Better header search bar on smaller screens 2022-10-12 16:14:45 -03:00
permissions.inc Bug 24606: Add item template editor permission 2022-11-10 14:25:23 -03:00
popup-bottom.inc
pos-menu.inc
prefs-admin-search.inc Bug 30952: Better header search bar on smaller screens 2022-10-12 16:14:45 -03:00
prefs-menu.inc Bug 32147: Capitalization: E-Resource management 2022-11-16 08:46:20 -03:00
recalls.inc Bug 30733: Simplify translatable strings 2022-06-17 10:16:34 -03:00
relatives-issues-table.inc Bug 30487: Convert checkout and patron details page tabs to Bootstrap 2022-10-17 08:06:34 -03:00
renew-search-box.inc Bug 30952: Header search - move tabs to the right (and other tweaks) 2022-10-12 16:14:31 -03:00
renew_results.inc
renew_strings.inc Bug 29602: Surround strings with span tag 2022-04-19 21:25:51 -10:00
reports-menu.inc Bug 31401: (QA follow-up) Remove Koha.ArePluginsEnabled, it is no longer needed 2022-09-07 13:55:37 -07:00
reports-toolbar.inc Bug 26486: Group edit buttons in reports toolbar 2022-06-27 12:32:24 -03:00
resort_form.inc
restriction-types.inc Bug 31095: Remove GetDebarments from circ/circulation.pl 2023-01-31 10:19:24 -03:00
rotating-collections-toolbar.inc
search_indexes.inc Bug 24127: Add 'code' and title to shelving location search 2022-10-03 08:27:54 -03:00
select2.inc
serials-menu.inc
serials-search.inc Bug 30952: Better header search bar on smaller screens 2022-10-12 16:14:45 -03:00
serials-toolbar.inc
shortcut.inc Bug 30952: Staff interface redesign (header) 2022-10-12 15:58:16 -03:00
slip-print.inc
stockrotation-toolbar.inc
sub-header.inc Bug 30952: Staff interface redesign (header) 2022-10-12 15:58:16 -03:00
subscriptions-search.inc Bug 32094: Consistent classes for primary buttons: Serials 2022-11-14 09:30:49 -03:00
subtype_limits.inc Bug 22605: (QA follow-up) Make Braille search option stick 2022-03-24 14:22:10 -10:00
subtypes_unimarc.inc
suggestions-add-search.inc Bug 30952: Better header search bar on smaller screens 2022-10-12 16:14:45 -03:00
tools-item-action.inc Bug 28290: Don't send subfields to 'as_string' if none to send 2022-09-07 13:50:21 -07:00
tools-menu.inc Bug 31417: Update and reference cat-menu.inc 2022-10-18 10:28:34 -03:00
tools-nomatch-action.inc
tools-overlay-action.inc
transaction_types.inc Bug 30733: Move all semicolons inside the translatable strings 2022-06-17 10:16:40 -03:00
transfer_reasons.inc Bug 29602: Surround strings with span tag 2022-04-19 21:25:51 -10:00
validator-strings.inc
vendor-menu.inc
virtualshelves-toolbar.inc
waiting_holds.inc Bug 22456: Staff interface handling 2022-07-29 15:28:38 -03:00
wysiwyg-systempreferences.inc
xslt-handler.inc Bug 29602: Surround strings with span tag 2022-04-19 21:25:51 -10:00
z3950-admin-search.inc Bug 30952: Better header search bar on smaller screens 2022-10-12 16:14:45 -03:00
z3950_search.inc