Main Koha release repository https://koha-community.org
Find a file
Nick Clemens 0c8e4780d7 Bug 28290: Don't send subfields to 'as_string' if none to send
This fixes an error where we send a blank string to
Marc::Field->as_string

The subroutine fails as the regex is marked as incomplete as there is
nothing between the brackets

Also fixes a missing hidden input for 'item_action' when no items are
staged during import

 1 - Define a new matching rule with no subfields
    Match-threshold: 1000
    Record type: bibliographic record
    Search-index: Other-control-number
    Score: 1000
    Tag: 035
    Subfields:
    Offset:
    Length:
 2 - Attempt to stage a record with an 035 using this rule (i will
     attach example to bug)
 3 - Staging fails
 4 - Stage again with no matching rule
 5 - Manage the staged record, try to apply the matching rule
 6 - It fails, 500 error
 7 - Apply patch
 8 - Restart all the things
 9 - Apply rule again, it works!
10 - Stage the record again using the rule for matching
11 - It stages and matches!

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit eded6edacc)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2022-10-31 19:58:37 +00:00
acqui Bug 14680: Always subtract discount from price to calculate estimated cost 2022-08-23 17:24:04 +00:00
admin Bug 28327: Unify CSV delimiter special behavior for tabulation 2022-10-14 19:29:41 +00:00
api Bug 29105: Add effective_itemtype handling to items api 2022-08-23 19:19:03 +00:00
authorities Bug 29333: Fix encoding of imported UNIMARC authorities 2022-08-23 15:30:11 +00:00
basket Bug 29871: Remove marcflavour param in Koha::Biblio->get_marc_notes 2022-07-12 15:54:27 +00:00
bin Bug 20582: Turn Koha into a Mojolicious application 2020-10-06 12:00:04 +02:00
C4 Bug 28290: Don't send subfields to 'as_string' if none to send 2022-10-31 19:58:37 +00:00
catalogue Bug 30779: Remove _update_import_record_marc and update tests 2022-10-03 22:48:43 +00:00
cataloguing Bug 30909: Retain permanent_location if mapped 2022-09-16 15:16:46 +00:00
circ Bug 30905: Show waiting recalls in patron account 2022-08-23 19:43:54 +00:00
clubs
course_reserves Bug 30409: barcodedecode() should always trim barcode 2022-07-13 19:44:18 +00:00
debian Bug 31348: Make koha-plack stop gracefully 2022-10-14 22:02:59 +00:00
docs Bug 30808: Add the 22.05 release team. 2022-05-25 23:56:12 -10:00
errors Bug 29420: HTTP status code incorrect when calling error pages directly under Plack/PSGI 2022-04-20 09:03:39 -10:00
etc Bug 31033: Explicitly define max child processes for SIP server 2022-10-14 22:15:48 +00:00
ill
installer Increment version for 22.05.06 release 2022-10-25 17:56:35 +00:00
Koha Bug 32011: 2FA - Prevent qr_code to not be generated 2022-10-31 17:17:23 +00:00
koha-tmpl Bug 28290: Don't send subfields to 'as_string' if none to send 2022-10-31 19:58:37 +00:00
labels Bug 31137: (QA follow-up) Also fix new template page 2022-08-23 10:29:30 -06:00
lib/CGI/Session/Serialize
members Bug 26689: Prepend letter codes. 2022-09-02 17:55:09 +00:00
misc Bug 30042: Remove Date::Calc dependency in batch_anonymize.pl 2022-10-31 19:32:05 +00:00
offline_circ Bug 30525: Items batch modification broken 2022-04-21 13:41:36 -10:00
opac Bug 30262: Trim whitespace off tracklinks.pl URLs 2022-10-31 17:57:09 +00:00
patron_lists
patroncards Bug 24001: Fix patron card template edition 2022-04-28 10:49:20 -10:00
plugins Bug 29787: Add plugin version to plugin search results 2022-04-08 15:49:15 +02:00
pos Bug 28481: (RM follow-up) formatting 2021-12-16 12:13:51 -10:00
recalls Bug 30924: Add missing branchtransfers.reason value for recall cancellation 2022-07-13 19:13:33 +00:00
reports Bug 28327: Unify CSV delimiter special behavior for tabulation 2022-10-14 19:29:41 +00:00
reserve Bug 30992: Improve translatability for Waiting at|On hold 2022-09-29 16:57:12 +00:00
reviews Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
rotating_collections
serials Bug 29608: Made so doesn't require full permission 2022-10-31 19:55:45 +00:00
services
skel
suggestion Bug 30127: By default show pending suggestions tab 2022-05-10 23:09:09 -10:00
svc Bug 26632: Remove two more occurrences 2022-10-03 22:23:03 +00:00
t Bug 31112: (QA follow-up) Reduce database queries 2022-10-31 17:44:37 +00:00
tags
tmp/modified_authorities
tools Bug 28327: Unify CSV delimiter special behavior for tabulation 2022-10-14 19:29:41 +00:00
virtualshelves Bug 29114: Trim whitespace before the barcode 2022-08-23 19:29:20 +00:00
xt Bug 27619: (QA follow-up) Remove xt/sample_notices.t 2022-05-11 11:28:48 +01:00
.editorconfig
.eslintrc.json
.gitignore
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap 22.05.00: Update mailmap 2022-05-25 23:56:12 -10:00
.perlcriticrc
.proverc.dist
.scss-lint.yml
about.pl Bug 27667: Display a warning for records missing in Elasticsearch 2022-08-23 19:26:34 +00:00
app.psgi
changelanguage.pl
cpanfile Revert "Bug 31499: Add libhttp-tiny-perl 0.076 dependency for ES7" 2022-09-28 14:48:28 +00:00
fix-perl-path.PL
gulpfile.js Bug 30373: Enable translation of UNIMARC frameworks 2022-04-21 13:41:35 -10:00
help.pl
INSTALL
Koha.pm Increment version for 22.05.06 release 2022-10-25 17:56:35 +00:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl
Makefile.PL
MANIFEST.SKIP
package.json
README
README.md
README.robots
rewrite-config.PL
yarn.lock

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo