Koha/svc
Julian Maurice b168f4a2e9 Bug 21395: Make perlcritic happy
This patch adds a .perlcriticrc (copied from qa-test-tools) and fixes
almost all perlcrictic violations according to this .perlcriticrc
The remaining violations are silenced out by appending a '## no critic'
to the offending lines. They can still be seen by using the --force
option of perlcritic
This patch also modify t/00-testcritic.t to check all Perl files using
the new .perlcriticrc.
I'm not sure if this test script is still useful as it is now equivalent
to `perlcritic --quiet .` and it looks like it is much slower
(approximatively 5 times slower on my machine)

Test plan:
1. Run `perlcritic --quiet .` from the root directory. It should output
   nothing
2. Run `perlcritic --quiet --force .`. It should output 7 errors (6
   StringyEval, 1 BarewordFileHandles)
3. Run `TEST_QA=1 prove t/00-testcritic.t`
4. Read the patch. Check that all changes make sense and do not
   introduce undesired behaviour

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2020-06-29 12:37:02 +02:00
..
cataloguing Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
club Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
config Bug 14391: (QA follow-up) Resolve POD warn on svc..systempreferences 2018-11-07 12:29:32 +00:00
hold Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
letters Bug 7862: Preventing warns when creating a notice 2019-05-15 12:10:52 +00:00
mana Bug 22249: Mana - Move comment process in a dedicated sub 2019-07-26 16:08:08 +01:00
members Bug 24964: Do not filter patrons after they have been fetched 2020-03-27 08:35:03 +00:00
records Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
virtualshelves Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
article_request Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
authentication Bug 20016: use Modern::Perl in svc scripts 2018-02-05 09:46:45 -03:00
barcode Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
bib Bug 24827: Standardise on 'UTF-8' as the encoding name 2020-03-16 14:45:39 +00:00
bib_framework Bug 16424: (QA follow-up) Use Modern::Perl 2018-09-28 19:01:51 +00:00
bib_profile Bug 20016: use Modern::Perl in svc scripts 2018-02-05 09:46:45 -03:00
checkin Bug 23463: Replace ModItem with Koha::Item->store 2020-03-23 09:26:30 +00:00
checkout_notes Bug 17698: Make patron notes show up on staff dashboard 2018-07-23 15:23:40 +00:00
checkouts Bug 24456: change default sort orders/make wording clearer 2020-03-18 08:44:12 +00:00
convert_report Bug 20495: Remove get_saved_report 2018-07-02 12:06:54 +00:00
cover_images Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
creator_batches Bug 15766: (follow-up) Fixing layout of description button 2018-10-24 13:52:43 +00:00
holds Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
import_bib Bug 24827: Standardise on 'UTF-8' as the encoding name 2020-03-16 14:45:39 +00:00
localization Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
new_bib Bug 24827: Standardise on 'UTF-8' as the encoding name 2020-03-16 14:45:39 +00:00
problem_reports Bug 4461: Fix status and borrowernumber fields in problem_reports and more 2020-04-06 11:18:59 +01:00
renew Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
report Bug 23390: Introduce placeholder syntax for report column names 2019-08-13 11:46:06 +01:00
return_claims Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
split_callnumbers Bug 22388: Add missing +x flag to split_callnumbers 2019-02-21 15:54:20 +00:00