Nick Clemens 0f23622041 Bug 16787: 'Too many holds' message appears inappropriately and is missing data ... This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when allowedreserves=0. This allows passing to the user an appropriate message about the availability of items for holds This patch also fixes a FIXME about using effective_itemtype to fetch item rules To test: 1 - Set one itemtype to allow no holds 2 - Set 'Holds per record' to 0 for another itemtype/patron combination 3 - Create or find 2 records, each with items only of the itemtypes above 3 - Attempt to place a hold for a patron on each record above 4 - The message will be 'Too many holds' 5 - Apply patch and repeat 6 - Message should be "Cannot place hold: no item are available to be placed on hold" 7 - Try placing a multihold with either record above and a holdable record, message should end "Cannot place hold on some items' 8 - prove -v t/db_dependent/Holds.t Rebase - Fix test expectation Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>		2021-04-22 14:37:14 +02:00
..
Acquisition	Bug 27486: Rename system preference delimiter to CSVDelimiter	2021-01-29 09:03:45 +01:00
api/v1	Bug 18729: Add more tests	2021-04-16 16:27:29 +02:00
Auth
AuthoritiesMarc	Bug 21958: (QA follow-up) Correct indirect object notation	2021-04-01 17:13:56 +02:00
Authority
Biblio	Bug 25306: Remove framework paramter from ModBiblioMarc	2021-01-12 16:13:50 +01:00
Circulation	Bug 27069: Adjust tests	2021-04-07 16:08:04 +02:00
CourseReserves
Creators
cronjobs
data	Bug 22824: Adjust tests to match final behaviours	2021-03-04 16:18:42 +01:00
Exporter
Holds	Bug 27069: Adjust tests	2021-04-07 16:08:04 +02:00
Illrequest
Items	Bug 4037: Add item type filter to inventory tool	2021-02-09 09:23:51 +01:00
Koha	Bug 23207: Regression tests	2021-04-22 14:37:14 +02:00
Labels
LDAP
Letters	Bug 26745: (QA follow-up) Add Unit Tests	2020-11-04 17:32:35 +01:00
Members
misc/translator	Bug 25067: Adjust paths in tests	2020-11-06 16:59:40 +01:00
OAI	Bug 27673: Replace YAML with YAML::XS	2021-02-16 14:54:50 +01:00
Patron	Bug 26937: Add an optional delay to the CheckPrevCheckout syspref.	2021-03-01 15:14:22 +01:00
Record
Reports	Bug 27380: FIX Reports/Guided.t	2021-02-12 14:31:01 +01:00
Reserves	Bug 26634: Remove GetHoldRule subroutine in C4::Reserves	2020-12-21 10:07:38 +01:00
Search
selenium	Bug 26703: Fix selenium tests	2021-04-21 15:25:07 +02:00
Serials
SIP	Bug 25690: Add SIP2 tests for checking out with holds	2021-03-04 16:18:42 +01:00
Template/Plugin	Bug 26984: Make tests pass if AnonymousPatron is set	2020-11-20 08:16:02 +01:00
Utils	Bug 23271: Replace search_limited with search_with_library_limits	2021-04-21 15:25:07 +02:00
www	Bug 26031: Remove the failing tests and the diag	2020-11-20 08:16:02 +01:00
00-strict.t
01-test_dbic.t
Accounts.t	Bug 26984: Make tests pass if AnonymousPatron is set	2020-11-20 08:16:02 +01:00
Acquisition.t	Bug 26584: Remove unused C4::Acquisition::CloseBasket function	2020-11-05 15:24:20 +01:00
Amazon.t
ArticleRequests.t
AudioAlerts.t
Auth.t	Bug 21325: Add tests	2021-04-16 14:15:37 +02:00
Auth_with_cas.t	Bug 20854: Add more CAS tests	2021-04-21 10:51:29 +02:00
Auth_with_ldap.t
AuthorisedValues.t	Bug 23830: Make Koha::AuthorisedValues use Koha::Objects::Limit::Library	2021-02-08 17:09:34 +01:00
AuthoritiesMarc.t	Bug 21958: Fix bibliographic record field comparison with authority	2021-04-01 17:13:56 +02:00
AuthUtils.t
BackgroundJob.t
Barcodes.t
Barcodes_ValueBuilder.t
Biblio.t	Bug 21958: Fix bibliographic record field comparison with authority	2021-04-01 17:13:56 +02:00
Breeding.t
Budgets.t	Bug 27673: Replace YAML with YAML::XS	2021-02-16 14:54:50 +01:00
Cache.t	Bug 16067: Remove FastMmap	2020-12-04 15:40:58 +01:00
Calendar.t
Charset.t
check_kohastructure.t
check_sysprefs.t
Circulation.t	Bug 28013: Unit tests	2021-04-07 16:28:07 +02:00
Clubs.t
Context.t
Contract.t
CourseReserves.t
db_structure.t
DecreaseLoanHighHolds.t	Bug 14866: Make high holds work with different item types	2020-11-06 15:55:17 +01:00
Filter_MARC_ViewPolicy.t
Fines.t
FrameworkPlugin.t
Heading.t	Bug 21958: Allow 'e' subfield for authorities	2021-04-06 15:56:30 +02:00
Heading_MARC21.t
Hold.t	Bug 26498: (QA follow-up) Add handling for update	2021-04-07 13:10:31 +02:00
Holds.t	Bug 16787: 'Too many holds' message appears inappropriately and is missing data	2021-04-22 14:37:14 +02:00
HoldsQueue.t	Bug 27069: Adjust tests	2021-04-07 16:08:04 +02:00
Holidays.t
Illcomments.t
Illrequestattributes.t
Illrequests.t	Bug 22818: Fix TestBuilder.t	2020-11-11 18:03:17 +01:00
ILSDI_Services.t	Bug 24446: (QA follow-up) Fix ModItemTransfer tests	2021-03-03 15:36:13 +01:00
ImportBatch.t	Bug 24469: Move the new queries to a dedicated ImportBatch subroutine	2021-02-18 11:52:59 +01:00
ImportExportFramework.t	Bug 27569: Add tests for ODS export	2021-02-16 10:22:13 +01:00
Installer.t
Items.t	Bug 24446: (QA follow-up) Update unit test for ModItemTransfer	2021-03-03 15:36:13 +01:00
Koha.t
Koha_Authority.t
Koha_Database.t
Koha_Elasticsearch.t
Koha_ExternalContent_OverDrive.t
Koha_ExternalContent_RecordedBooks.t
Koha_Misc_Files.t
Languages.t
Letters.t	Bug 28017: (follow-up) Fix Letters.t	2021-04-06 15:53:28 +02:00
LibraryGroups.t
Linker_Default.t
Linker_FirstMatch.t
Log.t
MarcModificationTemplates.t	Bug 26894: Handle subfield 0 and delete empty fields	2021-01-12 16:02:35 +01:00
Members.t	Bug 28001: (bug 27050 follow-up) Fix delete_patrons if no category passed	2021-04-16 12:28:17 +02:00
MungeMarcPrice.t
NewsChannels.t
Overdues.t	Bug 27079: Unit tests	2020-11-27 09:37:10 +01:00
Passwordrecovery.t
Patroncards.t
PatronLists.t
Patrons.t	Bug 27554: Clarify and add tests for update_category_to	2021-02-01 16:21:25 +01:00
Record.t
RecordProcessor_EmbedSeeFromHeadings.t
Reports.t
Reserves.t	Bug 27069: Adjust tests	2021-04-07 16:08:04 +02:00
rollingloans.t
RotatingCollections.t	Bug 26618: (QA follow-up) Fix unit test for TranferCollection change	2021-03-03 15:36:13 +01:00
Search.t	Bug 27928: FindDuplicate should use simple_search_compat	2021-04-01 18:03:23 +02:00
Serials.t	Bug 27673: Replace YAML with YAML::XS	2021-02-16 14:54:50 +01:00
Serials_2.t
Service.t
ShelfBrowser.t
Sitemapper.t
Stats.t
StockRotationItems.t	Bug 22569: Add Unit Tests	2021-03-11 11:51:40 +01:00
StockRotationRotas.t
StockRotationStages.t
SuggestionEngine_ExplodedTerms.t
Suggestions.t
sysprefs.t
TablesSettings.t
Tags.t
Templates.t
TestBuilder.t
Upload.t	Bug 28123: Fix expected value in unit test	2021-04-16 12:28:18 +02:00
UsageStats.t	Bug 20410: Remove OpacGroupResults and PazPar2	2021-02-08 16:12:42 +01:00
Virtualshelves.t
XISBN.t	Bug 26364: Adjust unit tests	2021-01-07 15:37:15 +01:00
XSLT.t	Bug 21260: (follow-up) Consolidate preference	2021-04-14 16:05:53 +02:00
yaml.t	Bug 22824: Adjust tests to match final behaviours	2021-03-04 16:18:42 +01:00
zebra_config.pl