48a2952032
C4::Log::cronlogaction() takes a hashref as argument, with "info"
and possibly "action" as keys. But there are a couple of places
where it is called with just a string as argument, and that does
not work. Both places need lock_exec to fail to trigger the error.
I have seen this on a production server, but not been able to
reproduce in ktd.
To test:
- Run this on the Koha repo: grep -r "cronlogaction(" *
- Verify that fines.pl and process_message_queue.pl are the only
scripts that call cronlogaction without a hashref as argument,
but do it like this: cronlogaction( $message );
- Apply this patch
- Run the grep again and verify that all calls to cronlogaction
now take a hashref as argument
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
|
||
|---|---|---|
| .. | ||
| holds | ||
| recalls | ||
| rss | ||
| social_data | ||
| thirdparty | ||
| advance_notices.pl | ||
| archive_purchase_suggestions.pl | ||
| automatic_checkin.pl | ||
| automatic_item_modification_by_age.pl | ||
| automatic_renewals.pl | ||
| backup.sh | ||
| batch_anonymise.pl | ||
| build_browser_and_cloud.pl | ||
| cart_to_shelf.pl | ||
| check-url-quick.pl | ||
| cleanup_database.pl | ||
| cloud-kw.pl | ||
| cloud-sample.conf | ||
| CONFIGURE.gmail | ||
| create_koc_db.pl | ||
| crontab.example | ||
| delete_items.pl | ||
| delete_patrons.pl | ||
| delete_records_via_leader.pl | ||
| edi_cron.pl | ||
| fines.pl | ||
| gather_print_notices.pl | ||
| import_webservice_batch.pl | ||
| longoverdue.pl | ||
| membership_expiry.pl | ||
| merge_authorities.pl | ||
| notice_unprocessed_suggestions.pl | ||
| overdue_notices.pl | ||
| patron_emailer.pl | ||
| plugins_nightly.pl | ||
| printoverdues.sh | ||
| process_message_queue.pl | ||
| purge_suggestions.pl | ||
| reconcile_balances.pl | ||
| remove_temporary_edifiles.pl | ||
| runreport.pl | ||
| serialsUpdate.pl | ||
| share_usage_with_koha_community.pl | ||
| sitemap.pl | ||
| staticfines.pl | ||
| stockrotation.pl | ||
| update_patrons_category.pl | ||
| update_totalissues.pl | ||
| writeoff_debts.pl | ||