Yohann Dufour 1c2744a83f Bug 12627: SQLHelper replacement - C4::Suggestions ... With this patch, the subroutines NewSuggestion and ModSuggestion use DBIx::Class instead of C4::SQLHelper. Moreover, the tests and the .pl have been adapted. Test plan: 1) Apply the patch. 2) Execute the unit tests by launching : prove t/db_dependent/Suggestions.t 3) The result has to be a success without error or warning : t/db_dependent/Suggestions.t .. ok All tests successful. Files=1, Tests=91, 2 wallclock secs ( 0.05 usr 0.01 sys + 1.65 cusr 0.09 csys = 1.80 CPU) Result: PASS 4) Log in the intranet, create a suggestion and verify the created suggestion. 5) Edit a suggestion from the intranet and verify the suggestion is correctly modified. 6) Log in the OPAC and verify you can add a suggestion. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Test pass, suggestion created on staff and opac, suggestion edited without problems, no koha-qa errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script: Also tested: - adding suggestion from staff and OPAC - edit suggestion from staff - deleting suggestion from OPAC - changing to a normal status (email got created) - changing to a custom status (SUGGEST_STATUS) - display of custom status in OPAC No problems found. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>		2014-11-07 15:17:00 -03:00
..
Acquisition	Bug 12830: Move the order-related code into Koha::Acquisition::Order	2014-10-28 11:10:36 -03:00
Circulation	Bug 12470: (followup) License statement missing	2014-07-14 08:57:06 -03:00
data	Bug 12419: (QA followup) regression tests	2014-06-30 15:57:23 -03:00
Holds	Bug 11126: (RM followup) remove diags from tests	2014-11-04 18:59:42 -03:00
Koha	Bug 11425: Add unit tests	2014-11-04 19:10:28 -03:00
Labels	Bug 8375: (follow-up) adjust another test case for change in fonts	2014-05-06 21:24:40 +00:00
LDAP
Members	Bug 12457: Allow UT on a non empty database	2014-07-30 09:50:35 -03:00
Record
Reports	Bug 8594 - prevent the report system from breaking some subqueries	2012-09-05 10:12:06 +02:00
Search	Bug 10807: Add an authority search history for the OPAC	2014-05-05 02:32:27 +00:00
Serials	Bug 5342: (qa-followup) FIX some issues	2014-10-28 10:07:44 -03:00
Utils	Bug 12833: Patron search should search on extended attributes	2014-09-09 10:08:59 -03:00
www	Bug 8300: Add mechanized unit test for batch import	2013-05-01 07:57:11 -04:00
XSLT_Handler	Bug 6536: QA Follow-up: Add some unit tests for Z3950Search in Breeding.pm	2014-09-01 10:09:17 -03:00
00-strict.t	Bug 7844: (follow-up) don't test koha.psgi for ability to compile (yet)	2014-04-29 19:34:23 +00:00
Accounts.t
Acquisition.t	Bug 7162: (RM followup) fix the number of tests	2014-10-30 00:47:13 -03:00
Amazon.t
Auth.t	Bug 11349: Change .tmpl -> .tt in scripts using templates	2014-07-17 11:05:49 -03:00
Auth_with_cas.t	Bug 12398: (followup) tidy unit tests	2014-08-01 10:13:45 -03:00
Auth_with_ldap.t	Bug 8148: (regression tests) C4::Auth_with_ldap needs unit tests	2014-08-07 16:23:02 -03:00
AuthoritiesMarc.t	Bug 7442: (follow-up) adjust UNIMARC test case to match change in BuildSummary()	2014-05-05 04:18:22 +00:00
BackgroundJob.t	Bug 10601: (follow-up) unit tests for new ->set() and ->get()	2013-09-18 17:21:47 +00:00
Barcodes.t	Bug 6448 [2/3] Barcodes::EAN13 autoBarcode	2012-08-02 18:41:44 +02:00
Biblio.t	Bug 12674: (regression tests) GetMarcISSN should not return empty ISSN	2014-09-01 10:42:08 -03:00
Bookseller.t	Bug 12830: Move the order-related code into Koha::Acquisition::Order	2014-10-28 11:10:36 -03:00
Borrower_Debarments.t	Bug 12416: add new tests of DelUniqueDebarment	2014-06-22 19:59:04 -03:00
Borrower_Files.t	Bug 12417: adding the units tests of the module Koha::Borrower::Files.pm	2014-07-11 16:16:11 -03:00
Branch.t	Bug 9530: Follow-up - Fix t/db_dependent/Branch.t	2014-10-28 09:26:03 -03:00
Breeding.t	Bug 12898: (regression test) test terms inside double quotes	2014-09-14 02:02:51 -03:00
Budgets.t	Bug 12958: Set a fund owner to a fund hierarchy	2014-10-31 16:18:49 -03:00
Category.t	Bug 11543: (followup) add one more test	2014-01-15 19:58:30 +00:00
check_sysprefs.t	Bug 8353 follow-up: Perltidy new test	2012-07-13 14:42:52 +02:00
Circulation.t	Bug 10860 [QA Followup] - Fix misc issues	2014-11-03 10:26:25 -03:00
Circulation_Branch.t	Bug 10683: (follow-up) improvements to the unit tests	2013-10-09 03:51:55 +00:00
Circulation_issue.t	Bug 11629: (folllow-up) fix various issues	2014-05-26 03:25:22 +00:00
Circulation_Issuingrule.t	Bug 11577 : Fixing a tiny copy/paste issue	2014-09-17 19:23:37 -03:00
Circulation_issuingrules.t	Bug 11934: (follow-up) tidy up whitespace	2014-03-13 15:18:49 +00:00
Circulation_OfflineOperation.t	Bug 10710: (follow-up) perltidy new code	2013-08-28 14:52:43 +00:00
Circulation_transfers.t	Bug 11470: fix occassional spurious test failure in Circulation_transfers.t	2014-01-06 05:31:21 +00:00
ClassSource.t	Bug 10644: (follow-up) remove inadvertant dependence on Perl 5.14	2013-08-09 18:53:20 +00:00
ColumnsSettings.t	Bug 10212: Columns configuration for tables - Unit tests	2014-08-26 09:28:18 -03:00
Context.t	Bug 12808: remove useless diags from t/db_dependent/Context.t	2014-08-26 10:30:53 -03:00
Contract.t	Bug 12487: SQLHelper replacement - C4::Contract	2014-07-30 10:44:11 -03:00
CourseReserves.t	Bug 10332: further improvements to course reserves tests	2013-06-18 16:40:43 -07:00
Csv.t	Bug 10853: (follow-up) expand unit tests for C4::Csv	2013-10-11 03:25:42 +00:00
default_search_class.pl	Bug 12738: (regression tests) C4::Context should set keyword search as default for QueryParser	2014-08-11 10:05:59 -03:00
External_BakerTaylor.t
Heading_MARC21.t	Merge remote-tracking branch 'origin/new/bug_7284'	2012-04-04 18:18:26 +02:00
Holds.t	Bug 12879: Remove unnecesary diags from Holds.t	2014-09-16 15:21:40 -03:00
HoldsQueue.t	Bug 11258: fix another case where holds queue made transfer requests that contradict the library holds policy	2014-04-18 15:23:23 +00:00
Holidays.t	Bug 13115 - Holidays.t will fail some unit tests on Sundays	2014-10-21 21:11:28 -03:00
ILSDI_Services.t	Bug 11891: set up tests to require that Koha::Database uses same DB handle as C4::Context	2014-06-19 11:54:45 -03:00
ImportBatch.t	Bug 11876 [Unit test] Add a diff view to staged MARC Records	2014-10-31 14:25:18 -03:00
Installer.t	Bug 11541: (follow-up) move Installer.t to t/db_dependent	2014-01-14 21:43:56 +00:00
Items.t	Bug 11425: (maniac followup) remove diag from tests	2014-11-04 19:22:07 -03:00
Items_DelItem.t	Bug 12583: (followup) rename new test file	2014-07-26 10:17:09 -03:00
KitchenSinkPlugin.kpz	Bug 7804 - Add Koha Plugin System - QA Followup 3 - Additional Unit Tests	2013-03-20 14:50:38 -04:00
Koha.t	Bug 12675: Add unit test to GetFrameworksLoop	2014-08-03 17:02:32 -03:00
Koha_Authority.t	Bug 5202: merge authorities from the authority file and reservoir	2013-10-10 21:32:27 +00:00
Koha_borrower_modifications.t	Bug 12623: SQLHelper replacement - Borrower::Modifications	2014-08-11 11:42:58 -03:00
Koha_Database.t	Bug 11906: regression test for using DBIC to store & fetch UTF8 strings	2014-03-27 14:44:39 +00:00
Koha_Misc_Files.t	Bug 3050: QA follow-up	2014-05-25 21:15:03 +00:00
Koha_template_plugin_Branches.t	Bug 11779: (follow-up) improve GetLoggedInBranchcode() and add test cases	2014-02-19 16:40:06 +00:00
Koha_template_plugin_KohaDates.t
Languages.t	Bug 7841: add a direct regression test	2014-05-19 16:40:23 +00:00
Letters.t	Bug 12830: Move the order-related code into Koha::Acquisition::Order	2014-10-28 11:10:36 -03:00
Linker_FirstMatch.t	Bug 7724: Skip Linker test if Zebra isn't set up	2012-03-20 11:21:10 +01:00
Log.t
MarcModificationTemplates.t	Bug 8015: Add unit tests for SimpleMARC and MarcModificationTemplates routines	2013-10-31 22:50:11 +00:00
Members.t	Bug 13084 [Master] - Improve t/db_dependent/Members.t test coverage	2014-10-23 10:40:43 -03:00
Members_Attributes.t	Bug 12427: Allow execution of UTs on a DB with issues	2014-06-24 09:43:04 -03:00
Members_columns.t	Bug 7785: (follow-up) standardize POD	2013-08-13 16:15:30 +00:00
MungeMarcPrice.t	Bug 9593: (follow-up) don't make currency.isocode required	2014-05-04 22:21:17 +00:00
NewsChannels.t	Bug 7567: (follow-up) make tests of get_opac_new more readable	2014-04-07 18:14:20 +00:00
Overdues.t	Bug 9180: All branches should be returned if a default rule exists	2014-08-19 09:29:51 -03:00
PatronLists.t	Bug 10565: (follow-up) don't assume borrowernumber 1 exists in unit test	2013-10-14 21:30:34 +00:00
Plugins.t	Bug 9909: Don't install KitchenSink plugin if plugin dir isn't writable	2013-03-22 21:52:41 -04:00
QueryParser.t	Bug 12738: (regression tests) C4::Context should set keyword search as default for QueryParser	2014-08-11 10:05:59 -03:00
Ratings.t	Bug 12609: Add some unit tests for C4::Ratings	2014-09-17 22:08:57 -03:00
Record.t	Bug 11826: Use XSLT handler object in showmarc, Record.pm	2014-05-26 03:52:45 +00:00
RecordProcessor_EmbedSeeFromHeadings.t	Bug 7417: Include see from references in bibliographic searches	2012-09-13 14:19:28 +02:00
Reports.t
Reports_Guided.t	Bug 11672: (followup) warnings tested	2014-09-23 15:32:28 -03:00
ReportsGuided.t	Bug 13141: (QA Followup) Update number of unit tests	2014-10-31 13:15:06 -03:00
Reserves.t	Bug 12876: (followup) remove useless diags	2014-09-23 21:26:35 -03:00
rollingloans.t	Bug 5549 : Fixing the test to only run if the test data exists	2012-03-27 09:18:37 +02:00
RotatingCollections.t	Bug 8836: (RM followup) unit tests should use the new API	2014-11-07 11:09:14 -03:00
Search.t	Bug 13088: (RM followup) add missing pref mock	2014-10-28 12:07:46 -03:00
Search_SearchHistory.t	Bug 10807: (follow-up) remove comment about routine that is no longer present	2014-05-05 02:58:29 +00:00
Serials.t	Bug 12482: removing the use of the module C4::SQLHelper.pm, it is replaced by DBIx::Class	2014-07-03 14:24:58 -03:00
Serials_2.t	Bug 5342: Serial claiming improvements: add a counter	2014-10-28 10:07:37 -03:00
Service.t
ShelfBrowser.t	Bug 10856: Improve the previous and next items on the shelf browser	2013-10-04 15:56:35 +00:00
SIP_ILS.t
SQLHelper.t	Bug 11425: (followup) fix number of tests	2014-11-04 19:20:34 -03:00
Stats.t	Bug 11230 - Refactor C4::Stats::UpdateStats and add UT	2014-07-27 11:29:28 -03:00
SuggestionEngine_ExplodedTerms.t	Bug 12653: remaining prog reference in t/db_dependent/SuggestionEngine_ExplodedTerms.t	2014-10-29 23:37:54 -03:00
Suggestions.t	Bug 12627: SQLHelper replacement - C4::Suggestions	2014-11-07 15:17:00 -03:00
sysprefs.t	Bug 10325: (follow-up) add test for overriding system preferences	2013-09-08 02:28:45 +00:00
Tags.t	Bug 12916 - Missing Test to demonstrate warnings.	2014-10-30 00:31:26 -03:00
Templates.t	Bug 12918: fix failing test case	2014-09-15 10:53:00 -03:00
UploadedFile.t
VirtualShelves.t	Bug 9032: (follow-up) restore documented intepretation of virtualshelfshares.sharedate	2014-04-20 22:52:21 +00:00
VirtualShelves_Page.t
XISBN.t	Bug 12782: (followup) skip tests that fail because of provider's error	2014-08-20 12:29:27 -03:00
XSLT_Handler.t	Bug 11826: Add unit tests for Koha::XSLT_Handler	2014-05-26 03:52:45 +00:00
zebra_config.pl	Bug 12651: DOM indexing is the default	2014-10-27 12:35:44 -03:00