Tomas Cohen Arazi 1f55d38918 Bug 28529: Make biblio-level hold itemtype count against max rules ... The current situation is that biblio-level holds can be assigned an item type, so they can only be fulfilled by items matching that specified item type (be it item-level itype or the fallback to biblio-level). But there's the situation in which max holds limits for a specific item type can be overridden by using biblio-level holds with item type selection (AllowHoldItemTypeSelection) enabled. To test: 1. Have a patron of category 'Staff' (S) 2. Have 3 records with items with the 'BK' item type, and maybe others 3. Enable AllowHoldItemTypeSelection 4. Set a limit of 2 max holds for that category+item type 5. In the OPAC. Place bibio-level holds, with item type contraint to 'BK' on those 3 records => FAIL: You can place the 3 holds 6. Cancel the holds 7. Apply this patch and restart all 8. Repeat 5 => SUCCESS: You can only place 2 holds 9. Run: $ kshell t/db_dependent/Reserves.t => SUCCESS: Tests pass! 10. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> (cherry picked from commit 81bdce5c43) Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>		2022-06-10 15:22:56 +00:00
..
clubs	Bug 29844: Fix ->search occurrences	2022-02-09 15:36:23 -10:00
errors	Bug 29420: HTTP status code incorrect when calling error pages directly under Plack/PSGI	2022-04-20 09:03:39 -10:00
external/overdrive
sci
sco	Bug 26019: Koha should set SameSite attribute on cookies	2022-04-13 15:55:38 +02:00
svc	Bug 30426: Add missing C4::Auth and C4::Output imports	2022-04-13 15:55:38 +02:00
ilsdi.pl	Bug 22347: Translatability of ILSDI GetAvailability	2022-04-12 17:13:02 +02:00
maintenance.pl	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
oai.pl	Bug 14939: Modularize OAI Server existing classes	2015-12-31 15:15:05 +00:00
opac-account-pay-return.pl	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
opac-account-pay.pl
opac-account.pl	Bug 29844: Fix ->search occurrences	2022-02-09 15:36:23 -10:00
opac-addbybiblionumber.pl	Bug 26346: Add option to make public lists editable by all staff	2022-04-12 17:13:02 +02:00
opac-alert-subscribe.pl
opac-article-request-cancel.pl
opac-authorities-home.pl
opac-authoritiesdetail.pl	Bug 29435: include missing subroutine from C4::AuthoritiesMarc	2021-11-15 12:38:39 +01:00
opac-basket.pl	Bug 29609: Centralized code to build the link to a biblio detail page	2022-04-08 15:49:16 +02:00
opac-blocked.pl	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
opac-browse.pl	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
opac-browser.pl
opac-changelanguage.pl
opac-course-details.pl	Bug 19532: (RM follow-up) More use of system preference	2022-03-14 23:11:12 -10:00
opac-course-reserves.pl
opac-detail.pl	Bug 30291: Changes to OPAC files	2022-05-05 11:17:36 -10:00
opac-discharge.pl
opac-downloadcart.pl	Bug 29859: Use iterator instead of as_list	2022-02-09 15:36:23 -10:00
opac-downloadshelf.pl	Bug 29859: Use iterator instead of as_list	2022-02-09 15:36:23 -10:00
opac-export.pl
opac-holdshistory.pl
opac-ics.pl	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
opac-idref.pl	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
opac-illrequests.pl
opac-image.pl	Bug 28606: Remove $DEBUG and $ENV{DEBUG}	2021-06-24 11:53:44 +02:00
opac-imageviewer.pl
opac-ISBDdetail.pl
opac-issue-note.pl	Bug 29544: (QA follow-up) Simplify code	2022-02-02 21:05:29 -10:00
opac-library.pl
opac-main.pl	Bug 28955: Impact News as well	2022-02-24 14:35:36 -10:00
opac-MARCdetail.pl
opac-memberentry.pl	Bug 30237: Replace AutoEmailOpacUser with AutoEmailNewUser	2022-04-20 09:03:39 -10:00
opac-messaging.pl	Bug 30532: (bug 29957 follow-up) Fix '$cookie->value'	2022-04-21 13:41:36 -10:00
opac-modrequest-suspend.pl
opac-modrequest.pl
opac-mymessages.pl
opac-news-rss.pl
opac-overdrive-search.pl	Bug 29318: Tidy the code	2021-10-26 16:46:03 +02:00
opac-passwd.pl
opac-password-recovery.pl	Bug 29646: (RM follow-up) Add space before colon	2022-01-21 21:34:51 -10:00
opac-patron-consent.pl
opac-patron-image.pl	Bug 29931: (follow-up) Similar thing in opac-patron-image.pl	2022-03-15 22:30:50 -10:00
opac-privacy.pl	Bug 29843: Use in opac/opac-privacy.pl	2022-02-10 14:44:23 -10:00
opac-ratings-ajax.pl	Bug 28785: Adjust check_cookie_auth calls	2021-10-18 11:28:41 +02:00
opac-ratings.pl
opac-readingrecord.pl	Bug 28768: (QA follow-up) Remove unused variable	2021-11-05 12:17:08 +01:00
opac-recall.pl	Bug 30291: Changes to OPAC files	2022-05-05 11:17:36 -10:00
opac-recalls.pl	Bug 30291: Changes to OPAC files	2022-05-05 11:17:36 -10:00
opac-recordedbooks-search.pl	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
opac-registration-verify.pl	Bug 30237: Replace AutoEmailOpacUser with AutoEmailNewUser	2022-04-20 09:03:39 -10:00
opac-renew.pl
opac-reportproblem.pl	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
opac-request-article.pl	Bug 27946: Add UI handling of AR fees	2022-01-28 11:09:07 -10:00
opac-reserve.pl	Bug 28529: Make biblio-level hold itemtype count against max rules	2022-06-10 15:22:56 +00:00
opac-reset-password.pl	Bug 29925: Add a password reset page for expired passwords	2022-05-06 10:33:09 -10:00
opac-restrictedpage.pl	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
opac-retrieve-file.pl
opac-review.pl
opac-routing-lists.pl	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
opac-search-history.pl	Bug 30377: Fix two CGI::param called in list context-warnings	2022-04-04 16:23:46 +02:00
opac-search.pl	Bug 17018: Split AdvancedSearchTypes for staff and OPAC	2022-04-12 17:13:02 +02:00
opac-sendbasket.pl	Bug 30532: (bug 29957 follow-up) Fix '$cookie->value'	2022-04-21 13:41:36 -10:00
opac-sendshelf.pl
opac-serial-issues.pl	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
opac-shareshelf.pl
opac-shelves.pl	Bug 26346: Add option to make public lists editable by all staff	2022-04-12 17:13:02 +02:00
opac-showmarc.pl
opac-showreviews.pl	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
opac-suggestions.pl
opac-tags.pl	Bug 29669: fix uninitialized value warnings when XSLTParse4Display is called	2021-12-16 12:13:51 -10:00
opac-tags_subject.pl
opac-topissues.pl	Bug 17018: Split AdvancedSearchTypes for staff and OPAC	2022-04-12 17:13:02 +02:00
opac-user.pl	Bug 30291: Changes to OPAC files	2022-05-05 11:17:36 -10:00
tracklinks.pl
unapi	Bug 17600: Fix opac/unapi	2021-11-22 11:04:51 +01:00