Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/C4
History
Colin Campbell 1f56a04cad Bug 4450 Use more consistent error returns in C4/Creators/* 
A lot of routines were defaulting to return -1 in error conditions
but calling code was expecting a ref or object
use return with explicit undef (or emptyness in array context)
for these cases. Extended this to cases where return was not tested
( -1 might in some cases be legit data).

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit 5cf2b78b6f)
[RM note: ... thereby undoing the revert]
2010-05-07 13:04:58 -04:00
..
AuthoritiesMarc Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
Barcodes Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
Cache Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
ClassSortRoutine Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Creators Bug 4450 Use more consistent error returns in C4/Creators/* 2010-05-07 13:04:58 -04:00
External Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Form Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
Heading Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
ILSDI Bug 3785 - Fixing a bug that was stopping holds if no maximum number was set 2010-04-30 08:19:37 -04:00
Labels Allow UNIMARC item callnumber splitting 2010-04-16 01:00:19 -04:00
Members Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
Output Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Patroncards Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Reports Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
Search Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
Serials Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
SIP Convert to UTF-8. 2010-05-06 17:58:39 -04:00
tests Bug 2505 - Add commented use warnings where missing in the C4/ directory 2010-04-21 20:25:32 +12:00
VirtualShelves Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Accounts.pm Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
Acquisition.pm (BUG #4332) Changed the display of ordered search results 2010-04-29 21:20:10 -04:00
Auth.pm fixed Syndetics breakage 2010-05-05 12:11:30 -04:00
Auth_with_cas.pm MT3186: Remove warnings from Auth_with_cas 2010-04-23 06:55:13 -04:00
Auth_with_ldap.pm bug 4256: fix patron replication when using LDAP with auth_by_bind 2010-04-30 17:05:38 -04:00
AuthoritiesMarc.pm Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
BackgroundJob.pm Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
Barcodes.pm Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Biblio.pm MT 2269 : Do not display all the items if there is a large amount of items 2010-04-29 21:52:15 -04:00
Bookseller.pm Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
Boolean.pm Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Branch.pm Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
Breeding.pm Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Budgets.pm Merge branch 'bug2505_patches' of git://git.catalyst.net.nz/koha into to-push 2010-04-23 07:13:37 -04:00
Cache.pm Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Calendar.pm Bug 3268: Adds the ability to edit the description of a holiday. 2009-06-03 13:26:40 -05:00
Category.pm remove editor settings 2009-02-04 14:47:42 -06:00
Charset.pm (MT #2962) add converted chars from ISO5426 2010-03-16 21:30:43 -04:00
Circulation.pm on checkout ask for confirmation if borrower from different branch 2010-05-03 09:17:19 -04:00
ClassSortRoutine.pm Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
ClassSource.pm Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Context.pm Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Contract.pm Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
Creators.pm Bringing label, patroncard, and creator modules into conformity with the rest of C4 style. 2010-02-08 20:54:34 -05:00
Csv.pm Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
Dates.pm Dates : improvements string recognition 2010-01-28 15:11:47 +01:00
Debug.pm Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Heading.pm Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
ImportBatch.pm Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Input.pm Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Installer.pm Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
ItemCirculationAlertPreference.pm remove editor settings 2009-02-04 14:47:42 -06:00
Items.pm bug 4396: clarify return of itemtype-level notforloan flag 2010-05-03 07:45:19 -04:00
ItemType.pm remove editor settings 2009-02-04 14:47:42 -06:00
Koha.pm Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
Labels.pm Bringing label, patroncard, and creator modules into conformity with the rest of C4 style. 2010-02-08 20:54:34 -05:00
Languages.pm Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
Letters.pm Bug 3619 - C4::Letters::_send_message_by_email does not obey AutoEmailPrimaryAddress 2010-04-29 23:10:15 -04:00
Log.pm Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Maintainance.pm Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
Matcher.pm Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Members.pm bug 4036, 4405: overdue and fine day block improvements 2010-05-03 07:46:26 -04:00
Message.pm remove editor settings 2009-02-04 14:47:42 -06:00
NewsChannels.pm Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Output.pm Merge branch 'bug2505_patches' of git://git.catalyst.net.nz/koha into to-push 2010-04-23 07:13:37 -04:00
Overdues.pm Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
Patroncards.pm Bringing label, patroncard, and creator modules into conformity with the rest of C4 style. 2010-02-08 20:54:34 -05:00
Print.pm Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
Record.pm Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
Reports.pm Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
Reserves.pm (bug #4319) allow reserves on waiting items 2010-05-01 10:27:27 -04:00
Review.pm Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Ris.pm Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
RotatingCollections.pm Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
Scheduler.pm Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
Scrubber.pm Unescape Comment, now that we trust Scrubber to block bad markup. 2008-05-29 06:30:51 -05:00
Search.pm MT3228 : trailing space block search 2010-05-01 09:50:34 -04:00
Serials.pm Bug 3883: Fixes blank line in routing list. 2010-05-03 07:35:38 -04:00
Service.pm Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
SMS.pm Bug 2400 [5/18]: fixing pod syntax in C4/SMS.pm 2008-08-12 19:40:03 -05:00
SQLHelper.pm Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Stats.pm Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Suggestions.pm Bug 4210 Acq suggestions don't have LibraryName value passed 2010-04-29 22:14:10 -04:00
Tags.pm bugfix for ??? 2009-09-30 11:30:14 +02:00
UploadedFile.pm Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
Utils.pm Big LDAP changes, module test for Context.pm, still more yet to come. 2007-12-04 17:27:06 -06:00
VirtualShelves.pm Fix to ORDER BY SQL in lists feature 2010-04-29 23:07:40 -04:00
XISBN.pm Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
XSLT.pm Fixes bug 4448: &'s in itemcallnumber 2010-05-05 11:35:34 -04:00
Z3950.pm Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00