Main Koha release repository https://koha-community.org
Find a file
Paul Poulain 1fe3514c3c Bug 6328 fine in days does not work
Some code coming from BibLibre has been lost in the process of inclusion in
3.4. The result is that fine in days does not work at all (you can setup rules,
but it does nothing)

Step to reproduce:

- Koha > Admin > circ rules > set 1 day fine every day of overdue for default
  rule
- Issue a book return date last week
- check-in the book => no debarment is set

The following patch will fix all of those problems by :

* updating borrowers.debarred to a date field (instead of tinyint). It contains
  the limit of the debarment
* changing API of DebarMember and UpdateBorrowerDebarred to pass a date
* display debarrdate where applicable. Note that a debarrdate of 31/12/9999 is
  considered as unlimited and not displayed
* added a debarrcomment, usefull to explain why a patron is debarred (this is
  independant from debarrdate changes and can be used when placing an unlimited
  debarment too)

[2011-05-12] F. Demians. It works as described. And I can confirm this
functionality is impatiently awaited by French libraries since one year. Thanks
BibLibre for the good work and for contributing this code.

Bug 6328 Followup--update DB structure

Thanks Katrin.

Bug 6328: make comment a textbox / fix debar by notice trigger

Debarring by notice triggers was broken, because the new function
expects a date as second parameter.

The comment field in patron account details was a very long text field.
Patch changes it to be a textbox instead.

Bug 6328: Lift debarment leaves patron account

'Lift debarment' redirects to an empty circulation page.

BZ6328 follow-up 3

Fixes comment 23 from Fernando L. Canizo : when the patron was debarred and debar removed
he still could not check-out.

The changes in the IsMemberBlocked (that were on biblibre/master) were lost somewhere
The sub was still checking for old_issues instead of calling CheckBorrowerDebarred
to get a debardate if applicable

Note : this bug was appearing only is you had issuing rules defined for itemtype/categorycode/branch.
Seemed to work if you had only default rules. That's probably why it hadn't been spotted before

BZ6328 follow-up 4
Comments fron Zeno Tajoli: The patch is OK and I sign-off it. Two little changes done on
installer/data/mysql/kohastructure.sql and installer/data/mysql/updatedatabase.pl

Signed-off-by: koha <koha@kohabase.localdomain>
2011-11-25 14:00:47 +01:00
acqui Bug 3388: Restore account number on vendor page 2011-11-25 11:07:11 +01:00
admin Bug 6475 - Edit it's not possible in subfield "0" in MARC framework 2011-11-18 22:32:35 +01:00
authorities Bug 6977 : Adds support for repeatable subfields when importing authorities. 2011-10-13 11:07:17 +13:00
basket Bug 6050 Make calls to GetItemsInfo consistent 2011-06-14 14:12:02 +12:00
C4 Bug 6328 fine in days does not work 2011-11-25 14:00:47 +01:00
catalogue Bug 6916 - item's acq date now takes you to its invoice 2011-11-17 17:05:17 +01:00
cataloguing Bug 6679 : Tidying changed parts of file 2011-11-06 18:19:19 +01:00
circ Bug 6328 fine in days does not work 2011-11-25 14:00:47 +01:00
debian Bug 7091 - [MASTER/3.6.x/3.4.x] - update the changelogs for the 3.4 series 2011-11-24 11:47:45 +01:00
docs Joy nelson was already in history.txt, removing the entry 2011-11-18 23:28:38 +01:00
errors Housekeeping in errors scripts 2010-05-12 07:29:03 -04:00
etc Bug 2629: Add diacritic support for Ů (U with ring) 2011-11-16 17:40:16 +01:00
install_misc Bug 7063: add available perl packages for Debian in install_misc/debian.packages 2011-10-22 09:00:33 +13:00
installer Bug 6328 fine in days does not work 2011-11-25 14:00:47 +01:00
koha-tmpl Bug 6328 fine in days does not work 2011-11-25 14:00:47 +01:00
labels Bug 7207 - Reverting a portion of commit 607b5449bd which breaks the label export script. 2011-11-16 17:55:35 +01:00
members Bug 6328 fine in days does not work 2011-11-25 14:00:47 +01:00
misc Bug 6328 fine in days does not work 2011-11-25 14:00:47 +01:00
offline_circ Bug 5449: JSON malformed in Koha - Blocker with jQuery 1.4.x 2011-03-12 08:53:41 +13:00
opac Bug 6328 fine in days does not work 2011-11-25 14:00:47 +01:00
patroncards bug_6253: Unified member Search() 2011-10-19 16:23:02 +13:00
reports Fix for Bug 6602 - Reports dictionary doesn't properly recognize text columns 2011-08-25 11:49:04 +12:00
reserve Bug 7059: Remove GetMemberDetails from reserve/request.pl 2011-10-20 14:07:51 +13:00
reviews Modifying Members : Add Mod and GetMember 2009-09-30 11:29:23 +02:00
rotating_collections Bug 6553 : Follow up adding license statements 2011-08-13 19:54:38 +12:00
selenium Adding selenium tests for filterMembers 2009-09-30 11:30:37 +02:00
serials Bug 6479 Converts all the serialseq variables to UTF-8. 2011-09-03 06:31:03 +12:00
skel installer: fixed chown invocation; added skel for KOHA_LOG_DIR 2007-12-17 09:13:53 -06:00
sms Bug 2505 - Add commented use warnings where missing in the sms/ directory 2010-04-21 20:25:08 +12:00
suggestion Bug 7117: Bug 7117 - Small display problems when organising suggestion tabs by name 2011-11-05 05:58:54 +01:00
svc bug 4896: granular permissions now always on (DB rev 138) 2010-06-19 07:56:03 -04:00
t Bug 7095: Fixing cut and paste error and removing the use of diag() as this does not produce output when the test is run in a harness 2011-11-18 22:51:28 +01:00
tags Fix for Bug 2377 - Review tags: format date according to system preference 2010-10-06 09:31:56 -04:00
test Bug 5449: JSON malformed in Koha - Blocker with jQuery 1.4.x 2011-03-12 08:53:41 +13:00
tmp/modified_authorities changing DO_NOT_REMOVE to README.txt 2007-10-21 19:14:41 -05:00
tools Bug 6303: Display Organisation and Parent Organisation names when viewing a borrower of type organisation 2011-11-24 11:30:08 +01:00
virtualshelves Fix for Bug 6957, authors disappearing when emailing lists 2011-10-20 11:34:39 +13:00
xt Bug 6537 - squashed version of the previous 5 commits, signed-off 2011-09-07 09:19:07 +12:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
about.pl Bug 4330: Wrong address for Free Software Foundation 2011-11-24 14:15:55 +01:00
changelanguage.pl Bug 6755 Problems with switching languages 2011-09-23 09:47:09 +12:00
edithelp.pl Bug 7038 Contextual help is always in English 2011-10-18 16:01:25 +13:00
fix-perl-path.PL installer: improvements to fix-path-perl.PL on Win32 2007-12-20 19:20:12 -06:00
help.pl Bug 7038 Contextual help is always in English 2011-10-18 16:01:25 +13:00
INSTALL Updating main INSTALL instructions 2011-10-22 09:04:19 +13:00
install-CPAN.pl Bug 5370: Fix all the references to koha.org 2010-11-08 09:41:49 +13:00
INSTALL.debian Updating distro specific install files 2011-10-22 09:12:15 +13:00
INSTALL.fedora7 fixing various links to point to *.koha-community.org 2010-10-21 22:08:24 -04:00
INSTALL.opensuse Updating INSTALL.opensuse file with the changes by Freek de Kruijf 2011-06-09 09:45:22 +12:00
INSTALL.ubuntu Updating distro specific install files 2011-10-22 09:12:15 +13:00
INSTALL.ubuntu.lucid Updating distro specific install files 2011-10-22 09:12:15 +13:00
koha_perl_deps.pl Bug 6915 - [SIGNED-OFF] reduce module name truncation problem in koha_perl_deps.pl 2011-10-15 14:00:24 +13:00
kohaversion.pl Updating version number for release 2011-10-22 10:26:13 +13:00
LICENSE Update LICENSE with a fresh copy from upstream. This updates the FSF address, and refers to the LGPL with its current name, and changes a few other minor things of the typographical sort. No semantic changes. 2010-03-16 20:17:48 -04:00
mainpage.pl Bug 4330: Wrong address for Free Software Foundation 2011-11-24 14:15:55 +01:00
Makefile.PL Updating perl version required to match reality 2011-10-19 02:57:18 +13:00
MANIFEST.SKIP Bug Fixing : 3334 2009-06-19 06:33:34 -05:00
README updated links in README 2010-05-24 08:14:16 -04:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
rewrite-config.PL Bug 5370: Fix all the references to koha.org 2010-11-08 09:41:49 +13:00

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 2 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/