Main Koha release repository
https://koha-community.org
28ef6c199b
A suggestion added through addorder.pl now changes to the ORDERED status as initially intended (but so far it stayed as ACCEPTED). This fixes the list of potential suggestions to order, the ORDERED ones don't appear anymore. Bug 6893 : Follow-up: Disabled WHERE clause excluding ORDERED status In SearchSuggestions, a WHERE clause was excluding the ORDERED suggestions from the results. Now replaced with 1=1. (before 6893 correction, the WHERE clause was excluding the STATUS='CLAIMED' suggestions, but this status cannot be found anywhere else in the code... so I changed to STATUS='ORDERED' which seemed more accurate, but it had impacts on OPAC and some Admin tabs) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Both patches applied cleanly, sqashed them together after testing. Tested: 1) Creating new suggestions - from OPAC, shows up in patron account as 'requested', pending in staff - from staff, shows up in list of pending suggestions Status in database is ASKED Note: suggestions made from staff for the same patron have suggestedby = 0 in the database, so are not showing up in the patron account. Is this by intention? (if not, I think this is a separate bug) 2) Accepting suggestions - from list - from edit page Status in database is ACCEPTED Patron account shows 'Accepted by the library (Bestseller)' Note: after changing the status from the list, bug 4068 kicks in and some tabs and even suggestions are hidden. Going back to the acq start page and going back to the suggestions page from there helps. 3) Rejecting suggestions - from list - from edit page Status in database is REJECTED Patron account in OPAC shows 'Suggestion declined' Note: bug 4068 again. 4) Ordering from suggestions - new basket - ordered 2 accepted suggestions SUCCESS! Great improvement: - Status in database is now ORDERED - Already ordered suggestions no longer show up on list of suggestions to order from. - Patron account shows 'Ordered by the library (Bestseller)' - Suggestion management page shows a new tab 'Ordered' - For the suggestion with a valid 'suggestedby' borrowernumber, a mail was generated. (bug 7094) 5) Receive ordered suggestions - received my ordered suggestions This is is not in the scope of this bug, but for documentation: - No message was generated to inform the patron - Status stays ORDERED - Patron account still shows item as ordered, no change to 4) Looking at the suggestion.tt I think there should be another status AVAILABLE. 216 [% ELSIF (suggestion.suggestiontypelabel == "Available") %]Available Signing off, fixes bug reported. Danke! Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> |
||
|---|---|---|
| acqui | ||
| admin | ||
| authorities | ||
| basket | ||
| C4 | ||
| catalogue | ||
| cataloguing | ||
| circ | ||
| debian | ||
| docs | ||
| errors | ||
| etc | ||
| install_misc | ||
| installer | ||
| koha-tmpl | ||
| labels | ||
| members | ||
| misc | ||
| offline_circ | ||
| opac | ||
| patroncards | ||
| reports | ||
| reserve | ||
| reviews | ||
| rotating_collections | ||
| selenium | ||
| serials | ||
| skel | ||
| sms | ||
| suggestion | ||
| svc | ||
| t | ||
| tags | ||
| test | ||
| tmp/modified_authorities | ||
| tools | ||
| virtualshelves | ||
| xt | ||
| .htaccess | ||
| about.pl | ||
| changelanguage.pl | ||
| edithelp.pl | ||
| fix-perl-path.PL | ||
| help.pl | ||
| INSTALL | ||
| install-CPAN.pl | ||
| INSTALL.debian | ||
| INSTALL.fedora7 | ||
| INSTALL.opensuse | ||
| INSTALL.ubuntu | ||
| INSTALL.ubuntu.lucid | ||
| koha_perl_deps.pl | ||
| kohaversion.pl | ||
| LICENSE | ||
| mainpage.pl | ||
| Makefile.PL | ||
| MANIFEST.SKIP | ||
| README | ||
| README.robots | ||
| rewrite-config.PL | ||
Koha is a free software integrated library system. Koha is distributed under the GNU GPL version 2 or later. Please read the file LICENSE for more details. To install or upgrade Koha, please see the INSTALL file appropriate to your platform. Report bugs at http://bugs.koha-community.org/ Visit the Koha Project website at http://www.koha-community.org/