Koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ
Benjamin Rokseth 2c1f7d2281 Bug 17561: ReserveSlip needs itemnumber for item level holds on same biblio
This patch fixes a regression after bug 14695.
This patch adds itemnumber and barcode as optional params in ReserveSlip used
by hold-transfer-slip.pl to generate HOLD_SLIP. This is for ReserveSlip to be
able to generate correct slips when items in multi-item holds are checked in.

Test plan:

1) activate a circulation rule with multi-item holds
2) Place two holds on same biblio for patron
3) for debugging, either use browser console to observe POST request and responses
   or use info from reserves, e.g. reserve_id in the HOLD_SLIP
4) checkin two items from same biblio on pickup branch
5) note that both holds are effectuated, but reserve_id is the same on both slips
6) also note that there is no itemnumber or barcode in the requests from returns.pl
7) Apply this patch
8) repeat 2-4
9) note that reserve_id is now different on the two slips

and/or:
Run tests:
  t/db_dependent/Reserves/ReserveSlip.t

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Maksim Sen <maksim.sen@inlibro.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-06-04 13:40:36 -04:00
..
article-requests.tt Bug 20034: Switch single-column templates to Bootstrap grid: Circulation 2018-02-15 13:30:23 -03:00
bookcount.tt Bug 19700: Move template JavaScript to the footer: Some circulation pages 2017-12-11 11:34:23 -03:00
branchoverdues.tt
branchtransfers.tt Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
circulation-home.tt Bug 20322: (QA follow-up) Use Font Awesome icons 2018-04-19 16:37:23 -03:00
circulation.tt Bug 17561: ReserveSlip needs itemnumber for item level holds on same biblio 2018-06-04 13:40:36 -04:00
circulation_batch_checkouts.tt Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere 2018-04-13 11:49:44 -03:00
offline-mf.tt
offline.tt Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere 2018-04-13 11:49:44 -03:00
on-site_checkouts.tt Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere 2018-04-13 11:49:44 -03:00
overdue.tt Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere 2018-04-13 11:49:44 -03:00
pendingreserves.tt Bug 19972: (QA follow-up) Fix id name 2018-05-03 13:26:48 -03:00
printslip.tt Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere 2018-04-13 11:49:44 -03:00
renew.tt Bug 19444: (QA follow-up) Remove repeating condition 2017-12-18 12:16:27 -03:00
request-article.tt Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere 2018-04-13 11:49:44 -03:00
reserveratios.tt Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere 2018-04-13 11:49:44 -03:00
returns.tt Bug 20822: (bug 18789 follow-up) Fix HOLD_SLIP 2018-05-29 11:58:54 +00:00
selectbranchprinter.tt
transfer-slip.tt
transferstoreceive.tt Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere 2018-04-13 11:49:44 -03:00
view_holdsqueue.tt Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere 2018-04-13 11:49:44 -03:00
waitingreserves.tt Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere 2018-04-13 11:49:44 -03:00