Main Koha release repository https://koha-community.org
Find a file
Tomas Cohen Arazi 2d19a34529 Bug 18434: Add tests for K:SE:E::get_fixer_rules
This patch tries to introduce exhaustive tests for this class method.
I didn't try to provide a regression test for the current bug per-se, but
cover the current method behaviour as much as I could.

(kidclamp) I added a quick test of _convert_marc_to_json to use the mocking here
and illuminate what the change does, before the patches this should
fail (fields are indexed in place of one another), after it should succeed (new indexed fields are appended).

A minor bug is highlighted by this new tests, I'll provide a followup for it.

To test:
- Run:
  $ sudo koha-shell kohadev
 k$ de kohaclone
 k$ prove t/db_dependent/Koha_Elasticsearch.t
=> FAIL: The returned fixer rules are not the expected ones

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-07-06 14:29:02 -03:00
acqui Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes 2017-07-05 13:42:21 -03:00
admin Bug 17944: QA follow-up 2017-06-05 11:59:11 -03:00
api/v1 Bug 18763: Fix swagger/definitions.t 2017-06-14 14:36:28 -03:00
authorities Bug 17835: Replace GetItemTypes with Koha::ItemTypes 2017-04-14 10:43:51 -04:00
basket Bug 8612: [Follow-up] Make usage and type different columns in table 2017-06-05 12:02:08 -03:00
C4 Bug 18756: Users can view aq.baskets even if they are not allowed 2017-07-06 14:29:01 -03:00
catalogue Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes 2017-07-05 13:42:21 -03:00
cataloguing Bug 18254: Remove call to GetItemsByBiblioitemnumber call from additem.pl 2017-06-15 15:56:00 -03:00
circ Bug 17738: Replace GetReservesFromBorrowernumber with Koha::Patron->get_holds 2017-07-05 13:42:52 -03:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 17835: Replace GetItemTypes with Koha::ItemTypes 2017-04-14 10:43:51 -04:00
debian Bug 18548: Print usage when missing instance name in koha-create script 2017-05-20 14:05:35 +00:00
docs
errors
etc Bug 18669 - RewriteCond affecting wrong rule in koha-httpd.conf 2017-05-28 22:30:11 -04:00
installer Bug 18228: DBRev 17.05.00.002 2017-07-06 14:28:55 -03:00
Koha Bug 18870: Force scalar context for Koha::Club methods 2017-07-06 14:29:01 -03:00
koha-tmpl Bug 18228: Implement the new columns in code 2017-07-05 13:35:23 -03:00
labels Bug 18296: C4::Items - Remove GetItemInfosOf 2017-06-07 11:30:25 -03:00
members Bug 17738: Replace GetReservesFromBorrowernumber with Koha::Patron->get_holds 2017-07-05 13:42:52 -03:00
misc Bug 18835: Fix SQL syntax error in overdue_notices.pl 2017-06-21 11:08:37 -03:00
offline_circ
opac Bug 17738: [QA Follow-up] Remove second find of same patron 2017-07-05 13:42:52 -03:00
OpenILS
patron_lists
patroncards
plugins
reports Bug 13452: Fix for plack 2017-06-15 15:27:46 -03:00
reserve Bug 18296: Remove perlcritic error (request.pl) 2017-06-08 11:59:38 -03:00
reviews
rotating_collections
serials Bug 8612: [Follow-up] Make usage and type different columns in table 2017-06-05 12:02:08 -03:00
services
skel
sms
suggestion Bug 17835: Add an additional LEFT JOIN condition using DBIx::Class 2017-04-14 10:43:52 -04:00
svc Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes 2017-07-05 13:42:21 -03:00
t Bug 18434: Add tests for K:SE:E::get_fixer_rules 2017-07-06 14:29:02 -03:00
tags
test
tmp/modified_authorities
tools Bug 18806: Fix batch revert 2017-06-19 15:34:34 -03:00
virtualshelves Bug 17843: [QA Follow-up] Some polishing 2017-07-05 13:42:21 -03:00
xt Bug 18749 - xt/sample_notices.t fails 2017-06-13 12:37:15 -03:00
.editorconfig
.htaccess
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
about.pl
changelanguage.pl
edithelp.pl
fix-perl-path.PL
help.pl
INSTALL
install-CPAN.pl
Koha.pm Bug 18228: DBRev 17.05.00.002 2017-07-06 14:28:55 -03:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl Bug 18432 : Follow up - Updating to use they/them 2017-04-21 10:56:43 -04:00
Makefile.PL Bug 18373: Re-add UpgradeBackup.pm 2017-04-14 10:41:03 -04:00
MANIFEST.SKIP
README
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots
rewrite-config.PL

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo