Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/C4
History
Joonas Kylmälä 338ba1d769 Bug 25690: Remove duplicated logic in SIP2 checkouts 
Because AllowItemsOnHoldCheckoutSIP only affects the checkoutability
of non-attached, i.e. RESERVED holds in SIP2 we can therefore use the
common code from CanBookBeIssued and ignore only the RESERVED confirmation
message case in SIP2 checkout code.

This slightly changes the checkout error message given for "In
processing" holds that someone other than the holdee tries to
checkout. Otherwise there is no logic changes. The message that this
changes is "Item is on hold for another patron." vs. now "Item cannot
be issued: $confirmation". It is easier to create follow-up patch to
properly add INPROCESSING confirmation to CanBookBeIssued and then
show correct message based on the CanBookBeIssued return value.

To test:
 1) Apply all patches from bug 25690 to get latest Transaction.t version
 2) prove t/db_dependent/SIP/Transaction.t => passes

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-03-04 16:18:42 +01:00
..
AuthoritiesMarc
Barcodes Bug 26673: Fix perlcritic complains 2020-11-02 08:42:20 +01:00
ClassSortRoutine
ClassSplitRoutine Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Creators Bug 25852: Improve C4::Creators::Lib reliability under plack 2020-07-31 10:03:26 +02:00
External
Form
Heading
ILSDI Bug 17229: Check if patron is expired in CanItemBeReserved 2021-01-19 15:45:11 +01:00
Installer
Labels Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Linker Bug 25189: Don't create authority if results found 2020-06-24 14:31:37 +02:00
Members Bug 24447: Changing 'DUE' to example in database that exists. 2021-01-22 13:46:41 +01:00
OAI Bug 25460: Update OAI sets when adding/editing/deleting item records 2020-10-15 12:56:30 +02:00
Output
Patroncards Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Reports Bug 27380: Move get_prepped_report to object and use for svc/reports 2021-02-12 12:29:56 +01:00
Search
Serials
SIP Bug 25690: Remove duplicated logic in SIP2 checkouts 2021-03-04 16:18:42 +01:00
Utils Bug 27715: (QA follow-up) Remove conditional declaration 2021-02-24 00:12:59 +01:00
Accounts.pm Bug 22394: Remove C4::Accounts::manualinvoice 2020-11-04 12:59:33 +01:00
Acquisition.pm Bug 26584: Remove unused C4::Acquisition::CloseBasket function 2020-11-05 15:24:20 +01:00
Auth.pm Bug 18506: (QA follow-up) opacShibOnly -> OPACShibOnly 2021-02-09 09:46:08 +01:00
Auth_cas_servers.yaml.sample
Auth_with_cas.pm Bug 27673: Replace YAML with YAML::XS 2021-02-16 14:54:50 +01:00
Auth_with_ldap.pm
Auth_with_shibboleth.pm
AuthoritiesMarc.pm Bug 8976: Sort subfields for authority records 2021-03-01 15:14:22 +01:00
BackgroundJob.pm
Barcodes.pm
Biblio.pm Bug 8976: Code cleaning 2021-03-01 15:14:22 +01:00
Boolean.pm
Breeding.pm Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Budgets.pm
Calendar.pm Bug 25723: (QA follow-up) Handle holiday and exception on same day 2020-07-20 17:45:31 +02:00
Charset.pm
Circulation.pm Bug 25690: Remove double usage of 'Reserved' return value 2021-03-04 16:18:42 +01:00
ClassSortRoutine.pm Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
ClassSource.pm
ClassSplitRoutine.pm
Context.pm Bug 27673: Fix encoding issues 2021-02-16 14:54:50 +01:00
Contract.pm Bug 24217: use Modern::Perl for modules when strict is missing 2020-01-03 10:45:46 +00:00
CourseReserves.pm Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Creators.pm Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Debug.pm
Heading.pm Bug 24269: Adjust C4::Heading to generate headings from auth tags 2020-02-19 13:33:32 +00:00
HoldsQueue.pm Bug 27068: Perltidy _checkHoldPolicy 2021-02-12 13:08:56 +01:00
HTML5Media.pm Bug 27422: YouTube videos are HTTPS only 2021-02-08 17:09:34 +01:00
ImportBatch.pm Bug 24469: Move the new queries to a dedicated ImportBatch subroutine 2021-02-18 11:52:59 +01:00
ImportExportFramework.pm Bug 27569: Fix ODS export - take empty string into account 2021-02-16 10:22:13 +01:00
InstallAuth.pm Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Installer.pm Bug 27491: Rename system preference opaclanguages to OPACLanguages 2021-01-22 14:59:27 +01:00
ItemCirculationAlertPreference.pm
Items.pm Bug 24446: Update ModItemTransfer for daterequested/datecancelled 2021-03-03 15:36:13 +01:00
Koha.pm Bug 16371: Move GetDailyQuote to get_daily_quote 2020-08-13 10:15:33 +02:00
Labels.pm Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Languages.pm Bug 27491: Rename system preference opaclanguages to OPACLanguages 2021-01-22 14:59:27 +01:00
Letters.pm Bug 7806: Fix remaining occurrences of 0000-00-00 2021-03-01 11:16:42 +01:00
Linker.pm
Log.pm Bug 23632: Remove C4::Logs::GetLogs 2020-08-18 15:45:48 +02:00
MarcModificationTemplates.pm Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
Matcher.pm Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Members.pm Bug 27050: Allow multiple category_codes in delete_patrons.pl 2021-02-08 17:09:34 +01:00
Message.pm Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
NewsChannels.pm Bug 21066: Rename publicationdate with published_on 2020-09-02 15:35:08 +02:00
Output.pm Bug 11994: OpenSearch plugins needs to be delivered with Content-Type application/opensearchdescription+xml 2020-06-24 14:31:37 +02:00
Overdues.pm Bug 27079: Floating point comparison correction 2020-11-27 09:37:40 +01:00
Patroncards.pm Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Record.pm Bug 27673: Fix encoding issues 2021-02-16 14:54:50 +01:00
Reports.pm Bug 27486: Rename system preference delimiter to CSVDelimiter 2021-01-29 09:03:45 +01:00
Reserves.pm Bug 25690: Remove double usage of 'Reserved' return value 2021-03-04 16:18:42 +01:00
Ris.pm Bug 27673: Fix encoding issues 2021-02-16 14:54:50 +01:00
RotatingCollections.pm Bug 26618: Improve Exception Class Names 2021-03-03 15:36:13 +01:00
Scheduler.pm
Scrubber.pm
Search.pm Bug 27673: Replace YAML with YAML::XS 2021-02-16 14:54:50 +01:00
Serials.pm Bug 7806: Fix remaining occurrences of 0000-00-00 2021-03-01 11:16:42 +01:00
Service.pm Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
ShelfBrowser.pm Bug 26673: Remove shebangs from Perl modules 2020-10-26 00:14:42 +01:00
SMS.pm Bug 27673: Replace YAML with YAML::XS 2021-02-16 14:54:50 +01:00
SocialData.pm
Stats.pm Bug 24151: Copy info to the pseudonymized table when a transaction is done 2020-07-20 15:17:42 +02:00
Suggestions.pm Bug 7806: Fix remaining occurrences of 0000-00-00 2021-03-01 11:16:42 +01:00
Tags.pm
Templates.pm Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
TmplToken.pm
TmplTokenType.pm
TTParser.pm Bug 26673: Remove #!/usr/bin/env perl from .pm modules too 2020-10-26 00:14:42 +01:00
UsageStats.pm Bug 20410: Remove OpacGroupResults and PazPar2 2021-02-08 16:12:42 +01:00
XISBN.pm Bug 26364: Don't discard the passed isbn 2021-01-07 15:37:15 +01:00
XSLT.pm Bug 27581: Rename USeICU preference to UseICUStyleQuotes 2021-02-08 14:56:00 +01:00