338ba1d769
Because AllowItemsOnHoldCheckoutSIP only affects the checkoutability of non-attached, i.e. RESERVED holds in SIP2 we can therefore use the common code from CanBookBeIssued and ignore only the RESERVED confirmation message case in SIP2 checkout code. This slightly changes the checkout error message given for "In processing" holds that someone other than the holdee tries to checkout. Otherwise there is no logic changes. The message that this changes is "Item is on hold for another patron." vs. now "Item cannot be issued: $confirmation". It is easier to create follow-up patch to properly add INPROCESSING confirmation to CanBookBeIssued and then show correct message based on the CanBookBeIssued return value. To test: 1) Apply all patches from bug 25690 to get latest Transaction.t version 2) prove t/db_dependent/SIP/Transaction.t => passes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
||
|---|---|---|
| .. | ||
| Checkin.pm | ||
| Checkout.pm | ||
| FeePayment.pm | ||
| Hold.pm | ||
| Renew.pm | ||
| RenewAll.pm | ||