Main Koha release repository https://koha-community.org
Find a file
Emmi Takkinen 355ab980cc
Bug 31154: Pass biblionumber to Koha::UI::Form::Builder::Item->new from batchMod.pl to prevent error 500
When one tries to batch mod items and has "Use default values"
checkbox checked on and they have value in syspref "itemcallnumber",
Koha dies on error 500. In logs it reads:

Can't call method "field" on an undefined value at
.../Koha/Koha/UI/Form/Builder/Item.pm line 164.

This happens because in batchMod.pl line 269 we don't pass
biblionumber as parameter to Koha::UI::Form::Builder::Item->new
and thus Koha fails to fetch biblios marc record.

To test:
1. Confirm you have/set value to syspref "itemcallnumber" e.g. 084a
2. Find some item(s) to modify
3. Provide barcodes of those item(s) and check checkbox "Use default values"
4. Hit "Continue"
=> error 500 is raised
5. Apply patch.
6. Repeat steps 3. and 4.
=> no error is raised

Sponsored-by: Koha-Suomi Oy

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-09-16 10:26:26 -03:00
acqui Bug 29658: Fix crash on cancelling cancelled order 2022-09-12 16:14:47 -03:00
admin Bug 29144: Adjust libraries form 2022-09-16 09:55:20 -03:00
api Bug 29144: Copy and remove branches.opac_info (dbrev) 2022-09-16 09:55:20 -03:00
authorities Bug 29333: Fix encoding of imported UNIMARC authorities 2022-07-08 15:43:33 -03:00
basket Bug 31309: Remove GetItemsInfo from basket/sendbasket 2022-08-16 09:22:14 -03:00
bin
C4 Bug 31236: Add ability to send custom item fields via SIP using Template Toolkit 2022-09-12 17:44:36 -03:00
catalogue Bug 31535: Fix warning - uninitialized value in string ne (MARCdetail.pl) 2022-09-12 16:16:28 -03:00
cataloguing Bug 31535: Fix warning - uninitialized value $mode in string ne (addbiblio.pl) 2022-09-12 16:16:28 -03:00
circ Bug 24295: Remove GetTransfers from circ/transferstoreceive.pl 2022-08-26 15:42:52 -03:00
clubs Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
course_reserves Bug 30409: barcodedecode() should always trim barcode 2022-06-14 07:54:58 -03:00
debian Bug 31250: (QA follow-up) The future will be easier 2022-09-12 15:34:11 -03:00
docs Bug 30808: Add the 22.05 release team. 2022-05-25 23:56:12 -10:00
errors
etc Bug 31236: Add ability to send custom item fields via SIP using Template Toolkit 2022-09-12 17:44:36 -03:00
ill Bug 28909: Allow illview to use backend template 2022-08-09 13:21:39 -03:00
installer Bug 29144: DBRev 22.06.00.045 2022-09-16 10:25:07 -03:00
Koha Bug 29144: DBIC schema 2022-09-16 10:10:49 -03:00
koha-tmpl Bug 29144: (follow-up) Fix rebase issue related to bug 31313 2022-09-16 09:55:21 -03:00
labels Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
lib/CGI/Session/Serialize
members Bug 30335: (follow-up) Bind new permissions to pages and tabs 2022-08-31 08:41:01 -03:00
misc Bug 31351: (QA follow-up) Use $self->json in Background modules 2022-09-07 13:59:03 -07:00
offline_circ Bug 30016: Remove GetOpenIssue subroutine 2022-08-31 08:50:37 -03:00
opac Bug 29144: Show html opac_info on opac-detail page 2022-09-16 09:55:20 -03:00
patron_lists
patroncards Bug 24001: Fix patron card template edition 2022-04-28 10:49:20 -10:00
plugins
pos Bug 30619: Add email receipt to POS 2022-09-07 15:59:34 -07:00
recalls Bug 30924: Add missing branchtransfers.reason value for recall cancellation 2022-06-13 10:30:51 -03:00
reports Bug 28327: Unify CSV delimiter special behavior for tabulation 2022-08-19 15:53:12 -03:00
reserve Bug 24295: Remove GetTransfers from request.pl 2022-08-26 15:42:22 -03:00
reviews
rotating_collections
serials Bug 29608: Made so doesn't require full permission 2022-09-07 13:49:53 -07:00
services
skel
suggestion Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
svc Bug 27981: (follow-up) Correct variable 2022-09-12 15:17:36 -03:00
t Bug 29144: Remove opac_info from a few tests 2022-09-16 09:55:20 -03:00
tags Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
tmp/modified_authorities
tools Bug 31154: Pass biblionumber to Koha::UI::Form::Builder::Item->new from batchMod.pl to prevent error 500 2022-09-16 10:26:26 -03:00
virtualshelves Bug 31320: Remove GetItemsInfo from virtualshelves/sendshelf.pl 2022-08-16 09:23:25 -03:00
xt Bug 27619: (QA follow-up) Remove xt/sample_notices.t 2022-05-11 11:28:48 +01:00
.editorconfig
.eslintrc.json
.gitignore
.htaccess
.mailmap 22.05.00: Update mailmap 2022-05-25 23:56:12 -10:00
.perlcriticrc
.proverc.dist
.scss-lint.yml
about.pl Bug 27667: Display a warning for records missing in Elasticsearch 2022-07-18 14:53:15 -03:00
app.psgi
changelanguage.pl
cpanfile Bug 31499: Add libhttp-tiny-perl 0.076 dependency for ES7 2022-08-31 14:25:16 -03:00
fix-perl-path.PL
gulpfile.js
help.pl
INSTALL
Koha.pm Bug 29144: DBRev 22.06.00.045 2022-09-16 10:25:07 -03:00
koha_perl_deps.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
kohaversion.pl
LICENSE
mainpage.pl Bug 30650: Add filter_by_scheduled_today 2022-07-29 15:00:47 -03:00
Makefile.PL
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
package.json
README
README.md
README.robots
rewrite-config.PL
yarn.lock

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo