Main Koha release repository https://koha-community.org
Find a file
David Cook 38ef4f635d
Bug 31303: Prevent fatal errors when missing "waiting hold cancellation" rule
This patch removes method chaining which didn't account for the fact that
the "waiting hold cancellation" circulation rule might not exist.

Test plan:
0. Apply patch and koha-plack --restart kohadev
1. Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=29
2. Search for "koha" user
3. Choose the specific item and click "Place hold"
4. Check in "39999000001310" and click "Confirm hold (Y)"
5. Go to http://localhost:8080/cgi-bin/koha/opac-user.pl#opac-user-holds
6. Rejoice in Koha not exploding
7. Go to http://localhost:8081/cgi-bin/koha/admin/smart-rules.pl
8. Go to "Default waiting hold cancellation policy" and change "Cancellation allowed" to "Yes" and click "Add"
9. Go to http://localhost:8080/cgi-bin/koha/opac-user.pl#opac-user-holds
10. Note the "Cancel" button appears
11. Rejoice again that the "Cancel" button appeared

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-08-08 13:20:21 -03:00
acqui
admin Bug 29983: Show the column by default but hide if the feature is disabled 2022-08-05 14:44:17 -03:00
api
authorities
basket Bug 29697: Use flag embed_items 2022-07-22 15:24:11 -03:00
bin
C4 Bug 31296: (QA follow-up) Fix trivial spelling errors 2022-08-08 13:15:29 -03:00
catalogue Bug 30077: (QA follow-up) Avoid warning 2022-08-01 14:48:34 -03:00
cataloguing Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record 2022-07-22 15:24:11 -03:00
circ Bug 29983: Format dates in templates using KohaDates (and display the time part) 2022-08-05 14:44:17 -03:00
clubs
course_reserves
debian Bug 31296: (QA follow-up) Add to debian templates 2022-08-08 13:13:26 -03:00
docs
errors
etc Bug 31296: Add ability to disable demagnetizing items via SIP2 based on itemtypes 2022-08-08 13:13:26 -03:00
ill
installer Bug 30500: DBRev 22.06.00.032 2022-08-05 11:56:24 -03:00
Koha Bug 31303: Prevent fatal errors when missing "waiting hold cancellation" rule 2022-08-08 13:20:21 -03:00
koha-tmpl Bug 31305: Remove type= from detail.pl 2022-08-08 13:11:53 -03:00
labels
lib/CGI/Session/Serialize
members Bug 30874: Remove category_type 2022-08-05 14:51:36 -03:00
misc Bug 31155: Document --since option in help of borrowers-force-messaging-defaults.pl 2022-08-08 13:12:45 -03:00
offline_circ Bug 30275: Rename issues.renewals to issues.renewals_count 2022-07-05 09:45:55 -03:00
opac Bug 30500: (QA follow-up) Separate code execution streams for obviously independent parameters 2022-08-05 11:54:55 -03:00
patron_lists
patroncards Bug 24001: Fix patron card template edition 2022-04-28 10:49:20 -10:00
plugins
pos
recalls Bug 30924: Add missing branchtransfers.reason value for recall cancellation 2022-06-13 10:30:51 -03:00
reports Bug 21982: Circulation statistics wizard does not count deleted items 2022-07-26 09:10:28 -03:00
reserve Bug 30992: Improve translatability for Waiting at|On hold 2022-08-05 11:52:45 -03:00
reviews
rotating_collections
serials Bug 29697: Use flag embed_items 2022-07-22 15:24:11 -03:00
services Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
skel
suggestion
svc Bug 29697: Replace some missing occurrences 2022-07-25 09:30:30 -03:00
t Bug 31296: Add ability to disable demagnetizing items via SIP2 based on itemtypes 2022-08-08 13:13:26 -03:00
tags Bug 29469: (bug 17600 follow-up) Fix tag approval/rejection from staff 2021-11-16 15:49:22 +01:00
tmp/modified_authorities
tools Bug 31211: Check slips and notices for valid Template Toolkit and report errors 2022-07-26 09:28:56 -03:00
virtualshelves Bug 29697: Use flag embed_items 2022-07-22 15:24:11 -03:00
xt
.editorconfig Bug 27375: Set YAML file settings in .editorconfig 2021-11-03 15:40:52 +01:00
.eslintrc.json
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
.mailmap
.perlcriticrc
.proverc.dist Bug 19821: Install sample data, ES mappings and Version syspref 2021-10-25 11:27:40 +02:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
about.pl Bug 27667: Display a warning for records missing in Elasticsearch 2022-07-18 14:53:15 -03:00
app.psgi
changelanguage.pl
cpanfile
fix-perl-path.PL
gulpfile.js
help.pl
INSTALL
Koha.pm Bug 30500: DBRev 22.06.00.032 2022-08-05 11:56:24 -03:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl Bug 30650: Add filter_by_scheduled_today 2022-07-29 15:00:47 -03:00
Makefile.PL
MANIFEST.SKIP
package.json
README
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-11-25 16:31:58 +01:00
README.robots
rewrite-config.PL
yarn.lock Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo