Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/koha-tmpl/intranet-tmpl/prog/en/includes
History
Nick Clemens 39faff6606 Bug 18532: Add individual issues to digest notice and hide auto_renewals messaging preference when not needed 
This patch enhances auto_renewals message, removes auto_renewals messaging preference when AutoRenewalNotices is not set to ‘preferences’ and uses that preference to send notices in automatic_renewals.pl script.

To test:

1. Apply patches
2. updatedatabase
3. make sure automatic renewals are allowed in circ rules, have a positive number of allowed renewals and a positive number for renewal period
4. Check AutoRenewalNotices preference
SUCCESS => AutoRenewalNotices has the value ‘cron’ (means that It keeps the usual behaviour)
5. Checkout two items for a patron, and set them as automatic renewal and set due date as your current yesterday
6. perl misc/cronjobs/automatic_renewals.pl -c -v
SUCCESS => items were renewed, but there is no message in message_queue table in mysql
7. Repeat step 5
8. perl misc/cronjobs/automatic_renewals.pl -c -s -v
SUCCESS => items were renewed, and there is one message per item in message_queue table in mysql
9. Change AutoRenewalNotices to ‘never’
10. Repeat step 5
11. perl misc/cronjobs/automatic_renewals.pl -c -s -v
SUCCESS => items were renewed, but there is no message in message_queue table in mysql, even with the -s switch
12. Check any patron’s category, and any detail page in staff or OPAC interface, and in any of them you should find Auto Renewals messaging preference
13. Change AutoRenewalNotices to ‘preferences’
14. Repeat step 12, but this time all of them shows the Auto Renewals messaging preference.
15. Repeat step 5 with a patron that has no messaging preference setted
16. perl misc/cronjobs/automatic_renewals.pl -c -s -v
SUCCESS => items were renewed, but there is no message in message_queue table in mysql, because patron didn’t choose to receive messages
17. Grab a category and modify auto renewals messaging preferences, and save
18. Create a new patron from that category.
SUCCESS => created patron has the same messaging preference for auto renewals
19. Grab that patron and change auto renewals messaging preference to email but not digest
20. Repeat step 5 for that last patron.
21. perl misc/cronjobs/automatic_renewals.pl -c -v
SUCCESS => Items were renewed, and there is a message for each item in message_queue table in mysql.
22. Change auto renewals messaging preference from the same patron and set to email and digest.
23. Repeat step 5.
24. perl misc/cronjobs/automatic_renewals.pl -c -v
SUCCESS => items where renewed, and now there is only one message in message_queue table with the details of both renewed items.
25. Check that any changes to a patron’s auto renewals messaging preference in staff is reflected in OPAC, and the other way arround too.
26. Sign off

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-03-16 16:08:31 +01:00
..
catalogue Bug 27486: Rename system preference delimiter to CSVDelimiter 2021-01-29 09:03:45 +01:00
csv_headers Bug 27486: Rename system preference delimiter to CSVDelimiter 2021-01-29 09:03:45 +01:00
mana Bug 26602: Don't export "actions" column 2021-02-08 14:56:00 +01:00
modals Bug 26274: Update register.tt to use the API 2021-02-12 12:33:41 +01:00
str Bug 26334: Move translatable strings out of members-menu.inc into members-menu.js 2020-09-29 14:28:18 +02:00
virtualshelves/merge
about-team.inc Bug 27495: Added Accessibility advocate role in team page 2021-01-22 14:59:27 +01:00
accounts.inc Bug 26697: Make account.inc consistent between staff and opac 2020-11-10 15:00:14 +01:00
acquisitions-add-to-basket.inc
acquisitions-menu.inc Bug 26089: Add acquisitions-related reports to acquisitions sidebar menu 2020-10-01 10:32:15 +02:00
acquisitions-search.inc Bug 25954: Replace paragraph tags with labels in header search forms 2021-01-04 14:06:27 +01:00
acquisitions-toolbar.inc Bug 25002: JS Includes should be wrapped with template comments 2020-04-29 17:15:20 +01:00
additional-fields-display.inc
additional-fields-entry.inc
admin-items-search-field-form.inc
admin-menu.inc Bug 22343: Add CRUD page for SMTP servers 2020-10-02 10:54:40 +02:00
adv-search.inc Bug 25954: Replace paragraph tags with labels in header search forms 2021-01-04 14:06:27 +01:00
auth-finder-search.inc
authorities-search-results.inc Bug 12533: Improve authority search result display 2020-11-04 12:59:33 +01:00
authorities-search.inc Bug 25954: (QA follow-up) Correct label "for" attribute in authorities search 2021-01-04 14:06:27 +01:00
authorities-toolbar.inc
authorities.inc
authorities_js.inc Bug 26606: Correctly URI-encode query string in URL loaded after deleting an authority record 2020-10-26 00:16:14 +01:00
av-build-dropbox.inc Bug 18680: Add an empty entry by default to sort1/sort2 values in patron account 2020-04-20 12:28:04 +01:00
biblio-title-head.inc
biblio-title.inc Bug 23852: Merge biblio-title.inc and biblio-default-view.inc 2020-10-08 15:01:29 +02:00
biblio-view-menu.inc
blocked-fines.inc Bug 24098: Standardize Fines/Fees & Charges 2020-05-11 09:54:20 +01:00
blocking_errors.inc Bug 10921: Prevent an order from a closed basket to be edited 2020-09-18 11:49:29 +02:00
borrower_debarments.inc Bug 25744: Replace <i> with <em> in staff interface 2020-09-18 11:08:35 +02:00
branch-selector.inc
budget_planning.inc Bug 24636: (follow-up) - move 'by' into include file 2020-05-04 08:53:04 +01:00
budgets-active-currency.inc Bug 25744: replace <b> with <strong> in the staff interface 2020-09-18 11:08:35 +02:00
budgets-admin-search.inc Bug 25954: Replace paragraph tags with labels in header search forms 2021-01-04 14:06:27 +01:00
budgets-admin-toolbar.inc
calendar.inc Bug 26261: Split calendar.inc into include file and JavaScript file 2020-09-29 14:28:19 +02:00
cat-menu.inc
cat-search.inc Bug 25954: (follow-up) Correct label "for" attribute 2021-01-04 14:06:27 +01:00
cat-toolbar.inc Bug 27324: Use Koha.Preference() for intranetbookbag everywhere 2021-01-20 10:16:48 +01:00
catalog-strings.inc Bug 26441: Move translatable strings out of catalog-strings.inc into catalog.js 2020-09-29 14:28:18 +02:00
cataloging-search.inc Bug 25954: (follow-up) Correct label "for" attribute 2021-01-04 14:06:27 +01:00
cateditor-ui.inc Bug 26964: Newly created macros should be selected in the Advanced editor 2021-03-08 15:15:52 +01:00
cateditor-widgets-marc21.inc Bug 25002: JS Includes should be wrapped with template comments 2020-04-29 17:15:20 +01:00
category-out-of-age-limit.inc
chart.inc
checkin-search.inc Bug 25954: (follow-up) Correct label "for" attribute 2021-01-04 14:06:27 +01:00
checkouts-table-footer.inc Bug 19351: Add items.copynumber to the checkouts table 2020-11-04 12:59:34 +01:00
checkouts-table.inc Bug 24083: Add support for unseen_renewals 2020-11-11 16:09:58 +01:00
circ-menu.inc Bug 27652: Display patron's categories for sysprefs expecting them 2021-03-09 17:20:47 +01:00
circ-nav.inc Bug 24201: (QA follow-up) IndependentBranches 2020-08-07 16:54:40 +02:00
circ-patron-search-results.inc Bug 15400: Display date of birth and age more consistantly 2020-06-29 12:37:02 +02:00
circ-search.inc Bug 25954: (follow-up) Correct label "for" attribute 2021-01-04 14:06:27 +01:00
cities-admin-search.inc Bug 25954: (follow-up) Correct label "for" attribute 2021-01-04 14:06:27 +01:00
clubs-table.inc Bug 25282: (follow-up) More corrections 2020-04-29 16:20:24 +01:00
columns_settings.inc Bug 26234: Teach our KohaTable constructor the specific th classes 2020-08-19 08:24:04 +02:00
contracts-admin-search.inc Bug 25954: (follow-up) Correct label "for" attribute 2021-01-04 14:06:27 +01:00
country-list.inc
currencies-admin-search.inc Bug 25954: (follow-up) Correct label "for" attribute 2021-01-04 14:06:27 +01:00
datatables.inc
date-format.inc
delimiter_text.inc Bug 27486: Rename system preference delimiter to CSVDelimiter 2021-01-29 09:03:45 +01:00
desks-admin-search.inc Bug 25954: (follow-up) Correct label "for" attribute 2021-01-04 14:06:27 +01:00
doc-head-close-receipt.inc
doc-head-close.inc
doc-head-open.inc
empty_line.inc
facets.inc Bug 26323: (QA follow-up) Fix syntax errors 2020-09-28 16:09:10 +02:00
filter-orders.inc Bug 26503: Add limit for standing orders to acq advanced search 2020-10-12 11:28:41 +02:00
form-blocks.inc
format_price.inc Bug 25002: JS Includes should be wrapped with template comments 2020-04-29 17:15:20 +01:00
greybox.inc Bug 25002: JS Includes should be wrapped with template comments 2020-04-29 17:15:20 +01:00
guided-reports-view.inc
header.inc Bug 27699: Add register information to responsive staff interface header menu 2021-03-09 15:05:26 +01:00
holds_table.inc Bug 26988: (follow-up) Fix filter and encode api values and escape rendered values 2020-11-13 14:20:11 +01:00
home-search.inc Bug 25954: Replace paragraph tags with labels in header search forms 2021-01-04 14:06:27 +01:00
html_helpers.inc Bug 24665: (QA follow-up) Fix selection default 2020-11-06 15:55:17 +01:00
i18n.inc Bug 26816: Chomp whitespace around i18n strings 2020-11-02 11:03:09 +01:00
ill-availability-table.inc Bug 23173: (follow-up) Fix QA script errors 2020-04-06 11:05:14 +01:00
ill-list-table-strings.inc Bug 25002: JS Includes should be wrapped with template comments 2020-04-29 17:15:20 +01:00
ill-list-table.inc
ill-toolbar.inc
installer-doc-head-close.inc
installer-intranet-bottom.inc Bug 25002: JS Includes should be wrapped with template comments 2020-04-29 17:15:20 +01:00
installer-strings.inc Bug 25002: JS Includes should be wrapped with template comments 2020-04-29 17:15:20 +01:00
intranet-bottom.inc Bug 24201: (follow-up) add desk choice with library choice 2020-08-07 16:54:40 +02:00
intranetstylesheet.inc
js-date-format.inc Bug 24980: (follow-up) return '' when date is null 2020-05-01 08:14:34 +01:00
js_includes.inc Bug 27031: Use Koha.Preference() more often in header.inc and js_includes.inc 2021-01-04 13:29:56 +01:00
keyboard_shortcuts.inc
labels-toolbar.inc
langmenu-staff-top.inc Bug 20168: Update of the OPAC bootstrap template to bootstrap v4 2020-09-09 14:13:03 +02:00
last-borrower.inc
letters-search.inc Bug 25954: (follow-up) Correct label "for" attribute 2021-01-04 14:06:27 +01:00
member-alt-address-style.inc Bug 26538: Display cities list before input text 2020-10-14 11:47:57 +02:00
member-alt-contact-style.inc Bug 26538: Display cities list before input text 2020-10-14 11:47:57 +02:00
member-display-address-style.inc Bug 26666: (QA follow-up) Add 'USE raw' in template 2020-10-26 00:14:41 +01:00
member-display-alt-address-style.inc Bug 25070: Centralize member-display-alt-address-style 2020-06-15 11:53:36 +02:00
member-main-address-style.inc Bug 26538: Display cities list before input text 2020-10-14 11:47:57 +02:00
members-toolbar.inc Bug 12224: Print a slip of borrower's checkins for today 2021-03-05 13:49:03 +01:00
merge-record.inc
messaging-preference-form.inc Bug 18532: Add individual issues to digest notice and hide auto_renewals messaging preference when not needed 2021-03-16 16:08:31 +01:00
noadd-warnings.inc
onboarding_messages.inc
page-numbers.inc Bug 14715: (follow-up) Keep results per page setting when selecting facets and sorting results 2020-03-26 12:03:42 +00:00
password_check.inc Bug 23816: Fix patron edition 2020-09-10 09:57:53 +02:00
patron-age.inc Bug 27717: Display date of birth even if the patron is under 1 2021-03-05 13:38:58 +01:00
patron-article-requests.inc Bug 25744: Replace <i> with <em> in staff interface 2020-09-18 11:08:35 +02:00
patron-return-claims.inc
patron-search-box.inc Bug 25954: Replace paragraph tags with labels in header search forms 2021-01-04 14:06:27 +01:00
patron-search.inc Bug 25954: (follow-up) Correct label "for" attribute 2021-01-04 14:06:27 +01:00
patron-title.inc Bug 25747: Don't display a comma when patron has no firstname 2020-06-24 14:31:37 +02:00
patron-toolbar.inc
patroncards-errors.inc
patroncards-toolbar.inc
patronfields.inc
patrons-admin-search.inc Bug 25954: Prevent two elements with id="description" in the DOM 2021-01-04 15:14:26 +01:00
payments.inc Bug 27289: (follow-up) Update payment type too. 2021-02-08 14:56:00 +01:00
permissions.inc Bug 26718: Rename "reading history" to "checkout history" 2020-11-04 12:59:33 +01:00
popup-bottom.inc
pos-menu.inc Bug 25138: Terminology: Point of sale should use library instead of branch 2020-04-17 13:50:23 +01:00
prefs-admin-search.inc Bug 25954: (follow-up) Correct label "for" attribute 2021-01-04 14:06:27 +01:00
prefs-menu.inc Bug 27336: Sanitize correctly HTML id 2021-01-11 10:27:37 +01:00
relatives-issues-table.inc Bug 27133: (bug 19351 follow-up) Add missing "Copy no" header to relative's checkouts 2020-12-14 14:17:37 +01:00
renew_results.inc
renew_strings.inc Bug 25717: Improve automatic renewal error messages 2020-07-20 17:45:31 +02:00
reports-menu.inc Bug 20415: add Koha.ArePluginsEnabled Template Toolkit method 2020-03-26 11:41:54 +00:00
reports-toolbar.inc Bug 26165: Fix duplication of large saved reports 2020-08-12 11:46:30 +02:00
resort_form.inc Bug 25014: Fix capitalization for "Call Number" in staff and OPAC sort options 2020-04-03 14:26:34 +01:00
rotating-collections-toolbar.inc
search_indexes.inc Bug 25954: Replace paragraph tags with labels in header search forms 2021-01-04 14:06:27 +01:00
select2.inc Bug 25727: (follow-up) Some style updates, JS i18n 2020-08-24 11:19:03 +02:00
serials-menu.inc Bug 26484: Add serials-related reports to serials sidebar menu 2020-10-01 10:32:15 +02:00
serials-search.inc Bug 25954: (follow-up) Correct label "for" attribute 2021-01-04 14:06:27 +01:00
serials-toolbar.inc
slip-print.inc Bug 25002: JS Includes should be wrapped with template comments 2020-04-29 17:15:20 +01:00
stockrotation-toolbar.inc
subscriptions-search.inc
subtypes_unimarc.inc
suggestions-add-search.inc Bug 25954: (follow-up) Correct label "for" attribute 2021-01-04 14:06:27 +01:00
timepicker.inc Bug 25133: (follow-up) Move changes to timepicker.inc 2020-05-04 13:45:31 +01:00
tools-item-action.inc Bug 26336: Add hint before and remove select after staging with no items 2020-12-04 15:40:58 +01:00
tools-menu.inc Bug 25627: Move OPAC problem reports from administration to tools 2020-06-15 11:53:36 +02:00
tools-nomatch-action.inc
tools-overlay-action.inc
transfer_reasons.inc Bug 22569: (QA follow-up) Make 'reason' translatable 2021-03-11 11:51:40 +01:00
validator-strings.inc Bug 25002: JS Includes should be wrapped with template comments 2020-04-29 17:15:20 +01:00
vendor-menu.inc
virtualshelves-toolbar.inc
waiting_holds.inc Bug 24412: (follow-up) bad desk printing 2020-11-06 15:55:17 +01:00
wysiwyg-systempreferences.inc Bug 25862: Prevent TinyMCE to mangle local url links 2020-07-20 14:05:21 +02:00
xslt-handler.inc
z3950-admin-search.inc Bug 25954: (follow-up) Correct label "for" attribute 2021-01-04 14:06:27 +01:00
z3950_search.inc Bug 26291: Move translatable strings out of z3950_search.inc into z3950_search.js 2020-09-29 14:28:19 +02:00