Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Main Koha release repository https://koha-community.org
16900 commits 35 branches 612 tags 1.8 GiB
Perl 45.3%
JavaScript 39.4%
HTML 7.2%
XSLT 3.9%
Vue 1.4%
Other 2.3%
Find a file
Colin Campbell 3b608056d9 Bug 6976 Close loophole allowing borrowers extra holds via opac 
The check that the max number of reserves has
not been reached needs to take account of the fact
that we may have added enouch reserves to
reach the limit while this script is running.
Add a check against the incrementing count

The variable canreserve was only used when looping
through multiple holds but was not being
reinitialized on every iteration
make variable local to loop it is used in and
initialize to zero

Have used perltidy to correct the indention of
the while loop as it was misleading to the reader

Some numeric comparisons were using a string operator
fix them before strange bugs manifest themselves

The loophole manifests thus:
borrowers are only allowed Y holds.
If holds are done individually, it is
obeying that law i.e. X has held Y separate books –
 when I tried to do a 6th
book it told me that I could not place a hold.
However, if a borrower checks the catalogue,
gets the intial list up and clicks items on the “results”
box and then clicks “place hold” they can hold more than Y
items Please enter the commit message for your changes. Lines starting

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-09-14 15:22:46 +02:00
acqui Bug 7583 follow-up: Prevent users to cancel receipt if they can't 2012-09-13 18:29:42 +02:00
admin bug_5911: Transport Cost Matrix 2012-09-12 14:49:25 +02:00
authorities Bug 8071: link between bib and authorities with the authid 2012-09-14 13:29:14 +02:00
basket Bug 6050 Make calls to GetItemsInfo consistent 2011-06-14 14:12:02 +12:00
C4 Bug 8447: Make sure we have enough subfields for broader_headings 2012-09-14 14:56:48 +02:00
catalogue Bug 8622: Fix theme fallback 2012-09-05 11:39:14 +02:00
cataloguing Bug 7412: Pre-filling items in cataloguing 2012-09-03 17:01:58 +02:00
circ Bug 7986: Export issues for patron 2012-09-13 17:58:30 +02:00
debian Bug 8162: allow packages to work on Ubuntu Precise 2012-08-29 13:46:04 +02:00
docs Bug 7143: Adding Kathryn Tyree to the history and About page. 2012-09-13 17:54:47 +02:00
errors Housekeeping in errors scripts 2010-05-12 07:29:03 -04:00
etc Bug 8206 follow-up: Add Match index to MARC21 record.abs 2012-09-07 15:16:45 +02:00
install_misc Bug 8478 - Update Ubuntu related files Updated installation instructions, cleaned up ubuntu-pkg-check.sh, renamed ubuntu*.packages files more consistently, updated files to include missing libraries, corrected incorrect libraries (yaz3->yaz4, mysqlclient v16 to v18, dropped the dev version of the client). 2012-09-05 11:01:04 +02:00
installer Bug 4118 - Add Collection Code to Statistics Table 2012-09-13 18:42:46 +02:00
Koha Bug 8418: load repeating holidays hash correctly 2012-09-14 14:53:58 +02:00
koha-tmpl Bug 8071: link between bib and authorities with the authid 2012-09-14 13:29:14 +02:00
labels Bug 8442 - labels creator fixes for plack 2012-07-24 16:21:05 +02:00
members Bug 8017 reduce manipulation of GetAllIssues return 2012-09-13 18:51:45 +02:00
misc Bug 7417: Include see from references in bibliographic searches 2012-09-13 14:19:28 +02:00
offline_circ Bug 8006 - Loading offline circulation does not anonymize 2012-06-20 19:40:41 +02:00
opac Bug 6976 Close loophole allowing borrowers extra holds via opac 2012-09-14 15:22:46 +02:00
patroncards Bug 8315 - remove use C4::* version 2012-07-13 14:17:20 +02:00
reports Revert "Bug 8089: Use Koha::Cache for all caching" 2012-09-12 14:12:41 +02:00
reserve Bug 8675 Add hours and mins to renewal due date 2012-09-04 18:22:32 +02:00
reviews Bug 1623 - Provide view of approved comments 2011-12-27 18:26:50 +01:00
rotating_collections Bug 6553 : Follow up adding license statements 2011-08-13 19:54:38 +12:00
selenium Adding selenium tests for filterMembers 2009-09-30 11:30:37 +02:00
serials Bug 3456: Show internalnotes when receiving serials 2012-09-13 18:24:28 +02:00
services Bug 7178: Acquisition item creation improvement 2012-03-26 11:07:23 +02:00
skel 8268 Followup for creating var spool subdir. 2012-07-23 10:40:43 +02:00
sms Bug 2505 - Add commented use warnings where missing in the sms/ directory 2010-04-21 20:25:08 +12:00
suggestion Bug 8440: Dates does not appear in suggestions management 2012-07-24 17:04:32 +02:00
svc Merge remote-tracking branch 'origin/new/bug_7613' 2012-09-05 14:54:33 +02:00
t Bug 7417: Include see from references in bibliographic searches 2012-09-13 14:19:28 +02:00
tags Bug 8315 - remove use C4::* version 2012-07-13 14:17:20 +02:00
test Bug 5449: JSON malformed in Koha - Blocker with jQuery 1.4.x 2011-03-12 08:53:41 +13:00
tmp/modified_authorities
tools Bug 7986: Export issues for patron 2012-09-13 17:58:30 +02:00
virtualshelves Bug 7788: [SIGNED-OFF] Followup: GetShelf call in addbybiblio script corrected 2012-05-22 12:06:26 +02:00
xt Bug 8470: remove depreciated H:T:P test 2012-07-26 14:53:13 +02:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap 7439 Mailmap for master 2012-01-27 12:27:58 +01:00
about.pl Bug 8641 - Add information warning about log-in as root user to About->System information 2012-09-13 18:56:31 +02:00
changelanguage.pl Bug 6755 Problems with switching languages 2011-09-23 09:47:09 +12:00
edithelp.pl Bug 8622: Fix theme fallback 2012-09-05 11:39:14 +02:00
fix-perl-path.PL
help.pl Bug 6628 : Stopping a potential vulnerability 2011-11-28 10:05:58 +01:00
INSTALL Bug 7759, update of install files to use background indexing (and some whitespace tidy) 2012-04-20 16:11:52 +02:00
install-CPAN.pl Bug 5370: Fix all the references to koha.org 2010-11-08 09:41:49 +13:00
INSTALL.debian Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.fedora7 Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.opensuse Bug 7759, update of install files to use background indexing (and some whitespace tidy) 2012-04-20 16:11:52 +02:00
INSTALL.ubuntu Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.ubuntu.12.04 Bug 8478 - Update Ubuntu related files Updated installation instructions, cleaned up ubuntu-pkg-check.sh, renamed ubuntu*.packages files more consistently, updated files to include missing libraries, corrected incorrect libraries (yaz3->yaz4, mysqlclient v16 to v18, dropped the dev version of the client). 2012-09-05 11:01:04 +02:00
INSTALL.ubuntu.lucid Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
koha_perl_deps.pl Bug 8485 - Make koha_perl_deps.pl batch friendly Added a -b flag for brief which outputs only the perl library name (Foo::BaR), and added a -r flag for required which filters the list to required=Yes perl libraries. 2012-08-31 17:35:49 +02:00
kohaversion.pl Bug 4118 follow-up DBRev number 2012-09-13 18:51:08 +02:00
LICENSE Update LICENSE with a fresh copy from upstream. This updates the FSF address, and refers to the LGPL with its current name, and changes a few other minor things of the typographical sort. No semantic changes. 2010-03-16 20:17:48 -04:00
mainpage.pl Bug 6875 cleaning mainpage.pl 2012-02-15 14:58:31 +01:00
Makefile.PL Bug 8268: Add database dump to export tool 2012-07-12 17:40:21 +02:00
MANIFEST.SKIP
README updated links in README 2010-05-24 08:14:16 -04:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
rewrite-config.PL Bug 8268 follow-up: rewrite config correctly 2012-08-28 18:02:42 +02:00

README 

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 2 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/