Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/tools
History
Nick Clemens 2dd1984044 Bug 26784: Silence warns about comparing undefined values for MARC modification templates 
This patch simply checks if conditionals are defined before comparing

We don't need to check actions because you cannot save an action without an action :-)

To test:
1 - Define several actions for a MARC modification template
2 - Ensure you have actions with no conditionals
3 - Tail the intranet logs
4 - Browse to Tools->MARC modification templates
5 - Click 'Edit actions' for the template you setup above
6 - Note warns like:
    [2020/10/22 12:30:18] [WARN] Use of uninitialized value in string eq at /kohadevbox/koha/tools/marc_modification_templates.pl line 127.
7 - Apply patch
8 - Restart all the things
9 - Edit actions again and note no more warns

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2020-10-26 00:14:41 +01:00
..
csv-profiles MT2116: Addons to the CSV export 2010-02-17 07:51:33 -05:00
quotes Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
access_files.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
ajax-inventory.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
automatic_item_modification_by_age.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
background-job-progress.pl Bug 20017: use Modern::Perl in Tools perl scripts 2018-02-05 09:46:45 -03:00
batch_delete_records.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
batch_extend_due_dates.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
batch_record_modification.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
batch_records_ajax.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
batchMod.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cleanborrowers.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
copy-holidays.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
csv-profiles.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
exceptionHolidays.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
export.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
holidays.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
import_borrowers.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
inventory.pl Bug 23114: Inventory: allow to scan barcodes 2020-10-01 10:33:10 +02:00
koha-news.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
letter.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
manage-marc-import.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
marc_modification_templates.pl Bug 26784: Silence warns about comparing undefined values for MARC modification templates 2020-10-26 00:14:41 +01:00
modborrowers.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
newHolidays.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
overduerules.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
picture-upload.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
problem-reports.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
quotes-upload.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
quotes.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
scheduler.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
showdiffmarc.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
stage-marc-import.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
stockrotation.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
tools-home.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
upload-cover-image.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
upload-file.pl Bug 17501: Rename Upload to Uploader 2017-01-20 14:20:06 +00:00
upload.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
viewlog.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00