Koha/koha-tmpl/opac-tmpl/bootstrap/en/modules
David Cook 44366c0985
Bug 32302: Hide "ISBN" label when no ISBN data when sending list
There is a logic mistake in the opac-sendshelf.tt template where
we test if the "ISBN" key exists in the "BIBLIO_RESULT" hash when
we should really be testing if the arrayref returned by "ISBN" is
empty or not, since that "ISBN" key always exists and contains at least
an empty arrayref.

Test plan:
1. Apply patch and restart your Koha Starman
2. Create a public list containing records with 020 MARC fields and
records without 020 MARC fields
3. View the list in the OPAC
4. Click "Send list" and email it to yourself
5. Note that only records with 020 MARC fields with show "ISBN:"
in the email output

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-12-13 09:23:49 -03:00
..
clubs
errors
sci
sco Bug 31488: Update Max checkout text 2022-09-07 12:06:08 -07:00
svc
ilsdi.tt Bug 30944: Undo change to ILS-DI documentation 2022-10-03 13:44:11 -03:00
maintenance.tt Bug 30733: Undo some <span> additions that don't yield good strings 2022-06-17 10:16:43 -03:00
opac-account-pay-error.tt Bug 30733: Simplify translatable strings 2022-06-17 10:16:34 -03:00
opac-account.tt
opac-addbybiblionumber.tt Bug 30566: Incorporate link handling in OPAC's biblio-title include 2022-07-05 09:57:25 -03:00
opac-advsearch.tt Bug 31654: Hide non-public libraries from MastheadLibraryPulldown (bug_31654_hide_nonpublic_libs) 2022-11-04 19:24:14 -03:00
opac-alert-subscribe.tt Bug 30733: Simplify translatable strings 2022-06-17 10:16:34 -03:00
opac-auth-detail.tt Bug 29897: Don't display empty li 2022-08-09 10:58:49 -03:00
opac-auth-MARCdetail.tt
opac-auth.tt Bug 31378: Rename Auth Provider to Identity Provider and add Client.t tests 2022-11-08 14:39:51 -03:00
opac-authorities-home.tt
opac-authoritiessearchresultlist.tt Bug 30036: Allow XSLT for authority results view in OPAC 2022-10-27 09:54:35 -03:00
opac-basket.tt
opac-blocked.tt
opac-browse.tt
opac-browser.tt
opac-course-details.tt
opac-course-reserves.tt
opac-curbside-pickups.tt Bug 31261: Introduce flatpickr-futureinclusive 2022-11-14 09:15:51 -03:00
opac-detail.tt Bug 31543: (follow-up) Use url filter for opac components search 2022-11-16 15:57:32 -03:00
opac-discharge.tt
opac-downloadcart.tt
opac-downloadshelf.tt
opac-full-serial-issues.tt Bug 30733: Simplify translatable strings 2022-06-17 10:16:34 -03:00
opac-holdshistory.tt Bug 22456: (QA follow-up) Consider cancellation requested as cancelled in OPAC 2022-07-29 15:28:45 -03:00
opac-ics.tt Bug 30733: Undo <span> in an ICS calendar file 2022-06-17 10:16:42 -03:00
opac-idref.tt
opac-illrequests.tt
opac-imageviewer.tt Bug 30566: Incorporate link handling in OPAC's biblio-title include 2022-07-05 09:57:25 -03:00
opac-ISBDdetail.tt
opac-issue-note.tt
opac-library.tt Bug 31775: Template cleanup 2022-10-17 08:25:56 -03:00
opac-main.tt Bug 31378: Rename Auth Provider to Identity Provider and add Client.t tests 2022-11-08 14:39:51 -03:00
opac-MARCdetail.tt
opac-memberentry-update-submitted.tt
opac-memberentry.tt Bug 10950: (QA follow-up) Fix typo in hidden check in OPAC patron form 2022-10-03 15:01:34 -03:00
opac-messaging.tt Bug 31743: Change condition for messaging tab 2022-11-04 20:01:13 -03:00
opac-mymessages.tt
opac-news-rss.tt
opac-opensearch.tt Bug 32114: Add missing html_helpers.inc 2022-11-09 10:03:34 -03:00
opac-overdrive-search.tt Bug 31040: jsTree image being used outside of jsTree plugin 2022-07-05 09:18:20 -03:00
opac-page.tt Bug 15326: Using AdditionalContents for custom pages on OPAC 2022-08-16 15:42:24 -03:00
opac-passwd.tt Bug 30733: Simplify translatable strings 2022-06-17 10:16:34 -03:00
opac-password-recovery.tt Bug 30733: Simplify translatable strings 2022-06-17 10:16:34 -03:00
opac-patron-consent.tt
opac-privacy.tt
opac-readingrecord.tt Bug 21381: (QA follow-up) Add missing filter 2022-11-04 19:01:56 -03:00
opac-recall.tt Bug 30733: Split strings differently 2022-06-17 10:16:44 -03:00
opac-recalls.tt Bug 31146: Fix unclosed table element 2022-07-18 10:21:51 -03:00
opac-recordedbooks-search.tt Bug 31040: jsTree image being used outside of jsTree plugin 2022-07-05 09:18:20 -03:00
opac-registration-confirmation.tt
opac-registration-email-sent.tt
opac-registration-invalid.tt
opac-reportproblem.tt
opac-request-article.tt Bug 31294: Show "Required" label on mandatory fields 2022-08-16 14:32:21 -03:00
opac-reserve.tt Bug 32185: Fix template typo in opac-reserve.pl 2022-11-14 09:18:19 -03:00
opac-reset-password.tt Bug 31483: Close <ol> tag properly on password reset page 2022-09-07 13:23:53 -07:00
opac-restrictedpage.tt
opac-results.tt Bug 31333: (follow-up) Handle anonymous patrons making suggestions 2022-10-04 08:44:26 -03:00
opac-retrieve-file.tt
opac-review.tt
opac-routing-lists.tt
opac-search-history.tt Bug 30570: Replace the use of jQueryUI tabs in OPAC templates 2022-07-20 10:02:21 -03:00
opac-sendbasket.tt Bug 31316: (QA follow-up) Remove stray template close tag 2022-08-09 12:04:11 -03:00
opac-sendbasketform.tt
opac-sendshelf.tt Bug 32302: Hide "ISBN" label when no ISBN data when sending list 2022-12-13 09:23:49 -03:00
opac-sendshelfform.tt
opac-serial-issues.tt Bug 30992: Improve translatability for 'for' 2022-08-05 11:52:50 -03:00
opac-shareshelf.tt
opac-shelves-rss.tt
opac-shelves.tt Bug 7960: Add class to item type descriptions so they can be hidden with CSS 2022-10-24 17:27:50 -03:00
opac-showmarc.tt
opac-showreviews-rss.tt
opac-showreviews.tt Bug 30566: Incorporate link handling in OPAC's biblio-title include 2022-07-05 09:57:25 -03:00
opac-suggestions.tt Bug 20207: Don't show search options when no suggestions show 2022-11-14 09:21:14 -03:00
opac-tags.tt Bug 30566: Incorporate link handling in OPAC's biblio-title include 2022-07-05 09:57:25 -03:00
opac-tags_subject.tt
opac-topissues.tt
opac-user.tt Bug 7960: Add class to item type descriptions so they can be hidden with CSS 2022-10-24 17:27:50 -03:00