Koha/misc
Nick Clemens c7ae33f60c Bug 25683: Fix grouping of results
DBIX doesn't seem to work as I expected - if trying to group by we can only
get the columns we grouped by, otherwise the queries are much more complicated
and come out wrong

This patch removes the 'amountoutstanding' from the query. Note that we do return patron
object, however, to access all the columns we must discard_changes (or refetch)

Also fixes a typo 'verbosse'

To test:
1 - charge a $1 fine to a patron
2 - pay off the fine
3 - perl misc/cronjobs/update_patrons_category.pl -f J -t J -fu=5 -v
4 - Note the patron is returned twice
5 - export DBIC_TRACE=1
6 - repeat 3 - view the SQL query and see how odd it is
7 - Apply this patch
8 - repeat 3 - simpler query
9 - patron returned only once

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2020-08-06 11:37:07 +02:00
..
admin Bug 21395: Fix misc/admin/koha-preferences 2020-06-29 15:43:41 +02:00
bin Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
cronjobs Bug 25683: Fix grouping of results 2020-08-06 11:37:07 +02:00
devel Bug 25511: Add POD for --force 2020-07-20 17:45:31 +02:00
interface_customization Bug 23148: Replace Bridge icons with transparent PNG files 2020-07-20 16:16:37 +02:00
load_testing Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
maintenance Bug 25955: Fix getting index_name 2020-07-22 10:17:53 +02:00
migration_tools Bug 23696: take deleted biblios into account when building oai sets 2020-07-24 14:09:30 +02:00
release_notes Bug 25642: Fix description of new feature in update_dbix_class_files.pl 2020-06-15 10:30:01 +02:00
search_tools Bug 23137: Move cache flushing to the method 2020-04-29 17:02:15 +01:00
translator Bug 25922: Fix typo 'arial-label' -> 'aria-label' 2020-07-20 17:45:31 +02:00
add_date_fields_to_marc_records.pl Bug 22509: (RM follow-up) Add use of Koha::Script base class 2019-06-24 15:08:33 +01:00
batchCompareMARCvsFrameworks.pl Bug 22600: Set 'commandline' interface appropriately 2019-04-10 19:43:11 +00:00
batchdeletebiblios.pl Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
batchDeleteUnusedSubfields.pl Bug 22600: Set 'commandline' interface appropriately 2019-04-10 19:43:11 +00:00
batchImportMARCWithBiblionumbers.pl Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls 2019-07-15 11:28:08 +01:00
batchRebuildBiblioTables.pl Bug 24827: Standardise on 'UTF-8' as the encoding name 2020-03-16 14:45:39 +00:00
batchRebuildItemsTables.pl Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls 2019-07-15 11:28:08 +01:00
batchRepairMissingBiblionumbers.pl Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
check_sysprefs.pl Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
commit_file.pl Bug 17845: Adjust few other occurrences 2020-03-10 15:18:28 +00:00
export_borrowers.pl Bug 22600: Set 'commandline' interface appropriately 2019-04-10 19:43:11 +00:00
export_records.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
exportauth.pl Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
import_patrons.pl Bug 23473: Allow overwrite of passwords during import 2020-03-27 12:21:59 +00:00
koha-install-log Bug 17851: Add Elasticsearch config to koha-conf.xml - Add missing entries to koha-install-log 2019-10-07 14:09:10 +01:00
kohalib.pl
link_bibs_to_authorities.pl Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
load_yaml.pl Bug 24883: (RM follow-up) Use Koha::Script 2020-03-27 12:12:31 +00:00
mod_zebraqueue.pl Bug 22600: Set 'commandline' interface appropriately 2019-04-10 19:43:11 +00:00
perlmodule_ls.pl
perlmodule_rm.pl Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
recreateIssueStatistics.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
sax_parser_print.pl Bug 17626 (QA followup) 2016-11-22 11:29:07 +00:00
sax_parser_test.pl
sip_cli_emulator.pl Bug 22540: (QA follow-up) fixes 2019-10-08 14:33:34 +01:00
stage_file.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
z3950_responder.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00