Koha/C4
Joe Atzberger e8908c2f97 Returns reworking to handle empty GetItemIssue
Code cannot rely on issueinformation being populated.

Note there is room for better efficiency to have AddReturn also provide the
itemnumber (where existing) so that GetItemnumberFromBarcode is not called
at both levels.  Unfortunately there is discrepancy between this idea (for
efficiency) and the stated purpose of the $iteminformation object returned,
since $iteminformation is specifically the info from the issues table and
MUST be empty when the item was not in fact issued.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-24 09:44:39 -05:00
..
AuthoritiesMarc added C4/AuthoritesMarc/*.pm missed in previous patch 2008-01-04 19:08:30 -06:00
Barcodes bug 2509: fix file permissions 2008-08-21 18:55:02 -05:00
ClassSortRoutine bug 2505: enable warnings in call number normalization modules 2009-06-07 20:09:23 -05:00
External bug 3219: handle variation in Amazon responses 2009-05-27 07:06:20 -05:00
Form bug 3222: moved messaging preference editing 2009-05-22 13:20:56 -05:00
Heading bug 2479: allow MARC21 bib 440 to link to authorities 2008-08-06 14:49:55 -05:00
Members Allow option to preserve Extended Attributes on patron import update. 2009-05-28 06:50:39 -05:00
Output New framework for AJAX services 2009-05-14 07:29:18 -05:00
Reports Fix bug 3330 - Report notes modification 2009-06-15 12:43:18 -05:00
Search FRBR: added OPAC search result grouping option 2008-02-11 16:35:17 -06:00
SIP Functional SIP run and shutdown scripts. Update example SIPconfig.xml 2009-06-24 09:00:50 -05:00
tests Patch from Galen Charlton, removing $Id$ $Log$ and $Revision$ from files 2007-10-18 20:22:01 -05:00
VirtualShelves (bug #1578) change the shelf COinS support 2009-05-11 19:12:28 -05:00
Accounts.pm bug: chargelostitem() didn't unset onloan on the item record. 2008-10-05 21:01:24 -05:00
Acquisition.pm clean up redundant test 2009-05-21 09:00:52 -05:00
Auth.pm Use strftime to format sessionlog times 2009-06-15 12:43:28 -05:00
Auth_with_ldap.pm bug 2726: updated doc to explain auth_by_bind option 2009-05-21 14:27:27 -05:00
AuthoritiesMarc.pm Moved some variable definitions out of conditionals 2009-05-07 17:08:16 -05:00
BackgroundJob.pm C4 - BEGIN blocks and 1; __END__ for modules 2008-01-07 20:02:18 -06:00
Barcodes.pm bug 2509: fix file permissions 2008-08-21 18:55:02 -05:00
Biblio.pm fix permissions error introduced in prior patch 2009-05-28 18:47:01 -05:00
Bookfund.pm (bug #3193) fix the comtd value in acqui-home.pl 2009-05-07 16:42:03 -05:00
Bookseller.pm Minor bug fix Documentation update : 3039 2009-03-27 18:36:57 -05:00
Boolean.pm bug 2505: turn on warnings in seven modules 2009-06-07 20:09:16 -05:00
Branch.pm Correct POD and misleading variable names from copy/paste laziness 2009-06-19 06:09:53 -05:00
Breeding.pm bug 2505: enable warnings in C4::Breeding 2009-06-07 20:09:25 -05:00
Calendar.pm Bug 3268: Adds the ability to edit the description of a holiday. 2009-06-03 13:26:40 -05:00
Category.pm remove editor settings 2009-02-04 14:47:42 -06:00
Charset.pm bug 2505: turn on warnings in seven modules 2009-06-07 20:09:16 -05:00
Circulation.pm Returns reworking to handle empty GetItemIssue 2009-06-24 09:44:39 -05:00
ClassSortRoutine.pm bug 2505: enable warnings in call number normalization modules 2009-06-07 20:09:23 -05:00
ClassSource.pm bug 2505: enable warnings in call number normalization modules 2009-06-07 20:09:23 -05:00
Context.pm Remove unused variable and add FIXME. 2009-06-24 09:15:58 -05:00
Dates.pm Bug 2842: ->regexp('syspref') failed for users of iso dateformat. 2009-01-06 20:24:46 -06:00
Debug.pm C4::Debug - should resolve conflict w/ CGI upload. Debug no longer uses CGI. 2008-03-16 08:32:20 -05:00
Heading.pm Porting SimpleSearch return changes to all code calling it. 2008-04-17 05:52:45 -05:00
ImportBatch.pm bug 2505: enable warnings in C4::ImportBatch and C4::Matcher 2009-06-07 20:09:19 -05:00
Input.pm bug 2505: enable warnings in C4/Input.pm 2009-06-07 20:09:20 -05:00
Installer.pm Bug 2775: adding method to clean syspref cache in C4::Context 2008-11-11 15:59:00 -06:00
ItemCirculationAlertPreference.pm remove editor settings 2009-02-04 14:47:42 -06:00
Items.pm additional cleanup in GetItemsInfo() 2009-06-07 14:32:58 -05:00
ItemType.pm remove editor settings 2009-02-04 14:47:42 -06:00
Koha.pm use Memoize to cache results of GetAuthorisedValues 2009-06-19 05:56:29 -05:00
Labels.pm Bug 2500 Tweaking DDCN Split for Hyphenated Volumn Numbers 2009-05-27 10:45:36 -05:00
Languages.pm Bugfix 3176 - Browser selected languages are not use by OPAC 2009-05-11 09:13:24 -05:00
Letters.pm Bug 3350 - fail on queued emails w/ no address 2009-06-24 08:43:45 -05:00
Log.pm bug 2505: enable warnings in C4::Log 2009-06-07 20:09:24 -05:00
Maintainance.pm rel_3_0 moved to HEAD (introducing new files) 2007-03-09 15:34:17 +00:00
Matcher.pm bug 2505: enable warnings in C4::ImportBatch and C4::Matcher 2009-06-07 20:09:19 -05:00
Members.pm Return amount for CREDITS, POD rework. 2009-06-24 09:31:45 -05:00
Message.pm remove editor settings 2009-02-04 14:47:42 -06:00
NewsChannels.pm bug 3303: removed references to news_channels* 2009-06-07 20:09:18 -05:00
Output.pm bug 2505: turn on warnings in seven modules 2009-06-07 20:09:16 -05:00
Overdues.pm checkoverdues should not require $dbh 2009-06-24 09:35:12 -05:00
Print.pm Bug 2900: fix GetPendingIssues. 2009-01-08 11:08:27 -06:00
Record.pm fixed MODS biblio export on a "standard" install 2008-04-01 06:46:08 -05:00
Reports.pm removing comments 2009-05-28 17:32:39 -05:00
Reserves.pm bug 3222: tweak sending of hold filled notification 2009-05-22 13:20:57 -05:00
Review.pm bug 2505: turn on warnings in seven modules 2009-06-07 20:09:16 -05:00
Scheduler.pm Bug 2400 [2/18]: fixing pod syntax in C4/Scheduler.pm 2008-08-12 19:39:23 -05:00
Scrubber.pm Unescape Comment, now that we trust Scrubber to block bad markup. 2008-05-29 06:30:51 -05:00
Search.pm bug 3263: Staff Search Results Interface Changes 2009-05-28 06:42:20 -05:00
Serials.pm removing disused C4::Serials functions 2009-06-09 09:31:12 -05:00
Service.pm Small documentation improvement for C4::Service 2009-05-27 10:08:36 -05:00
SMS.pm Bug 2400 [5/18]: fixing pod syntax in C4/SMS.pm 2008-08-12 19:40:03 -05:00
Stats.pm bug 2505: turn on warnings in seven modules 2009-06-07 20:09:16 -05:00
Suggestions.pm fix for 2997 : superlibrarian's ability to edit item/patron home branch affected if all other privileges are selected 2009-05-28 17:06:46 -05:00
Tags.pm Bug 2279: TagsModeration effectiveness restored. 2008-07-22 15:45:04 -05:00
UploadedFile.pm C4 - BEGIN blocks and 1; __END__ for modules 2008-01-07 20:02:18 -06:00
Utils.pm Big LDAP changes, module test for Context.pm, still more yet to come. 2007-12-04 17:27:06 -06:00
VirtualShelves.pm bug 2505: turn on warnings in seven modules 2009-06-07 20:09:16 -05:00
XISBN.pm Syndetics and Amazon bugfix enhancements 2009-03-27 17:23:51 -05:00
XSLT.pm bug 2505: turn on warnings in seven modules 2009-06-07 20:09:16 -05:00
Z3950.pm Z3950.pm - BEGIN block VERSION and vars related to export. 2008-01-07 20:02:50 -06:00