Koha/koha-tmpl/intranet-tmpl/prog/en/includes
Nicolas Legrand 47b32572d4 Bug 24412: Attach waiting reserve to desk
When an item is checked in and marked 'Waiting' or already 'Waiting'
and there is a desk attached to the session, the item is marked
waiting at the current desk of the current library.

The information is displayed on the OPAC and on the intranet. The
patron can then know at which desk he can retrieve his document.

Desk Management (Bug 13881) is now useful.

Test plan :

1. apply Bug 24201
2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl
3. Check out some document to someone
4. make another one reserve this document
5. check in the document
6. you can see the document is attach to the current library
7. create some desks and attach one to your session (see Bug 13881 and
Bug 24201)
8. cancel the preceding reserve and redo steps 3 to 5
9. you should see the document is waiting at the current library and
current desk on:
  a. the intranet document request page
  b. the intranet borrower holds tab
  c. the item list where the document is listed on the bibliographic
    details
  d. the borrower's OPAC holds tab.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Bug 24412: (follow-up) QA

Following Josef Moravec QA comments :

- rewrite Koha::Hold->desk according to Object Oriented Koha
Guidelines and use it to fetch desk name in various templates
- remove unused Desks.GetName
- Check for columns existence in db update

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Bug 24412: (follow-up) QA: useless change

Maybe it was a relic of something usefull... anyway
not anymore.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Bug 24412: (follow-up) Fix POD

Koha::Desk and not Koha::Library...

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2020-11-06 15:55:17 +01:00
..
catalogue Bug 26323: Retrieve the correct values for LOST, DAMAGED, LOC and CCODE 2020-09-28 16:09:10 +02:00
csv_headers Bug 25867: Label "Current location" as "Current library" and "Permanent location" as "Home library" 2020-08-18 15:48:37 +02:00
mana
modals Bug 25728: Create AV when adding a new item 2020-08-24 11:19:03 +02:00
str Bug 26334: Move translatable strings out of members-menu.inc into members-menu.js 2020-09-29 14:28:18 +02:00
virtualshelves/merge
about-team.inc Teams fixes 2020-05-22 11:40:08 +01:00
accounts.inc Bug 26398: Restore translations for credit/debit type dropdown 2020-11-03 10:57:35 +01:00
acquisitions-add-to-basket.inc
acquisitions-menu.inc Bug 26089: Add acquisitions-related reports to acquisitions sidebar menu 2020-10-01 10:32:15 +02:00
acquisitions-search.inc
acquisitions-toolbar.inc Bug 25002: JS Includes should be wrapped with template comments 2020-04-29 17:15:20 +01:00
additional-fields-display.inc
additional-fields-entry.inc
admin-items-search-field-form.inc
admin-menu.inc Bug 22343: Add CRUD page for SMTP servers 2020-10-02 10:54:40 +02:00
adv-search.inc
auth-finder-search.inc
authorities-search-results.inc Bug 12533: Improve authority search result display 2020-11-04 12:59:33 +01:00
authorities-search.inc
authorities-toolbar.inc
authorities.inc
authorities_js.inc Bug 26606: Correctly URI-encode query string in URL loaded after deleting an authority record 2020-10-26 00:16:14 +01:00
av-build-dropbox.inc Bug 18680: Add an empty entry by default to sort1/sort2 values in patron account 2020-04-20 12:28:04 +01:00
biblio-title-head.inc
biblio-title.inc Bug 23852: Merge biblio-title.inc and biblio-default-view.inc 2020-10-08 15:01:29 +02:00
biblio-view-menu.inc
blocked-fines.inc Bug 24098: Standardize Fines/Fees & Charges 2020-05-11 09:54:20 +01:00
blocking_errors.inc Bug 10921: Prevent an order from a closed basket to be edited 2020-09-18 11:49:29 +02:00
borrower_debarments.inc Bug 25744: Replace <i> with <em> in staff interface 2020-09-18 11:08:35 +02:00
branch-selector.inc
budget_planning.inc Bug 24636: (follow-up) - move 'by' into include file 2020-05-04 08:53:04 +01:00
budgets-active-currency.inc Bug 25744: replace <b> with <strong> in the staff interface 2020-09-18 11:08:35 +02:00
budgets-admin-search.inc
budgets-admin-toolbar.inc
calendar.inc Bug 26261: Split calendar.inc into include file and JavaScript file 2020-09-29 14:28:19 +02:00
cat-menu.inc
cat-search.inc Bug 26249: Set keep_text class correctly in cat-search.inc 2020-09-28 16:09:11 +02:00
cat-toolbar.inc Bug 26139: Centralize code for "Place hold" button (detail) 2020-08-25 11:31:49 +02:00
catalog-strings.inc Bug 26441: Move translatable strings out of catalog-strings.inc into catalog.js 2020-09-29 14:28:18 +02:00
cataloging-search.inc
cateditor-ui.inc Bug 17515: Order Z3950 server by rank and preserve ordering 2020-11-02 11:03:09 +01:00
cateditor-widgets-marc21.inc Bug 25002: JS Includes should be wrapped with template comments 2020-04-29 17:15:20 +01:00
category-out-of-age-limit.inc
chart.inc
checkin-search.inc
checkouts-table-footer.inc Bug 19351: Add items.copynumber to the checkouts table 2020-11-04 12:59:34 +01:00
checkouts-table.inc Bug 19351: Add items.copynumber to the checkouts table 2020-11-04 12:59:34 +01:00
circ-menu.inc Bug 23979: Remove final dot 2020-11-04 12:59:33 +01:00
circ-nav.inc Bug 24201: (QA follow-up) IndependentBranches 2020-08-07 16:54:40 +02:00
circ-patron-search-results.inc Bug 15400: Display date of birth and age more consistantly 2020-06-29 12:37:02 +02:00
circ-search.inc
cities-admin-search.inc Bug 25279: Use another var name for the filter 2020-05-12 11:40:07 +01:00
clubs-table.inc Bug 25282: (follow-up) More corrections 2020-04-29 16:20:24 +01:00
columns_settings.inc Bug 26234: Teach our KohaTable constructor the specific th classes 2020-08-19 08:24:04 +02:00
contracts-admin-search.inc
country-list.inc
currencies-admin-search.inc
datatables.inc Bug 24662: Remove global variables MSG_* from datatables.inc 2020-03-11 13:49:15 +00:00
date-format.inc
delimiter_text.inc
desks-admin-search.inc Bug 13881: Add desk management 2020-03-25 09:19:15 +00:00
doc-head-close-receipt.inc
doc-head-close.inc Bug 24661: (RM follow-up) Check lang is defined 2020-02-25 14:28:54 +00:00
doc-head-open.inc Bug 24732: Set DumpTemplateVars Dumper options for Indent and Sort 2020-03-02 10:08:31 +00:00
empty_line.inc
facets.inc Bug 26323: (QA follow-up) Fix syntax errors 2020-09-28 16:09:10 +02:00
filter-orders.inc Bug 26503: Add limit for standing orders to acq advanced search 2020-10-12 11:28:41 +02:00
form-blocks.inc
format_price.inc Bug 25002: JS Includes should be wrapped with template comments 2020-04-29 17:15:20 +01:00
greybox.inc Bug 25002: JS Includes should be wrapped with template comments 2020-04-29 17:15:20 +01:00
guided-reports-view.inc
header.inc Bug 24786: Allow setting a register for the session 2020-11-06 15:39:59 +01:00
holds_table.inc Bug 24412: Attach waiting reserve to desk 2020-11-06 15:55:17 +01:00
home-search.inc
html_helpers.inc Bug 24665: (QA follow-up) Fix selection default 2020-11-06 15:55:17 +01:00
i18n.inc Bug 26816: Chomp whitespace around i18n strings 2020-11-02 11:03:09 +01:00
ill-availability-table.inc Bug 23173: (follow-up) Fix QA script errors 2020-04-06 11:05:14 +01:00
ill-list-table-strings.inc Bug 25002: JS Includes should be wrapped with template comments 2020-04-29 17:15:20 +01:00
ill-list-table.inc
ill-toolbar.inc
installer-doc-head-close.inc
installer-intranet-bottom.inc Bug 25002: JS Includes should be wrapped with template comments 2020-04-29 17:15:20 +01:00
installer-strings.inc Bug 25002: JS Includes should be wrapped with template comments 2020-04-29 17:15:20 +01:00
intranet-bottom.inc Bug 24201: (follow-up) add desk choice with library choice 2020-08-07 16:54:40 +02:00
intranetstylesheet.inc
js-date-format.inc Bug 24980: (follow-up) return '' when date is null 2020-05-01 08:14:34 +01:00
js_includes.inc Bug 26439: Move cart-related strings out of js_includes.inc and into basket.js 2020-11-04 12:59:34 +01:00
keyboard_shortcuts.inc
labels-toolbar.inc
langmenu-staff-top.inc Bug 20168: Update of the OPAC bootstrap template to bootstrap v4 2020-09-09 14:13:03 +02:00
last-borrower.inc
letters-search.inc
member-alt-address-style.inc Bug 26538: Display cities list before input text 2020-10-14 11:47:57 +02:00
member-alt-contact-style.inc Bug 26538: Display cities list before input text 2020-10-14 11:47:57 +02:00
member-display-address-style.inc Bug 26666: (QA follow-up) Add 'USE raw' in template 2020-10-26 00:14:41 +01:00
member-display-alt-address-style.inc Bug 25070: Centralize member-display-alt-address-style 2020-06-15 11:53:36 +02:00
member-main-address-style.inc Bug 26538: Display cities list before input text 2020-10-14 11:47:57 +02:00
members-toolbar.inc Bug 25765: Replace LoginBranchname and LoginBranchcode with use of Branches template plugin 2020-07-23 11:17:27 +02:00
merge-record.inc
messaging-preference-form.inc Bug 25334: Add generic 'phone' message transport type 2020-11-05 15:24:20 +01:00
noadd-warnings.inc
onboarding_messages.inc
page-numbers.inc Bug 14715: (follow-up) Keep results per page setting when selecting facets and sorting results 2020-03-26 12:03:42 +00:00
password_check.inc Bug 23816: Fix patron edition 2020-09-10 09:57:53 +02:00
patron-age.inc Bug 15400: (follow-up) Remove line break 2020-06-29 12:37:02 +02:00
patron-article-requests.inc Bug 25744: Replace <i> with <em> in staff interface 2020-09-18 11:08:35 +02:00
patron-return-claims.inc
patron-search-box.inc
patron-search.inc Bug 17374: (follow-up) Remove spaces from include file 2020-03-10 15:18:29 +00:00
patron-title.inc Bug 25747: Don't display a comma when patron has no firstname 2020-06-24 14:31:37 +02:00
patron-toolbar.inc
patroncards-errors.inc Bug 24837: Rename selectbranchprinter.pl to set-library.pl 2020-03-24 11:07:22 +00:00
patroncards-toolbar.inc
patronfields.inc Bug 17374: (QA follow-up) Make search labels match with patron record 2020-03-10 15:18:29 +00:00
patrons-admin-search.inc
payments.inc
permissions.inc Bug 26718: Rename "reading history" to "checkout history" 2020-11-04 12:59:33 +01:00
popup-bottom.inc
pos-menu.inc Bug 25138: Terminology: Point of sale should use library instead of branch 2020-04-17 13:50:23 +01:00
prefs-admin-search.inc
prefs-menu.inc Bug 25630: (follow-up) Fix capitalization and terminology for system preferences 2020-09-02 12:05:33 +02:00
quotes-toolbar.inc
quotes-upload-toolbar.inc
relatives-issues-table.inc Bug 22468: Standardize on labelling ccode table columns as Collections 2020-04-15 12:32:49 +01:00
renew_results.inc Bug 23051: (QA follow-up) Missing curly and tabs and fix test 2020-03-06 10:03:41 +00:00
renew_strings.inc Bug 25717: Improve automatic renewal error messages 2020-07-20 17:45:31 +02:00
reports-menu.inc Bug 20415: add Koha.ArePluginsEnabled Template Toolkit method 2020-03-26 11:41:54 +00:00
reports-toolbar.inc Bug 26165: Fix duplication of large saved reports 2020-08-12 11:46:30 +02:00
resort_form.inc Bug 25014: Fix capitalization for "Call Number" in staff and OPAC sort options 2020-04-03 14:26:34 +01:00
rotating-collections-toolbar.inc
search_indexes.inc
select2.inc Bug 25727: (follow-up) Some style updates, JS i18n 2020-08-24 11:19:03 +02:00
serials-menu.inc Bug 26484: Add serials-related reports to serials sidebar menu 2020-10-01 10:32:15 +02:00
serials-search.inc
serials-toolbar.inc
slip-print.inc Bug 25002: JS Includes should be wrapped with template comments 2020-04-29 17:15:20 +01:00
stockrotation-toolbar.inc
subscriptions-search.inc
subtypes_unimarc.inc
suggestions-add-search.inc
timepicker.inc Bug 25133: (follow-up) Move changes to timepicker.inc 2020-05-04 13:45:31 +01:00
tools-item-action.inc
tools-menu.inc Bug 25627: Move OPAC problem reports from administration to tools 2020-06-15 11:53:36 +02:00
tools-nomatch-action.inc Bug 23236: Remove 'its items may still be processed' in action if no match is found 2020-03-18 08:41:35 +00:00
tools-overlay-action.inc
validator-strings.inc Bug 25002: JS Includes should be wrapped with template comments 2020-04-29 17:15:20 +01:00
vendor-menu.inc
virtualshelves-toolbar.inc
waiting_holds.inc Bug 24412: Attach waiting reserve to desk 2020-11-06 15:55:17 +01:00
wysiwyg-systempreferences.inc Bug 25862: Prevent TinyMCE to mangle local url links 2020-07-20 14:05:21 +02:00
xslt-handler.inc
z3950-admin-search.inc
z3950_search.inc Bug 26291: Move translatable strings out of z3950_search.inc into z3950_search.js 2020-09-29 14:28:19 +02:00