Owen Leonard
4a2befa3c7
This patch removes the definition of translatable strings out of templates and into the corresponding JavaScript file, using the new JS i81n function. To test: - Apply the patch and go to Serials -> New subscription - Click "Next" without filling out any fields. You should get two confirmations, "If you wish to claim late or missing issues you must link this subscription to a vendor. Click OK to ignore or Cancel to return and enter a vendor" and "You must choose or create a bibliographic record." - Manually enter a vendor number which doesn't exist and click "Next." Error: "The vendor does not exist." - Manually enter a record number which doesn't exist and click "Next." Error: "Bibliographic record does not exist!" - Select a valid vendor and bibliographic record and proceed to the next page. - Click "Test prediction pattern" without filling in any fields. Error: "Cannot test prediction pattern for the following reason(s): Frequency is not defined. - First publication date is not defined" - Click "Save subscription" without filling in any information. Error: "You must choose a first publication date." - Fill in a date and click "Save subscription." Error: "You must choose a subscription length or an end date." - Enter a frequency and subscription start date and click "Save subscription." Error: "Please click on 'Test prediction pattern' before saving subscription." - Click "Show advanced pattern" and then "Save subscription." Error: "You have modified the advanced prediction pattern. Please save your work or cancel modifications." Testing numbering patterns: - There are several strings related to setting and editing numbering patterns but I don't think they can be tested live while Bug 28012 is unfixed. Testing Mana integration: - To test Mana integration you must have Mana enabled, and a bibliographic record in your catalog which has an ISSN matching a record in Mana. You can go to "Search on Mana" from the Serials sidebar menu to locate a working record. - Add a subscription using the bibliographic record which will match a record in Mana. When you click "Next" you should see a message at the top of the page saying, "Searching for subscription in Mana Knowledge Base" - After a moment this message should be replaced with "Subscription found on Mana Knowledge Base: Show Mana results" - Clicking the "Show Mana results" should trigger a modal window with the heading "Results from Mana Knowledge Base." - Test the subscription add process using a bibliographic record which doesn't match anything in Mana. The message at the top of the page should read, "No subscription found on Mana Knowledge Base" TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/subscription-add.js for translation, e.g.: msgid "Next issue publication date is not defined" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> |
||
---|---|---|
.. | ||
pages | ||
acq.js | ||
acquisitions-menu.js | ||
additem.js | ||
addorderiso2709.js | ||
admin-menu.js | ||
ajax.js | ||
audio_alerts.js | ||
auth-finder-search.js | ||
automatic_item_modification_by_age.js | ||
background-job-progressbar.js | ||
basket.js | ||
basketgroup.js | ||
biblio_framework.js | ||
browser.js | ||
calendar.js | ||
cart.js | ||
cashup_modal.js | ||
catalog.js | ||
cataloging.js | ||
cataloging_additem.js | ||
categories.js | ||
charts.js | ||
checkouts.js | ||
circ-patron-search-results.js | ||
datatables.js | ||
desk_selection.js | ||
elasticsearch-mappings.js | ||
file-upload.js | ||
funds_sorts.js | ||
holds.js | ||
ill-availability-partner.js | ||
ill-availability.js | ||
ill-list-table.js | ||
item_search_fields.js | ||
letter.js | ||
localcovers.js | ||
mana.js | ||
marc_modification_templates.js | ||
marc_subfields_structure.js | ||
members-menu.js | ||
members.js | ||
merge-record.js | ||
messaging-preference-form.js | ||
offlinecirc.js | ||
onboarding.js | ||
register_selection.js | ||
rotating-collections.js | ||
select2.js | ||
serials-toolbar.js | ||
showpredictionpattern.js | ||
sms_providers.js | ||
staff-global.js | ||
subscription-add.js | ||
table_filters.js | ||
tools-menu.js | ||
viewlog.js | ||
xmlControlfield.js | ||
z3950_search.js |