Kyle M Hall 50bb8e96f1 Bug 23233: AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only ... The system preference AllowItemsOnHoldCheckout only affects SIP based checkouts. I believe we should rename it AllowItemsOnHoldCheckoutSIP so it matches AllowItemsOnHoldCheckoutSCO. We should also update the description as well. As far as I know AllowItemsOnHoldCheckout has never affected anything except SIP traffic. That does not preclude the addition of another AllowItemsOnHoldCheckout syspref that would affect the staff interface, but that would be an enhancement and is outside the scope of this bug report. Test Plan: 1) Test AllowItemsOnHoldCheckout via SIP 2) Apply this patch 3) Test AllowItemsOnHoldCheckoutSIP via SIP 4) Note there is no difference! 5) Note the syspref description has been update to mention SIP Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>		2019-12-16 11:08:52 +00:00
..
AuthoritiesMarc
Barcodes	Bug 21937: Syspref autoBarcode annual doesn't increment properly barcode	2019-04-19 14:32:36 +00:00
ClassSortRoutine
ClassSplitRoutine
Creators	Bug 23289: Quote new 'rows' MariaDB reserved word	2019-09-06 13:17:48 +01:00
External	Bug 22010: Check preferences for ebook integration	2019-04-30 11:42:51 +00:00
Form	Bug 16259: Replace CGI->param with CGI->multi_param in list context - part 2	2016-05-16 17:28:06 +00:00
Heading
ILSDI	Bug 17247: (follow-up) Terminology fix: Use Restricted instead of debarred	2019-10-15 14:11:03 +01:00
Installer	Bug 23068: (RM follow-up) Make Net::Netmask required	2019-11-06 12:12:09 +00:00
Labels	Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls	2019-07-15 11:28:08 +01:00
Linker	Bug 21450: Cache authorities search using term and auth_type	2019-05-30 10:13:38 +00:00
Members
OAI
Output
Patroncards	Bug 22429: Infinite loop in patron card printing	2019-03-15 11:59:28 +00:00
Reports	Bug 24164: Copy the letter for each email	2019-12-13 14:01:01 +00:00
Search
Serials
SIP	Bug 23233: AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only	2019-12-16 11:08:52 +00:00
Utils	Bug 20514: Use streetnumber when searching for patrons by address	2019-05-15 12:10:53 +00:00
Accounts.pm	Bug 23049: Capitalise type passed to add_debit for lost_item	2019-10-24 17:24:33 +01:00
Acquisition.pm	Bug 24002: Incorrect DATE value: '' in C4/Acquisition.pm	2019-11-12 13:50:23 +00:00
Auth.pm	Bug 22543: Prevent "back and refresh attack"	2019-11-27 11:30:18 +00:00
Auth_cas_servers.yaml.sample
Auth_with_cas.pm
Auth_with_ldap.pm	Bug 14570: Make it possible to add multiple guarantors to a record	2019-08-20 16:04:48 +01:00
Auth_with_shibboleth.pm	Bug 24199: (bug 23042 follow-up) Prevent t/Auth_with_shibboleth.t to fail randomly	2019-12-10 10:43:20 +00:00
AuthoritiesMarc.pm	Bug 23933: (bug 10132 follow-up) Fix commit_file.pl	2019-11-08 12:55:03 +00:00
BackgroundJob.pm
Barcodes.pm
Biblio.pm	Bug 24002: One more occurrence of datecancellationprinted	2019-11-12 13:50:27 +00:00
Bookseller.pm	Bug 24002: Incorrect DATE value: '' in C4/Bookseller.pm	2019-11-12 13:50:06 +00:00
Boolean.pm
Breeding.pm	Bug 22532: Remove Z39.50 random	2019-04-18 10:48:10 +00:00
Budgets.pm	Bug 10577: (QA follow-up) Remove tab chars	2019-03-28 12:46:14 +00:00
Calendar.pm
Charset.pm	Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls	2019-07-15 11:28:08 +01:00
Circulation.pm	Bug 24138: Fix calculation of suspension days when a limit is set	2019-12-10 16:14:50 +00:00
ClassSortRoutine.pm
ClassSource.pm
ClassSplitRoutine.pm
Context.pm	Bug 23068: Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy	2019-10-31 16:10:17 +00:00
Contract.pm
CourseReserves.pm	Bug 22142: Do not revert data if 'unchanged' was set	2019-08-13 11:22:13 +01:00
Creators.pm
Debug.pm
Heading.pm	Bug 21826: Remove strict and warning from Heading.pm	2019-01-25 20:13:41 +00:00
HoldsQueue.pm	Bug 11529: (RM follow-up) Fix missing comma in query	2019-08-05 17:25:08 +01:00
HTML5Media.pm
Images.pm	Revert "Bug 21987: Do not generate true color thumbnails if not needed"	2019-11-04 13:21:53 +00:00
ImportBatch.pm	Bug 18757: Problem when importing only items in MARC records	2019-10-29 12:17:38 +00:00
ImportExportFramework.pm
InstallAuth.pm
Installer.pm	Bug 23805: Add account_credit_types tables	2019-10-24 17:35:19 +01:00
ItemCirculationAlertPreference.pm
Items.pm	Bug 23233: AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only	2019-12-16 11:08:52 +00:00
Koha.pm	Bug 23768: Return invalid ISBN when searching with variations	2019-11-07 13:02:47 +00:00
Labels.pm
Languages.pm	Bug 18213: Add Template plugin and fix for C4/Languages	2019-03-28 15:57:32 +00:00
Letters.pm	Bug 23765: Do not display localized templates if TranslateNotices is off	2019-11-13 13:36:45 +00:00
Linker.pm
Log.pm	Bug 22600: Add 'interface' to accountlines	2019-04-10 19:43:11 +00:00
MarcModificationTemplates.pm	Bug 21831: Allow move all fields even if destination field is different	2019-05-23 14:50:57 +00:00
Matcher.pm	Bug 23324: Add an ISBN normalization routine	2019-08-16 12:26:48 +01:00
Members.pm	Bug 14570: Make it possible to add multiple guarantors to a record	2019-08-20 16:04:48 +01:00
Message.pm
NewsChannels.pm	Bug 24002: Incorrect DATE value: '00-00-0000' in NewsChannels.pm	2019-11-12 13:49:58 +00:00
Output.pm	Bug 23329: Move error page to its own subroutine	2019-11-27 11:30:19 +00:00
Overdues.pm	Bug 24075: Backdating a return to the exact due date and time results in the fine not being refunded	2019-11-22 15:08:21 +00:00
Patroncards.pm	Bug 16011: $VERSION - Remove the $VERSION init	2016-03-24 17:20:28 +00:00
Print.pm
Record.pm
Reports.pm
Reserves.pm	Bug 23964: (follow-up) We should check for only active holds when determining to set waiting	2019-11-25 16:38:16 +00:00
Ris.pm
RotatingCollections.pm
Scheduler.pm
Scrubber.pm	Bug 16011: $VERSION - Remove the $VERSION init	2016-03-24 17:20:28 +00:00
Search.pm	Bug 23663: Only process itemtype summary if using non-xslt opac results	2019-10-29 12:17:43 +00:00
Serials.pm	Bug 24002: Incorrect DATE value: '00-00-0000' in C4/Serials.pm	2019-11-12 13:50:17 +00:00
Service.pm
ShelfBrowser.pm	Bug 22445: Custom cover images - opac shelfbrowser	2019-10-22 15:02:48 +01:00
SMS.pm
SocialData.pm
Stats.pm	Bug 21683: Remove accountlines.accountno	2019-03-21 18:19:22 +00:00
Suggestions.pm	Bug 18743: Correct number of pending suggestions (acq home page)	2019-10-25 13:16:49 +01:00
Tags.pm
Templates.pm
TmplToken.pm
TmplTokenType.pm
TTParser.pm	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00
UsageStats.pm	Bug 23233: AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only	2019-12-16 11:08:52 +00:00
XISBN.pm	Bug 12537: Don't retrieve XISBN results for the same biblionumber	2019-07-15 11:27:59 +01:00
XSLT.pm	Bug 23414: Use effective_itemtype	2019-11-06 17:14:32 +00:00