Koha/koha-tmpl/intranet-tmpl/prog/en/includes
Jonathan Druart 551721f702 Bug 30055: Make patron searches use the REST API
This patch will rewrite some of our patron searches to make them use the
REST API routes (and so the powerful the DataTables wrapper which will
bring all the nice DT feature to filter, sort, etc.)

The patron searches we will take into account here are those that we use
to select a patron in a pop-up:
 * Guarantor
 * Suggestion's manager
 * Patron's card
 * Serial routing list
 * Users to notify when order is received
 * Manager of an acquisition basket
 * Owner and users of a fund

Regarding permissions there are two main problematics:
 * Filter a patron set by patrons having a
specific subpermissions (in case of adding a manager to a suggestion or
when we deal with acquisition and funds). We added a new
Koha::Patrons->filter_by_have_subpermission method that will take in
parameter a subpermission. To make thing transparent for the callers we
are adding new routes, like /suggestions/managers to list the possible
managers of suggestions.
 * Restrict/allow access to the default patron searches /patrons
We need to access it when a logged in patron does not have borrowers
permission.
Ideally we need a separate "search_borrowers" subpermissions but it's
considered outside the scope of this change.

For each patch you will take care of testing the different permissions
that are into effect (either for the logged in patron or the patrons
returned by the search).

The tables should contain the same columns as prior to this patch,
except for "categories" and "library". We have the filter on top of the
page and so we need to add them to the table as new columns if they
weren't there before.

Test plan (for this patch):
Search for guarantor and select

Test plan (for all patches):
Add/Select patrons from the correct place where you can search for
patrons, play extensively with the filters/pagination/etc

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2022-04-04 09:46:57 +02:00
..
background_jobs Bug 29797: Fix display of itemnumbers on the background job detail view 2022-01-21 21:34:51 -10:00
catalogue Bug 17748: Remove unecessary html filter 2022-03-24 14:22:10 -10:00
csv_headers Bug 17748: (follow-up) Remove availability column 2022-03-24 14:22:10 -10:00
mana Bug 26703: (follow-up) Reverse title for mana report search results 2021-04-21 11:16:35 +02:00
modals Bug 29519: Allow resolution of claims return at checkin 2022-02-14 21:41:38 -10:00
str Bug 6815: Capture member photo via webcam 2022-03-24 14:22:10 -10:00
virtualshelves/merge
about-team.inc Bug 28904: Fix typo and display 2021-11-02 16:50:01 +01:00
accounts.inc Bug 27946: (QA follow-up) Remove 'scan' terminology, requests may not be scans 2022-01-28 11:09:07 -10:00
acquisitions-add-to-basket.inc Bug 28079: Set focus to search box field when adding an order to basket 2021-10-21 10:21:50 +02:00
acquisitions-menu.inc Bug 27498: (follow-up) Update to display logic 2021-06-21 14:01:51 +02:00
acquisitions-search.inc Bug 28508: Use "Invoice number" instead of "Invoice no" on the invoice search filter 2021-06-21 14:01:51 +02:00
acquisitions-toolbar.inc
additional-fields-display.inc
additional-fields-entry.inc
admin-items-search-field-form.inc Bug 20689: (follow-up) Correct scope of template variables 2022-03-01 22:47:46 -10:00
admin-menu.inc Bug 14957: Feature hidden in menues if no other 'cagaloguing' permissions 2021-10-26 16:46:02 +02:00
adv-search.inc
auth-finder-search.inc Bug 26533: Fix 'is exactly' search for authorities 2021-04-21 10:51:29 +02:00
authorities-search-results.inc Bug 29965: (follow-up) Use a new class for the preview 2022-02-23 22:05:33 -10:00
authorities-search.inc Bug 28475: Fix searching all headings 2021-05-28 08:29:38 +02:00
authorities-toolbar.inc Bug 28542: Move new authority from Z39.50/SRU to a button 2021-06-21 10:10:01 +02:00
authorities.inc
authorities_js.inc
authority-detail-modal.inc Bug 29965: Preview MARC in authority search results 2022-02-23 22:05:33 -10:00
av-build-dropbox.inc
biblio-title-head.inc
biblio-title.inc
biblio-view-menu.inc Bug 19532: Recalls on intranet 2022-03-14 22:45:51 -10:00
blocked-fines.inc Bug 29309: Make 'Pay all fines' be 'Pay all charges' 2021-10-25 14:08:06 +02:00
blocking_errors.inc
borrower_debarments.inc Bug 29394: Remove flatpickr instantiations from most of the tt files 2021-11-22 11:48:45 +01:00
branch-selector.inc
budget_planning.inc
budgets-active-currency.inc
budgets-admin-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
budgets-admin-toolbar.inc
calendar.inc Bug 29552: Disable today for dates in the future 2022-01-13 16:37:33 -10:00
cat-menu.inc
cat-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
cat-toolbar.inc Bug 9565: Deleting a biblio should alert/fail if there are existent subscriptions 2021-12-10 21:15:30 -10:00
catalog-strings.inc Bug 9565: (follow-up) Deleting a biblio should alert/fail if there are existent subscriptions 2021-12-10 21:15:30 -10:00
cataloging-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
catalogue-search-box.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
cateditor-ui.inc Bug 26964: Newly created macros should be selected in the Advanced editor 2021-03-08 15:15:52 +01:00
cateditor-widgets-marc21.inc Bug 27739: Advanced editor should use DefaultCountryField008 preference 2021-04-16 12:28:17 +02:00
category-out-of-age-limit.inc
chart.inc
checkin-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
checkouts-table-footer.inc Bug 29459: Replace some missed datetimepickers in circulation templates with Flatpickr 2021-11-15 12:38:39 +01:00
checkouts-table.inc Bug 29519: Allow resolution of claims return at checkin 2022-02-14 21:41:38 -10:00
circ-menu.inc Bug 6815: Don't make an AJAX request to generate the modal 2022-03-24 14:22:10 -10:00
circ-nav.inc Bug 19532: Recalls on intranet 2022-03-14 22:45:51 -10:00
circ-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
cities-admin-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
clubs-table.inc Bug 28782: Use query param list instead of splitting elements using '/' 2022-03-03 16:11:50 -10:00
columns_settings.inc Bug 29218: Rename .hidden class for DT visibility 2021-10-28 12:20:12 +02:00
contracts-admin-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
country-list.inc
currencies-admin-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
datatables.inc
date-format.inc
delimiter_text.inc
desks-admin-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
doc-head-close-receipt.inc
doc-head-close.inc Bug 28091: Only show for logged in users 2021-05-12 17:39:36 +02:00
doc-head-open.inc
empty_line.inc
facets.inc Revert "Bug 26860: facets.inc refactor availability facet" 2021-08-16 12:24:58 +02:00
filter-orders.inc Bug 27287: Make note fields from orders history searchable 2021-10-21 12:24:04 +02:00
form-blocks.inc
format_price.inc
greybox.inc
guided-reports-view.inc Bug 28454: Add Koha version number to database schema link in reports 2021-09-29 12:47:33 +02:00
header.inc Bug 27699: Add register information to responsive staff interface header menu 2021-03-09 15:05:26 +01:00
holds_table.inc Bug 30266: Hide pickup location input on waiting hold 2022-03-22 10:17:34 -10:00
home-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
html_helpers.inc Bug 30178: (bugs 27526 and 28445 follow-up) Every librarian can edit every item with IndependentBranches on 2022-03-03 16:11:50 -10:00
i18n.inc
ill-availability-table.inc
ill-list-table-strings.inc
ill-list-table.inc
ill-toolbar.inc
installer-doc-head-close.inc Bug 28982: Use Flatpickr on onboarding pages 2021-11-03 15:40:53 +01:00
installer-intranet-bottom.inc Bug 29837: Remove JS error during installer 2022-01-21 21:34:51 -10:00
installer-strings.inc
intranet-bottom.inc
intranetstylesheet.inc
js-date-format.inc
js-patron-format.inc Bug 30055: Make patron searches use the REST API 2022-04-04 09:46:57 +02:00
js-patron-get-age.inc Bug 30059: Deal with timezones 2022-03-24 14:22:10 -10:00
js_includes.inc Bug 10902: (follow-up) Account for singleBranchMode 2021-08-16 11:55:56 +02:00
keyboard_shortcuts.inc
labels-toolbar.inc
langmenu-staff-top.inc
last-borrower.inc
letters-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
member-alt-address-style.inc Bug 28392: make streettype and B_streettype work with BorrowerUnwantedField 2021-09-09 10:59:38 +02:00
member-alt-contact-style.inc Bug 29213: Fix typo ol in member-alt-contact-style.inc 2021-10-15 11:34:26 +02:00
member-display-address-style.inc Bug 21794: (QA follow-up) Separate city and country with a comma 2021-09-09 10:59:38 +02:00
member-display-alt-address-style.inc Bug 21794: (QA follow-up) Separate city and country with a comma 2021-09-09 10:59:38 +02:00
member-main-address-style.inc Bug 28392: make streettype and B_streettype work with BorrowerUnwantedField 2021-09-09 10:59:38 +02:00
members-toolbar.inc Bug 28759: limit accessibility for "Manage API keys" 2021-09-30 09:19:02 +02:00
merge-record.inc
messaging-preference-form.inc Bug 28153: Add 'Hold reminder' messaging preference 2021-10-18 11:28:41 +02:00
noadd-warnings.inc
onboarding_messages.inc
page-numbers.inc
password_check.inc
patron-age.inc Bug 27717: Display date of birth even if the patron is under 1 2021-03-05 13:38:58 +01:00
patron-article-requests.inc Bug 29093: (QA follow-up) Adding two hover texts 2021-10-15 11:34:26 +02:00
patron-return-claims.inc Bug 27296: Return claims should be filtered by default to show unresolved claims 2021-11-03 15:40:52 +01:00
patron-search-box.inc
patron-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
patron-title.inc Bug 19532: Recalls on intranet 2022-03-14 22:45:51 -10:00
patron-toolbar.inc
patron_messages.inc Bug 29889: Incorrect library check in patron message deletion logic 2022-01-19 12:13:49 -10:00
patroncards-errors.inc Bug 28576: Update the maximum size of an image. 2022-02-14 21:41:38 -10:00
patroncards-toolbar.inc
patronfields.inc Bug 28438: Capitalization: Various corrections 2021-09-28 15:12:45 +02:00
patrons-admin-search.inc
permissions.inc Bug 19532: Database and installer stuff 2022-03-14 22:45:50 -10:00
popup-bottom.inc
pos-menu.inc Bug 27583: Proposed terminology changes 2021-07-26 12:46:32 +02:00
prefs-admin-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
prefs-menu.inc Bug 28438: Capitalization: Various corrections 2021-09-28 15:12:45 +02:00
recalls.inc Bug 19532: (RM follow-up) Fix status finished renamed fulfilled 2022-03-14 22:45:52 -10:00
relatives-issues-table.inc Bug 28047: Standardize: Call number, callnumber, Call no. etc. 2021-04-06 15:56:31 +02:00
renew_results.inc
renew_strings.inc
reports-menu.inc
reports-toolbar.inc Bug 29680: Change markup to correct button radius 2022-01-05 13:49:09 -10:00
resort_form.inc
rotating-collections-toolbar.inc
search_indexes.inc Bug 20463: (follow-up) Remove option from search templates 2021-10-25 14:08:06 +02:00
select2.inc
serials-menu.inc Bug 28719: Change somes links in the serials page to avoid them leading to nothing 2021-08-16 09:56:37 +02:00
serials-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
serials-toolbar.inc
slip-print.inc Bug 27282: fix all occurrences 2021-04-21 10:51:29 +02:00
stockrotation-toolbar.inc
subscriptions-search.inc
subtype_limits.inc Bug 22605: (QA follow-up) Make Braille search option stick 2022-03-24 14:22:10 -10:00
subtypes_unimarc.inc
suggestions-add-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
timepicker.inc
tools-item-action.inc
tools-menu.inc Bug 24387: Rename "News" with "Additional contents" 2021-08-16 11:55:55 +02:00
tools-nomatch-action.inc
tools-overlay-action.inc
transaction_types.inc Bug 27796: (QA follow-up) Missing filters 2021-04-16 12:28:17 +02:00
transfer_reasons.inc Bug 22569: (QA follow-up) Make 'reason' translatable 2021-03-11 11:51:40 +01:00
validator-strings.inc
vendor-menu.inc
virtualshelves-toolbar.inc
waiting_holds.inc Bug 27868: Add expiration date to holds awaiting pickup 2022-01-28 11:09:07 -10:00
wysiwyg-systempreferences.inc Bug 26949: Upgrade TinyMCE in the staff interface from 5.0.16 to 5.9.2 2021-10-05 10:58:13 +02:00
xslt-handler.inc
z3950-admin-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
z3950_search.inc