Owen Leonard 57221e083b Bug 24010: Number of issues to display to staff accepts non-integer values ... This patch modifies the subscription entry form so that it will perform a check on the staffdisplaycount and opacdisplaycount fields before proceding to the second step. It verifies that the values are numeric. The changes are made in the style of the existing form validation, which should be rewritten to either use the validation plugin or to peform checks in a way that all checks are run before warning the user. However, this smaller change will work in the meantime. To test, apply the patch and go to Serials -> New subscription. - Fill out the form with at least the required fields, but put something other than a number if the "Number of issues to display to staff" and "Number of issues to display to the public" with non-numeric characters. - When you click the "Next" button you should get an error message, "Number of issues to display to staff must be a number." - Correct the issues to display to staff field and submit again. - You should get a different error message, "Number of issues to display to the public must be a number." - Correct this field and you should be able to proceed to the next step. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>		2022-07-05 10:57:16 -03:00
..
pages	Bug 29648: Fix occurrences of GetColumns	2022-04-27 11:20:45 -10:00
acq.js	Bug 28082: Add acquisitions toolbar to vendors on vendor search page	2022-05-10 15:17:17 -10:00
acquisitions-menu.js	Bug 26019: Koha should set SameSite attribute on cookies	2022-04-13 15:55:38 +02:00
additem.js	Bug 29895: Fix 'add multiple items' button on neworderempty	2022-01-31 21:55:40 -10:00
addorderiso2709.js	Bug 27982: (follow-up) Address another missing instance	2021-04-06 15:56:31 +02:00
admin-menu.js
ajax.js	Bug 26237: Move translatable strings out of preferences.tt and into JavaScript files	2020-09-29 14:28:18 +02:00
audio_alerts.js	Bug 26225: Move translatable strings out of audio_alerts.tt and into audio_alerts.js	2020-09-29 14:28:18 +02:00
auth-finder-search.js
authorities-detail-modal.js	Bug 29965: (QA follow-up) Fix translation issue in moved JS code	2022-02-23 22:05:33 -10:00
authtype.js	Bug 13952: (follow-up) JS translatability, clean warns, other	2022-04-04 16:23:46 +02:00
automatic_item_modification_by_age.js	Bug 22827: Add age dependency on other fields than dateaccessioned	2022-04-08 15:49:16 +02:00
background-job-progressbar.js
basket.js	Bug 26019: (follow-up) Set SameSite attribute on Cart cookies	2022-04-13 15:55:38 +02:00
basketgroup.js
biblio_framework.js	Bug 26225: Move translatable strings out of biblio_framework.tt and into biblio_framework.js	2020-09-29 14:28:18 +02:00
browser.js	Bug 20529: Remove other occurrences of decodeURIComponent from browser.js	2021-09-01 15:53:41 +02:00
calendar.js	Bug 30514: Error in date format check following datepicker removal	2022-05-06 10:33:10 -10:00
cart.js	Bug 28782: Use query param list instead of splitting elements using '/'	2022-03-03 16:11:50 -10:00
cashup_modal.js	Bug 26274: Update register.tt to use the API	2021-02-12 12:33:41 +01:00
catalog.js	Bug 25251: (follow-up) Remove alertNoItems	2022-03-24 14:22:10 -10:00
cataloging.js	Bug 30376: Fix missing mandatory date acquired error on item save	2022-04-13 15:55:39 +02:00
cataloging_additem.js	Bug 29648: Add item - broken FIXME	2022-04-27 11:20:43 -10:00
categories.js	Bug 30864: Add validation to password_expiry_days	2022-06-06 13:49:00 -03:00
charts.js
checkouts.js	Bug 31087: Prevent stringification of null in return claims	2022-07-01 16:03:34 -03:00
datatables.js	Bug 30607: Don't overload our default initComplete	2022-05-06 10:33:10 -10:00
desk_selection.js	Bug 24201: (follow-up) add desk choice with library choice	2020-08-07 16:54:40 +02:00
elasticsearch-mappings.js	Bug 30584: Fix ES mapping creation	2022-04-25 10:00:22 -10:00
file-upload.js
funds_sorts.js
holds.js	Bug 28723: Replace "No title" by an empty string	2022-06-02 09:44:39 -03:00
ill-availability-partner.js	Bug 23173: (follow-up) Display available partners	2020-04-06 11:04:59 +01:00
ill-availability.js	Bug 29648: ILL - no change	2022-04-27 11:20:44 -10:00
ill-list-table.js	Bug 29648: ILL - no change	2022-04-27 11:20:44 -10:00
item_search_fields.js	Bug 20689: (follow-up) Make it possible to add capital letter subfields to item search fields	2022-03-01 22:47:46 -10:00
letter.js	Bug 30709: 'Insert' button in notices editor not adding selected placeholders to notice	2022-05-06 10:33:10 -10:00
localcovers.js	Bug 25031: (QA follow-up) Improve handling of one or fewer images	2020-07-24 14:09:30 +02:00
mana.js
marc_modification_templates.js	Bug 29648: Fix occurrences of GetColumns	2022-04-27 11:20:45 -10:00
marc_subfields_structure.js	Bug 30489: Convert MARC and authority subfield edit tabs to Bootstrap	2022-05-02 11:22:57 -10:00
members-menu.js	Bug 29129: Update DisplayClearScreenButton to allow for a choice between issueslip and issueqslip	2022-06-25 10:56:50 -03:00
members.js	Bug 30026: SMSAlert regex fixed for international	2022-06-06 13:54:00 -03:00
merge-record.js	Bug 25320: Move translatable strings out of merge-record-strings.inc into merge-record.js	2020-09-29 14:28:19 +02:00
messaging-preference-form.js	Bug 26244: Move translatable strings out of memberentrygen.tt and into JavaScript	2022-04-12 11:40:17 +02:00
offlinecirc.js	Bug 24545: (follow-up) Fix license statements	2020-02-24 13:31:27 +00:00
onboarding.js	Bug 28982: Use Flatpickr on onboarding pages	2021-11-03 15:40:53 +01:00
patron-webcam.js	Bug 6815: Display an error in if HTTPS not used and webcam unavailable	2022-03-24 14:22:10 -10:00
recalls.js	Bug 19532: (follow-up) Fixing tests and QA tools	2022-03-14 22:45:51 -10:00
register_selection.js	Bug 24786: Allow selection of cash register at login	2020-11-06 15:39:59 +01:00
resolve_claim_modal.js	Bug 31085: Reload return claims table on resolve	2022-07-01 16:08:22 -03:00
rotating-collections.js
select2.js	Bug 29397: Use kohaSelect for pickup locations	2022-02-10 14:44:23 -10:00
serials-toolbar.js	Bug 26256: Move translatable strings out of templates and into serials-toolbar.js	2020-09-29 14:28:18 +02:00
showpredictionpattern.js
sms_providers.js	Bug 26240: Move translatable strings out of sms_providers.tt and into sms_providers.js	2020-09-29 14:28:18 +02:00
staff-global.js	Bug 30640: Focus does not always move to correct search header form field	2022-05-18 17:22:08 -10:00
subscription-add.js	Bug 24010: Number of issues to display to staff accepts non-integer values	2022-07-05 10:57:16 -03:00
table_filters.js	Bug 24662: Remove global variables MSG_* from datatables.inc	2020-03-11 13:49:15 +00:00
tools-menu.js	Bug 29821: Add interface for generating barcodes using svc/barcode	2022-04-08 15:49:17 +02:00
upload-images.js	Bug 30223: Move book cover image upload JS to a separate file	2022-04-19 21:25:51 -10:00
viewlog.js	Bug 29648: Log viewer - no sort	2022-04-27 11:20:44 -10:00
xmlControlfield.js
z3950_search.js	Bug 28773: (QA follow-up) Additional changes	2021-08-04 14:06:43 +02:00