Main Koha release repository https://koha-community.org
Find a file
Owen Leonard 57221e083b
Bug 24010: Number of issues to display to staff accepts non-integer values
This patch modifies the subscription entry form so that it will perform
a check on the staffdisplaycount and opacdisplaycount fields before
proceding to the second step. It verifies that the values are numeric.

The changes are made in the style of the existing form validation, which
should be rewritten to either use the validation plugin or to peform
checks in a way that all checks are run before warning the user.
However, this smaller change will work in the meantime.

To test, apply the patch and go to Serials -> New subscription.

- Fill out the form with at least the required fields, but put something
  other than a number if the "Number of issues to display to staff" and
  "Number of issues to display to the public" with non-numeric characters.
- When you click the "Next" button you should get an error message,
  "Number of issues to display to staff must be a number."
- Correct the issues to display to staff field and submit again.
- You should get a different error message, "Number of issues to display
  to the public must be a number."
- Correct this field and you should be able to proceed to the next step.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-07-05 10:57:16 -03:00
acqui Bug 23991: Move SearchSuggestion to Koha::Suggestions 2022-06-27 12:30:28 -03:00
admin Bug 30848: Add an ExpandCodedFields RecordProcessor filter 2022-07-01 09:15:46 -03:00
api Bug 30275: (follow-up) Rebase fixes 2022-07-05 09:46:12 -03:00
authorities Bug 29260: 210a is reported to Autor (meeting/conference) when upgrading an authority through Z3950 2022-06-06 13:48:13 -03:00
basket Bug 29871: Remove marcflavour param in Koha::Biblio->get_marc_notes 2022-06-06 14:26:51 -03:00
bin
C4 Bug 30275: (follow-up) Drop renewer_id constraint 2022-07-05 09:46:18 -03:00
catalogue Bug 30327: Add options for sorting components 2022-06-25 15:25:18 -03:00
cataloguing Bug 30716: Add collection to cn_browser results 2022-07-05 10:55:59 -03:00
circ Bug 29129: Update DisplayClearScreenButton to allow for a choice between issueslip and issueqslip 2022-06-25 10:56:50 -03:00
clubs
course_reserves Bug 30409: barcodedecode() should always trim barcode 2022-06-14 07:54:58 -03:00
debian Bug 25622: Use special chars in DB password (koha-create) 2022-07-05 08:41:55 -03:00
docs Bug 30808: Add the 22.05 release team. 2022-05-25 23:56:12 -10:00
errors
etc Bug 29936: Add holds_get_captured option to sip config 2022-05-05 11:17:37 -10:00
ill
installer Bug 30275: DBRev 22.06.00.011 2022-07-05 09:50:05 -03:00
Koha Bug 30275: (follow-up) Drop renewer_id constraint 2022-07-05 09:46:18 -03:00
koha-tmpl Bug 24010: Number of issues to display to staff accepts non-integer values 2022-07-05 10:57:16 -03:00
labels Bug 30813: Update TransformMarcToKoha to accept a hashref 2022-06-08 11:40:29 -03:00
lib/CGI/Session/Serialize
members Bug 23991: Move SearchSuggestion to Koha::Suggestions 2022-06-27 12:30:28 -03:00
misc Bug 30275: Rename issues.renewals to issues.renewals_count 2022-07-05 09:45:55 -03:00
offline_circ Bug 30275: Rename issues.renewals to issues.renewals_count 2022-07-05 09:45:55 -03:00
opac Bug 30918: Allow passing filtered record to get_marc_notes 2022-07-01 09:17:20 -03:00
patron_lists
patroncards
plugins
pos
recalls Bug 30924: Add missing branchtransfers.reason value for recall cancellation 2022-06-13 10:30:51 -03:00
reports Bug 30551: Make cash register report take branchcode from cash register 2022-05-06 10:33:10 -10:00
reserve Bug 30960: Fix JS error message when no pick-up location is selected when placing a hold 2022-06-20 10:44:04 -03:00
reviews
rotating_collections
serials Bug 30813: Update TransformMarcToKoha to accept a hashref 2022-06-08 11:40:29 -03:00
services
skel
suggestion Bug 23991: Move SearchSuggestion to Koha::Suggestions 2022-06-27 12:30:28 -03:00
svc Bug 30971: (follow-up) Fix one more occurence 2022-06-16 09:40:57 -03:00
t Bug 30275: (follow-up) Fix tests count 2022-07-05 09:53:29 -03:00
tags
tmp/modified_authorities
tools Bug 22659: (follow-up) Add category to redirect 2022-06-25 10:52:35 -03:00
virtualshelves
xt Bug 27619: (QA follow-up) Remove xt/sample_notices.t 2022-05-11 11:28:48 +01:00
.editorconfig
.eslintrc.json
.gitignore
.htaccess
.mailmap 22.05.00: Update mailmap 2022-05-25 23:56:12 -10:00
.perlcriticrc
.proverc.dist
.scss-lint.yml
about.pl
app.psgi
changelanguage.pl
cpanfile Bug 25669: (follow-up) Minor fixes 2022-06-23 11:30:44 -03:00
fix-perl-path.PL
gulpfile.js
help.pl
INSTALL
Koha.pm Bug 30275: DBRev 22.06.00.011 2022-07-05 09:50:05 -03:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl
Makefile.PL
MANIFEST.SKIP
package.json
README
README.md
README.robots
rewrite-config.PL
yarn.lock

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo