David Cook
b4d8180d82
Currently, Koha is not correctly validating SMS numbers using E.164. This causes Australian phone numbers without a country code to fail validation. This patch uses the E.164 pattern of 1-3 digits for country code, prefixed by a + symbol, and followed by up to 12 digits for the remainder of the phone number. To test: 0. Don't apply patch yet 1. Set "SMSSendDriver" to "Anything" 2. Go to http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 3. Type in 0455555555 and note "Please enter a valid phone number." message in browser 6. Apply the patch 7. Go to http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 8. Type in 0455555555 and note no validation error 9. Type in +61455555555 and note no validation error 10. Type in 123456789012 and note no validation error 11. Type in 1234567890123 and note "Please enter a valid phone number." error 12. Type in +900123456789012 and note no validation error 13. Type in 900123456789012 and note "Please enter a valid phone number." error Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
||
|---|---|---|
| .. | ||
| pages | ||
| acq.js | ||
| acquisitions-menu.js | ||
| additem.js | ||
| addorderiso2709.js | ||
| admin-menu.js | ||
| ajax.js | ||
| audio_alerts.js | ||
| auth-finder-search.js | ||
| automatic_item_modification_by_age.js | ||
| background-job-progressbar.js | ||
| basket.js | ||
| basketgroup.js | ||
| biblio_framework.js | ||
| cart.js | ||
| catalog.js | ||
| cataloging.js | ||
| cataloging_additem.js | ||
| categories.js | ||
| charts.js | ||
| checkouts.js | ||
| circ-patron-search-results.js | ||
| datatables.js | ||
| desk_selection.js | ||
| file-upload.js | ||
| funds_sorts.js | ||
| holds.js | ||
| ill-availability-partner.js | ||
| ill-availability.js | ||
| ill-list-table.js | ||
| item_search_fields.js | ||
| letter.js | ||
| localcovers.js | ||
| mana.js | ||
| marc_modification_templates.js | ||
| marc_subfields_structure.js | ||
| members-menu.js | ||
| members.js | ||
| merge-record.js | ||
| messaging-preference-form.js | ||
| offlinecirc.js | ||
| onboarding.js | ||
| rotating-collections.js | ||
| select2.js | ||
| serials-toolbar.js | ||
| showpredictionpattern.js | ||
| sms_providers.js | ||
| staff-global.js | ||
| subscription-add.js | ||
| suggestions.js | ||
| table_filters.js | ||
| tools-menu.js | ||
| viewlog.js | ||
| xmlControlfield.js | ||
| z3950_search.js | ||