Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/C4
History
Marcel de Rooy 4b1c71e91a Bug 9886: ParseLetter removes too often punctuation characters from fields 
This patch makes ParseLetter somewhat more restrictive in removing
punctuation characters from the end of a table field.
Based on the assumption that we want to remove punctuation from fields in
biblio and biblioitems (like ISBD).
ParseLetter should not remove e.g. a parenthesis in itemcallnumber, but still
removes e.g. a colon (:) at the end of a title.
Removed an unneeded global and lookahead from the regex.

Test plan:
1) Add a colon (:) to the end of a title.
2) Add a colon to the end of item copynumber.
3) Place a hold on that item. Check it in. Confirm hold.
4) Check the email or print notice generated. There should be no colon at the
end of the title, but the colon in the copynumber should still be there.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I compared checkout notices with lots of different fields before
and after applying the patch. For example the ) at the end of a
field in branches is now longer removed. Other fields looked ok
before and after.
Passes all tests and QA script.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2013-04-26 18:37:32 -04:00
..
AuthoritiesMarc
Barcodes Bug 6679 - [SIGNED-OFF] fix 6 perlcritic violations in C4/Barcodes/hbyymmincr.pm 2012-09-20 12:01:36 +02:00
ClassSortRoutine
Creators Bug 9535 - Patron card creator "Remove duplicates" function doesn't work 2013-04-03 06:09:06 -04:00
External Bug 6679 - fix 12 perlcritic violations in C4/External/BakerTaylor.pm 2012-09-20 11:38:45 +02:00
Form
Heading
ILSDI Bug 9019: Return item fields in ILS-DI GetRecords 2012-12-11 08:33:04 -05:00
Installer Bug 9926 - Missing perl modules in Koha 2013-03-29 21:38:49 -04:00
Labels
Linker
Members Bug 7919: Fix unit test (Members_AttributeTypes.t) 2012-12-07 18:26:37 -05:00
OAI
Output
Patroncards
Reports Bug 9659 - Better handling of non-existent authorised value categories used in SQL reports 2013-04-26 08:07:24 -04:00
Search
SIP Bug 9838: fix on 04patron_status.t 2013-04-02 08:30:21 -04:00
Utils
VirtualShelves Bug 9458 - Add sorting to lists - QA Followup 3 2013-03-13 09:06:20 -04:00
Accounts.pm Bug 9293 - action_logs not tracking payments 2013-03-11 17:59:17 -04:00
Acquisition.pm Bug 7449: billingplace and freedeliveryplace not saved when creating a new basketgroup 2013-04-07 13:08:28 -04:00
Auth.pm Bug 10019: Fix for userid containing UTF8 chars 2013-04-19 23:13:09 -04:00
Auth_cas_servers.yaml.orig
Auth_with_cas.pm
Auth_with_ldap.pm Bug 7973 : Follow up to remove an extraneous my 2013-03-22 22:01:22 -04:00
AuthoritiesMarc.pm Bug 5635: bulkmarcimport new parameters & features 2013-03-21 20:21:54 -04:00
BackgroundJob.pm Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/BackgroundJob.pm 2012-09-20 12:01:40 +02:00
Barcodes.pm Bug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Barcodes.pm 2012-09-20 12:01:36 +02:00
Biblio.pm Bug 7440 - Remove NoZebra vestiges 2013-03-19 21:17:04 -04:00
Bookseller.pm Bug 8164: Replace IFNULL with COALESCE 2012-11-28 19:08:29 -05:00
Boolean.pm Bug 9827: remove 'insecure' system preference 2013-03-19 21:46:34 -04:00
Branch.pm Bug 9257 - Add "groups" to normal search pulldown 2013-03-22 08:20:08 -04:00
Breeding.pm Bug 9986: Two fixes for Z3950 search 2013-04-15 08:44:11 -04:00
Budgets.pm Bug 5343: Link serial and acqui modules 2013-03-22 23:54:43 -04:00
Calendar.pm Bug 7351 : feature that allows to delete a range of dates 2012-09-28 12:19:45 +02:00
Category.pm Bug 7919: FIX the "all" categories method 2013-01-02 16:50:52 -05:00
Charset.pm Bug 8347 - Koha forces UNIMARC 100 field code language to 'fre' 2013-02-20 09:06:57 -05:00
Circulation.pm Bug 8770 - amount does not equal amountoutstanding on a fine with no payments or credits 2013-04-08 08:00:30 -04:00
ClassSortRoutine.pm
ClassSource.pm
Context.pm Bug 6554 Fix error caused by modifying $_ in a map 2013-04-18 09:26:22 -04:00
Contract.pm
Creators.pm
Csv.pm
Dates.pm
Debug.pm
Heading.pm
HoldsQueue.pm Bug 9922 - holds queue shows home library with AutomaticReturn 2013-03-29 22:25:23 -04:00
HTML5Media.pm Bug 8377: Followup move style in a css file and do not pass template to a pm 2012-12-27 09:28:00 -05:00
Images.pm Bug 8710 - Don't show the images tab in the OPAC if the record has no local images 2012-11-28 18:54:40 -05:00
ImportBatch.pm Bug 9523: importing staged bib records hangs if a matched bib has been deleted 2013-04-21 21:06:54 -04:00
ImportExportFramework.pm Bug 6679 - [SIGNED-OFF] fix 15 perlcritic violations in C4/ImportExportFramework.pm 2012-09-20 12:00:55 +02:00
Input.pm Bug 7919 : Display of values depending on the connexion library 2012-12-05 10:10:57 -05:00
Installer.pm Bug 9752: Set marcflavour to NORMARC when NORMARC is chosen 2013-03-30 22:51:17 -04:00
ItemCirculationAlertPreference.pm Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/ItemCirculationAlertPreference.pm 2012-09-20 12:01:39 +02:00
Items.pm Bug 9902 - item subfields not populating 2013-04-07 13:20:07 -04:00
ItemType.pm Bug 6554 - make Koha internally utf-8 clean 2013-04-01 18:51:49 -04:00
Koha.pm Bug 9659 - Better handling of non-existent authorised value categories used in SQL reports 2013-04-26 08:07:24 -04:00
Labels.pm
Languages.pm Bug 8954: Make languages list in advanced search translatable (revision 1) 2012-11-20 14:39:56 -05:00
Letters.pm Bug 9886: ParseLetter removes too often punctuation characters from fields 2013-04-26 18:37:32 -04:00
Linker.pm
Log.pm Bug 7067 - OPAC Borrower Self Registration 2012-12-14 08:08:59 -05:00
Maintainance.pm
Matcher.pm Bug 9239: Allow the use of QueryParser for all queries 2013-03-16 21:32:32 -04:00
Members.pm Bug 9014 - Add time due to slips 2013-03-21 11:07:42 -04:00
Message.pm Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Message.pm 2012-09-20 12:01:39 +02:00
NewsChannels.pm
Output.pm Bug 6554 QA Followup 2013-04-01 18:51:49 -04:00
Overdues.pm Bug 8365: Add a renewal duration in the issuing rules 2013-03-22 07:56:59 -04:00
Patroncards.pm
Print.pm Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Print.pm 2012-09-20 12:17:43 +02:00
Ratings.pm
Record.pm Bug 9274: Software error in bibtex export 2013-03-30 20:59:41 -04:00
Reports.pm
Reserves.pm Bug 9103: overdue_notices.pl should use AutoEmailPrimaryAddress syspref 2013-03-19 22:50:39 -04:00
Review.pm
Ris.pm
RotatingCollections.pm
Scheduler.pm
Scrubber.pm
Search.pm Bug 9588: weighted search query with index 2013-04-21 20:54:21 -04:00
Serials.pm Revert "Merge branch 'bug_7688' into 3.12-master" 2013-03-23 00:36:37 -04:00
Service.pm
ShelfBrowser.pm Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/ShelfBrowser.pm 2012-09-20 12:01:37 +02:00
SMS.pm
SocialData.pm
SQLHelper.pm Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/SQLHelper.pm 2012-09-20 12:01:38 +02:00
Stats.pm
Suggestions.pm Bug 10072 - "my suggestions" always says "There are no pending purchase suggestions." 2013-04-19 23:16:56 -04:00
Tags.pm Bug 9136: C4::Tags not Plack-compatible 2012-12-22 15:47:48 -05:00
Templates.pm Bug 6554 - make Koha internally utf-8 clean 2013-04-01 18:51:49 -04:00
TmplToken.pm
TmplTokenType.pm Revert "Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm" 2012-09-20 13:29:59 +02:00
TTParser.pm
UploadedFile.pm
Utils.pm Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Utils.pm 2012-09-20 12:01:39 +02:00
VirtualShelves.pm Bug 7368: POD doc in VirtualShelves.pm 2013-03-21 18:33:28 -04:00
XISBN.pm Bug 9726: XISBN service throttle not initialized 2013-03-30 22:05:15 -04:00
XSLT.pm Bug 10073: Show ccode or location also if not bound to Authorized Values in XSLT 2013-04-26 18:31:01 -04:00
Z3950.pm