Main Koha release repository https://koha-community.org
Find a file
Kyle M Hall 6d456df81a
Bug 24330: When importing patrons from CSV, automatically strip BOM from file if it exists
We have a partner that exports UTF-8 CSV files, and is experiencing the same thing as the author of this article: https://www.freecodecamp.org/news/a-quick-tale-about-feff-the-invisible-character-cd25cd4630e7/

In short, Excel is inserting an invisible UTF-8 character at the start of the file, so that the column name "cardnumber" is actually named "\x{feff}cardnumber", causing "cardnumber" to be blank.

A simple solution is provided here: https://stackoverflow.com/questions/24390034/remove-bom-from-string-with-perl

Test Plan:
1) Download the example.csv file
2) Attempt to import it using the patron import tool
3) Note the invalid column name error
4) Apply this patch, restart all the things!
5) Attempt the import again
6) Assuming you have a branchcode MPL and a cataegory code S, the patron should import!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Maggie Wong <maggie.wong@yccece.edu.hk>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2020-01-30 15:52:20 +00:00
acqui Bug 24347: (follow-up) Remove custom catalog search from acquisitions 2020-01-30 10:59:27 +00:00
admin Bug 21674: Prevent to insert twice the same library in a group 2020-01-30 15:36:25 +00:00
api/v1 Bug 18731: OpenAPI definitions 2020-01-09 16:25:57 +00:00
authorities
basket
C4 Bug 24377: Record passed branch if renewing via cron 2020-01-30 15:36:00 +00:00
catalogue Bug 24347: Add a 'search to order' option similar to 'search to hold' 2020-01-30 10:58:03 +00:00
cataloguing Bug 24503: fix missing use in value builder barcode_manual.pl 2020-01-24 15:18:41 +00:00
circ Bug 19809: Re-allow to call Koha::Objects::find in list context 2020-01-23 10:27:28 +00:00
clubs
course_reserves
debian Bug 22831: (RM follow-up) Add libarray-utils-perl to control 2020-01-24 09:17:11 +00:00
docs Koha 19.12 - Dobbie is a free elf... 2019-12-02 17:13:15 +00:00
errors Bug 23329: Move error page to its own subroutine 2019-11-27 11:30:19 +00:00
etc Bug 22220: Fix bib Apache rewrite rule for intranet 2020-01-20 14:03:49 +00:00
ill
installer Bug 21674: DBRev 19.12.00.017 2020-01-30 15:44:42 +00:00
Koha Bug 24330: When importing patrons from CSV, automatically strip BOM from file if it exists 2020-01-30 15:52:20 +00:00
koha-tmpl Bug 21674: Prevent to insert twice the same library in a group 2020-01-30 15:36:25 +00:00
labels Bug 7468: Use Modern::Perl 2020-01-21 11:29:22 +00:00
members Bug 22868: Move suggestions_manage subperm out of acquisition perm 2020-01-30 08:27:00 +00:00
misc Bug 24105: Fix error when running longoverdue.pl with --itemtypes 2020-01-23 10:26:05 +00:00
offline_circ Bug 22600: Add 'interface' to accountlines 2019-04-10 19:43:11 +00:00
opac Bug 13121: Move search results "action" links ("Place hold," "Add tag," etc) into include file 2020-01-29 09:04:14 +00:00
OpenILS
patron_lists
patroncards
plugins
pos Bug 24477: Require takepayment permission in pos/pay.pl 2020-01-23 08:51:36 +00:00
reports Bug 24305: (QA follow-up) Strip table name in [[table.field|alias]] 2020-01-24 15:19:48 +00:00
reserve Bug 22284: (QA follow-up) Make pickup locations be Koha::Library objects 2020-01-03 12:58:06 +00:00
reviews
rotating_collections
serials Bug 7047: Change ReNewSubscription prototype - use hashref 2019-12-23 12:06:45 +00:00
services
skel
suggestion Bug 23594: Restore previous view after delete or update itemtype 2020-01-30 10:56:57 +00:00
svc Bug 23427: Simplify sort logic 2019-11-07 13:25:10 +00:00
t Bug 24377: Unit test 2020-01-30 15:36:00 +00:00
tags
tmp/modified_authorities
tools Bug 20847: Add more fields to the Batch Patron Modification tool 2020-01-29 09:07:33 +00:00
virtualshelves
xt
.editorconfig
.eslintrc.json Bug 23834: Add default ESLint configuration 2019-11-03 08:02:39 +00:00
.gitignore
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
.scss-lint.yml
about.pl Bug 24327: Add warning to the about page is AnonSugggestions but AnonymousPatron 2020-01-08 14:13:28 +00:00
changelanguage.pl
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
gulpfile.js
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Bug 21674: DBRev 19.12.00.017 2020-01-30 15:44:42 +00:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl
Makefile.PL Bug 24445: Add z3950 to makefile (bug 13937 follow-up) 2020-01-17 11:09:51 +00:00
MANIFEST.SKIP
package.json Bug 23025: security vulnerability detected in fstream < 1.0.12 defined in yarn.lock 2019-11-27 11:30:17 +00:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md
README.robots
rewrite-config.PL
yarn.lock Bug 23025: Update yarn.lock 2019-11-27 11:30:17 +00:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo