Main Koha release repository https://koha-community.org
Find a file
Martin Renvoize 6e56e4a0d1
Bug 36175: Corrections to reduced due for booked items
This patch fixes a mistake in the circulation controller such that the
proper reduceddue date is passed to the template when a checkout would
overlap with a booking.

I also take the oportunity to enhance the functionality to allow
librarians to set their own reduceddue date between now and the hard
reduceddue as required for the existing booking.

Test plan
1) Set an item to 'bookable'
2) Add a booking to that item for user A for a few days time.
3) Attempt to checkout the item to user B and note the warning that
   the item is booked for another user.
4) With the patch applied, a reduced due date of 1 day prior to the
   booking should be defaulted to in the displayed date picker.
5) You should be able to select any date between today and the day
   before the booking starts
6) Confirm you can checkout with the reduceddue date set.
7) Bonus point, confirm the field is required, so if you try to wipe it
   and then checkout, you will be blocked.

Signed-off-by: Kelly <kelly@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-03-07 16:36:32 +01:00
acqui Bug 34478: Manual fix - reopen basket - add cud- - basket.tt 2024-03-01 11:00:23 +01:00
admin Bug 34478: Replace delete links with form - smart-rules 2024-03-01 11:00:15 +01:00
api
authorities Bug 34478: Regression - fix change auth type 2024-03-01 10:59:15 +01:00
basket Bug 34478: Add 'op' to sendbasketform 2024-03-01 10:58:53 +01:00
bin
bookings
C4 Bug 36148: Do not deal with CSRF error in get_template_and_user 2024-03-01 11:01:07 +01:00
catalogue Bug 36000: Fix CGI::param warning in catalogue search 2024-03-07 15:02:43 +01:00
cataloguing Bug 34478: Fix delallitems for additem 2024-03-01 11:00:19 +01:00
circ Bug 36175: Corrections to reduced due for booked items 2024-03-07 16:36:32 +01:00
clubs Bug 34478: Manual fix - add op clubs/templates-add-modify 2024-03-01 10:57:55 +01:00
course_reserves Bug 34478: Manual fix - Course reserves 2024-03-01 10:56:56 +01:00
debian Bug 36009: Document koha-worker --queue elastic_index 2024-03-07 15:02:48 +01:00
docs
erm
errors Bug 36148: Improve error handling and restore programming errors 2024-03-01 11:01:06 +01:00
etc
ill Bug 34478: Move compatibility code 2024-03-01 10:58:06 +01:00
installer Bug 36102: Fix removal of cookie from the installer session on upgrades 2024-03-01 11:00:36 +01:00
Koha Bug 35963: Fix bundled items table ordering and filtering 2024-03-07 15:02:51 +01:00
koha-tmpl Bug 36175: Corrections to reduced due for booked items 2024-03-07 16:36:32 +01:00
labels Bug 34478: Update label ops 'edit' to 'edit_form' 2024-03-01 10:56:33 +01:00
lib/CGI/Session/Serialize
members Bug 35329: Move patron search to modal - remove members/search.pl 2024-03-01 11:01:15 +01:00
misc Bug 36009: Document background_jobs_worker.pl --queue elastic_index 2024-03-07 15:02:49 +01:00
offline_circ Bug 34478: Changes for offline_circ 2024-03-01 10:58:34 +01:00
opac Bug 35952: Remove unnecessary line for OpacSuppressionMessage 2024-03-07 15:02:50 +01:00
patron_lists Bug 34478: Changes for patron_lists/add-modify 2024-03-01 10:57:41 +01:00
patroncards Bug 34478: (follow-up) patroncards: FIXMEs for op and missing script 2024-03-01 11:00:00 +01:00
plugins Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
pos Bug 34478: Manual fix - add op - pos/pay 2024-03-01 10:57:34 +01:00
preservation
recalls Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
reports Bug 34478: Manual fix - change 'phase' to 'op' add cud- - mana-share-report 2024-03-01 10:59:08 +01:00
reserve Bug 34478: Manual fix - change links to JS form submission - change action to op - request.pl/.tt 2024-03-01 10:59:09 +01:00
reviews Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
rotating_collections Bug 34478: Manual fix - add op - rotating_collections/addItems 2024-03-01 10:57:33 +01:00
serials Bug 35329: Handle duplicate without 500 2024-03-01 11:01:26 +01:00
services
skel
suggestion Bug 34478: Changes for suggestion/suggestion 2024-03-01 10:59:26 +01:00
svc Bug 36084: svc - mana 2024-03-01 11:01:01 +01:00
t Bug 35963: (QA follow-up): tidy up code and fix exec permission 2024-03-07 15:02:52 +01:00
tags Bug 34478: Add 'op' to tags/review 2024-03-01 10:58:25 +01:00
tools Bug 34478: Correct op name in CSV profile deletion confirmation step 2024-03-01 11:00:07 +01:00
virtualshelves Bug 34478: Correct op name for list edit confirmation 2024-03-01 11:00:09 +01:00
xt Bug 34478: Add test to catch missing op in POST forms 2024-03-01 10:58:14 +01:00
.editorconfig
.eslintrc.json
.gitignore
.htaccess
.mailmap
.perlcriticrc
.perltidyrc
.proverc.dist
.stylelintrc.json
about.pl
app.psgi
build-resources.PL
changelanguage.pl
cpanfile
cypress.config.ts
fix-perl-path.PL
gulpfile.js
help.pl
INSTALL
Koha.pm
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl
Makefile.PL
MANIFEST.SKIP
package.json
README
README.md
README.robots
rewrite-config.PL
tsconfig.json
webpack.config.js
yarn.lock

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo