Main Koha release repository https://koha-community.org
Find a file
Emmi Takkinen 70fc698899
Bug 26558: Make guarantor information persist despite an error
When one tries to create an account with patron guarantor and
error occurs (already used username, wrong age etc.), guarantor
information is lost. This patch always saves added patron
guarantor information to the template param new_guarantors.

To test:
1. Create a new account but cause an error that will keep the
account from saving (enter the wrong age for a category or
give the patron a username that's already being used).
2. Search for and select a guarantor.
3. Try to save the account and wait for the "The following
fields are wrong. Please fix them." message.
=> Note that the guarantor information is gone and you need
to search for and select the guarantor again.
4. Apply this patch.
5. Repeat steps 1.-3.
=> Note that guarantor information hasn't been lost.

This patch also removes code block from duplicate patron
check because we now save param new_guarantors even if
error doesn't occur.

To test:
1. Create a new account but cause a duplicate patron error.
2. Search for and select a guarantor.
3. Try to save the account.
=> Guarantor information should persist.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-11 12:13:05 -03:00
acqui Bug 33170: Refactor MARCItemFieldsToOrder to make adding more fields trivial 2023-10-11 10:31:49 -03:00
admin Bug 31731: Offer user a dropdown of authorized values instead of a text field in preferences 2023-10-10 10:54:00 -03:00
api Bug 33690: Convert to x-koha-override 2023-10-04 11:07:56 -04:00
authorities Bug 33406: (QA follow-up) Adjust tests and tidy 2023-09-15 15:50:43 -03:00
basket Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-12 09:44:59 -03:00
bin
C4 Bug 33239: Add the ability to run borrowers-force-messaging-defaults.pl only on a specified message name 2023-10-11 10:31:46 -03:00
catalogue Bug 34441: Fixed Typo "Paramater" 2023-09-01 11:23:21 -03:00
cataloguing Bug 34657: Merge cataloging plugins for UNIMARC 123d, e, f, and g 2023-10-09 11:41:18 -03:00
circ Bug 9525: (QA follow-up) Tidy 2023-10-04 16:40:12 -04:00
clubs Bug 25079: Show club enrollment question answers in staff client 2023-06-23 11:00:54 -03:00
course_reserves
debian Bug 34653: Make koha-foreach return the correct status code 2023-09-25 10:56:40 -03:00
docs Bug 33899: Add the 23.11 release team 2023-06-09 08:28:57 -03:00
erm
errors
etc Bug 34153: Add ability to allow items with additional materials notes to be checked out via SIP 2023-10-04 16:40:18 -04:00
ill Bug 33716: (QA follow-up) Fix submission when cardnumber is invalid 2023-09-19 16:34:37 -03:00
installer Bug 21246: DBRev 23.06.00.034 2023-10-11 10:31:42 -03:00
Koha Bug 33843: Use filter_by_last_update in Koha::Notice::Util 2023-10-11 10:31:45 -03:00
koha-tmpl Bug 32740: Add a new option patron home library to OverdueNoticeFrom 2023-10-11 12:13:04 -03:00
labels
lib/CGI/Session/Serialize
members Bug 26558: Make guarantor information persist despite an error 2023-10-11 12:13:05 -03:00
misc Bug 32740: Add a new option patron home library to OverdueNoticeFrom 2023-10-11 12:13:04 -03:00
offline_circ Bug 32496: Reduce unnecessary unblessings of objects in Circulation.pm 2023-09-22 10:52:39 -03:00
opac Bug 28130: (QA follow-up) Tidy 2023-10-11 10:31:39 -03:00
patron_lists
patroncards
plugins
pos Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-12 09:44:59 -03:00
recalls Bug 34013: Recalls awaiting pickup doesn't show count on each tab 2023-06-23 10:01:04 -03:00
reports Bug 34859: Remove unnecessary params from reports-home.pl 2023-10-04 16:40:16 -04:00
reserve Bug 31692: Tidy and rebase fix 2023-10-10 09:58:59 -03:00
reviews
rotating_collections
serials Bug 34199: Add full title information to subscription detail page 2023-09-22 11:35:46 -03:00
services
skel
suggestion Bug 34601: Fix edit/delete links on suggestion.tt 2023-08-29 14:37:10 -03:00
svc Bug 34369: Require CSRF token for updating system preferences 2023-09-25 18:18:40 -03:00
t Bug 33837: Remove datetime parameter 2023-10-11 10:31:45 -03:00
tags
tools Bug 26978: Add item type option to batch extend due date tool 2023-10-11 12:13:03 -03:00
virtualshelves Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-12 09:44:59 -03:00
xt Bug 34911: Test files from HEAD instead of 'master' 2023-10-04 09:15:35 -04:00
.editorconfig
.eslintrc.json
.gitignore Bug 33710: Ignore how-to related files 2023-05-12 17:50:01 -03:00
.htaccess
.mailmap Update .mailmap 2023-06-12 11:52:05 -03:00
.perlcriticrc
.perltidyrc Bug 30002: Adjust perltidy 2023-06-08 08:32:42 -03:00
.proverc.dist
.stylelintrc.json
about.pl Bug 27634: Add a warning to the about page if PatronSelfRegistrationDefaultCategory not set 2023-09-19 16:34:19 -03:00
app.psgi
build-resources.PL
changelanguage.pl
cpanfile Bug 34064: Add SQL::Translator dependency to cpanfile 2023-10-10 10:54:04 -03:00
cypress.config.ts Bug 34319: Upgrade cypress 9.7.0 to 12.17.2 2023-09-05 11:52:25 -03:00
fix-perl-path.PL
gulpfile.js
help.pl
INSTALL
Koha.pm Bug 21246: DBRev 23.06.00.034 2023-10-11 10:31:42 -03:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl
Makefile.PL Bug 23241: Remove unused koha-index-daemon-ctl.sh 2023-10-10 09:22:37 -03:00
MANIFEST.SKIP
package.json Bug 34319: Upgrade cypress 9.7.0 to 12.17.2 2023-09-05 11:52:25 -03:00
README
README.md
README.robots
rewrite-config.PL
tsconfig.json
webpack.config.js
yarn.lock Bug 34319: Update yarn.lock 2023-09-05 11:52:25 -03:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo