Nick Clemens
6754e92c1c
On bug 15422 we made it so that only holds with copies to buy to acheive the holds ratio showed Users have reported that they want to see record where there are 0 copies to buy i.e. the holds ration matches the value entered This patch changes the criteria for returning holds to be if the ratio for a given title is equal to or greater then the ratio specified in the form I also renamed 'ratiocalc' to 'copies_to_buy' since that is what is contains Test plan: 1. Create bibliographic records with 1, 2 and 3 items 2. Place 1 hold on each of them 3. Go to the Hold ratios report and search with ratio = 1, 2 then 3 4. You expect to see: the title with 1 item with ratio 1 nothing otherwise 5. Place another hold on each of the record 6. Repeat 3 you expect to see: titles with 1 or 2 items with ratio 1 title with 1 item for ratio 2 nothing with ratio 3 7. Place another hold on each of the record 8. Repeat 3 you expect to see: titles with 1 or 2 or 3 items with ratio 1 title with 1 item or 2 items for ratio 2 nothing with ratio 3 9. Make sure there is no regression in the test plan of bug 15422 Comments from Frank Hansen: Some comments. When I adding the third hold on each record in step 7, It will result in the following result: titles with 1 or 2 or 3 items with ratio 1 title with 1 items with ratio 2 because the title with 2 items will get a ratio of 1.50 and not 2. title with 1 items with with ratio 3 Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
||
|---|---|---|
| .. | ||
| add_message.pl | ||
| article-request-slip.pl | ||
| article-requests.pl | ||
| bookcount.pl | ||
| branchoverdues.pl | ||
| branchtransfers.pl | ||
| checkout-notes.pl | ||
| circulation-home.pl | ||
| circulation.pl | ||
| del_message.pl | ||
| hold-transfer-slip.pl | ||
| offline-mf.pl | ||
| offline.pl | ||
| on-site_checkouts.pl | ||
| overdue.pl | ||
| pendingreserves.pl | ||
| renew.pl | ||
| request-article.pl | ||
| reserveratios.pl | ||
| returns.pl | ||
| set-library.pl | ||
| transfer-slip.pl | ||
| transfers_to_send.pl | ||
| transferstoreceive.pl | ||
| view_holdsqueue.pl | ||
| waitingreserves.pl | ||
| ypattrodue-attr-search-authvalue.pl | ||
| ysearch.pl | ||