Main Koha release repository https://koha-community.org
Find a file
Tomas Cohen Arazi 75cff54c53
Bug 34387: Improve API docs naming consistency
This patch aims to make our API docs be more consistent.
It addresses two particular things:

* There's no consistency on the `tags` used across the spec, and not all
  of them are correctly described and have an `x-displayName` entry.
  More on this later.
* This are not sorted either by some for of grouping, or at least
  alphabetically.

For the former, I did my best trying to harmonize (specially on the ERM
front) with what we do in the rest of the use cases.

For the latter, I opted for sorting everything alphabetically, as a
first step. Hoping someone else could work on grouping things.

To test (ON YOUR HOST MACHINE):
1. On current master run:
   $ cd api/v1/swagger
   $ docker run --rm -v $(pwd):/api --workdir /api redocly/cli \
           build-docs swagger.yaml --output index.html
=> SUCCESS: It doesn't break or anything
2. Open your browser, open the generated api/v1/swagger/index.html file
=> FAIL: The left column has
         * several lower case entries
         * not everything is correctly grouped (ERM? packages?)
         * Things are not sorted. There's an attempt but looks messy
3. Apply this patch
4. Repeat 1 and 2
=> SUCCESS: Things look much better!
5. Sign off :-D

CAVEAT1: I'm not sure why, but import_batches doesn't work. Ideas are
welcome, I'll keep looking for fixes.
CAVEAT2: I don't have enough eHoldings background to weight in, but I
feel like 'ERM eHoldings packages' could just be 'ERM packages'.
Follw-up patches with better ideas are welcome.
CAVEAT3: Patron credits, debits, balance... They could all go in to
'Patrons accounts' or similar. Open to ideas.
CAVEAT4: Old redocly didn't support mapping an endpoint to more than one
target section. Something to explore if we want (for example) to reach
'credits' through the 'Patrons' section but also from 'Accounting'.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-08-15 11:25:35 +03:00
acqui Bug 33105: Tidy files 2023-07-20 10:59:31 -03:00
admin Bug 32271: (QA follow-up) Convert all positive numbers to monetary float and convert all 0 equivilents to blank value 2023-07-19 13:00:37 -03:00
api Bug 34387: Improve API docs naming consistency 2023-08-15 11:25:35 +03:00
authorities Bug 33803: Remove comment about tab width 2023-06-06 09:58:47 -03:00
basket Bug 33223: Replace 'first_valid' with 'notice' for email addresses 2023-05-16 15:17:35 -03:00
bin
C4 Bug 33881: Clear self-check JWT during auth kick out 2023-08-07 21:00:08 -03:00
catalogue Bug 33047: Return 404 instead of 500 when biblio does not exist 2023-07-10 15:43:14 -03:00
cataloguing Bug 34288: Allow access to the cataloguing module with tools permission 2023-07-18 12:46:53 -03:00
circ Bug 28966: Prefetch patron data for holds queue viewer 2023-07-25 16:25:38 -03:00
clubs Bug 25079: Show club enrollment question answers in staff client 2023-06-23 11:00:54 -03:00
course_reserves
debian Bug 28493: Make koha-passwd display the username 2023-07-19 13:00:41 -03:00
docs Bug 33899: Add the 23.11 release team 2023-06-09 08:28:57 -03:00
erm
errors
etc Bug 34101: Limit items types that can be checked out via SIP2 2023-07-05 12:17:23 -03:00
ill Bug 28909: Allow illview to use backend template 2022-08-09 13:21:39 -03:00
installer Bug 33117: Make dbrev idempotent 2023-08-07 21:00:09 -03:00
Koha Bug 30524: (QA follow-up) Only generate CSRF token if it will be used 2023-08-07 21:00:06 -03:00
koha-tmpl Bug 30524: (QA follow-up) Only generate CSRF token if it will be used 2023-08-07 21:00:06 -03:00
labels
lib/CGI/Session/Serialize
members Bug 22990: Add CSRF protection to boraccount, pay and suggestion 2023-08-07 21:00:01 -03:00
misc Bug 34213: import_patrons.pl - Fix short version of matchpoint option in POD 2023-07-21 17:14:40 -03:00
offline_circ Bug 33444: Update AddRenewal to take a hashref of params 2023-07-19 12:06:52 -03:00
opac Bug 34023: Prevent HTML injection in "back to results" link from search page 2023-08-07 21:00:04 -03:00
patron_lists
patroncards
plugins
pos Bug 30619: Add email receipt to POS 2022-09-07 15:59:34 -07:00
recalls Bug 34013: Recalls awaiting pickup doesn't show count on each tab 2023-06-23 10:01:04 -03:00
reports Bug 29664: (QA follow-up) Typo transacton 2023-07-03 14:51:36 -03:00
reserve Bug 34178: Cache ItemsAnyAvailableAndNotRestricted in memory and don't precalculate 2023-07-19 13:00:42 -03:00
reviews
rotating_collections
serials Bug 33039: Add ability to specify a template for serial subscription "Published on (text)" field 2023-07-14 08:59:43 -03:00
services
skel
suggestion Bug 22990: (follow-up) Fix suggestion.pl 2023-08-07 21:00:04 -03:00
svc Bug 33444: Update AddRenewal to take a hashref of params 2023-07-19 12:06:52 -03:00
t Bug 30524: (QA follow-up) Fix tests 2023-08-07 21:00:07 -03:00
tags
tools Bug 34368: Add CSRF token to Content Management pages 2023-08-07 21:00:00 -03:00
virtualshelves Bug 22990: Fix for shelves table 2023-08-07 21:00:02 -03:00
xt Bug 30002: Remove unused xt/perltidyrc 2023-06-08 08:32:40 -03:00
.editorconfig
.eslintrc.json
.gitignore
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap Update .mailmap 2023-06-12 11:52:05 -03:00
.perlcriticrc
.perltidyrc Bug 30002: Adjust perltidy 2023-06-08 08:32:42 -03:00
.proverc.dist
.stylelintrc.json
about.pl Bug 33934: Add more detail to 'No encryption_key in koha-conf.xml' 2023-06-07 15:25:18 -03:00
app.psgi
build-resources.PL
changelanguage.pl
cpanfile Bug 33964: (QA follow-up) Remove library from cpanfile 2023-07-25 08:25:41 -03:00
cypress.json
fix-perl-path.PL
gulpfile.js
help.pl
INSTALL
Koha.pm Bug 28966: DBRev 23.06.00.013 2023-07-26 15:41:14 -03:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl
Makefile.PL Bug 26700: Remove occurrences in Makefile.PL 2023-06-14 09:22:00 -03:00
MANIFEST.SKIP
package.json
README
README.md
README.robots
rewrite-config.PL
tsconfig.json
webpack.config.js
yarn.lock

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo