Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/t/db_dependent
History
Jonathan Druart 769728015c Bug 15757: Make GetLoanLength defaults to 0 instead of 21 
GetLoanLength arbitrary defaulted to 21. The expected behavior seems to
be to default on 0 (loan will be dued today).

IMPORTANT NOTE: This patch will introduce a change in the behaviors for
configuration with a 0 in issuelength. Before this patch, the rule with
a issuelength==0 was skipped, now it's used!

Test plan:
1/ Do not define any rule: the due date will be today (before this patch
was +21 days)
2/ Define some rules which does not match the patron category, itemtype
or branchcode: the due date will be today (before this patch was +21
days).
3/ Modify a rule to match the checkout and set issuelength=0: the due
date will be today (before this patch, the rule was skipped)
4/ Modify this rule and set the issuelength to something > 0: the due
date will be adjusted (same behavior as before this patch)

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Works ok, checked 1-4
All test pass
No koha-qa errors

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-04-22 00:24:06 +00:00
..
Acquisition Bug 5404: C4::Koha - remove subfield_is_koha_internal_p 2016-03-07 17:30:09 +00:00
api/v1 Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
Auth Bug 15756: Some tests for haspermission in C4::Auth 2016-02-23 20:54:42 +00:00
Biblio Bug 15572: Add tests for TransformHtmlToMarc 2016-01-25 07:09:50 -07:00
Circulation Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Creators Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
data
Exporter Bug 15081: (followup) Make test files using TestBuilder handle their transactions 2015-11-04 12:32:57 -03:00
Holds Bug 14878: (QA followup) Remove useless diag 2015-11-06 15:51:52 -03:00
Items Bug 16004: [QA Follow-up] Tiny change for unit test and help file 2016-03-31 16:57:14 +00:00
Koha Bug 16086: Add tests for Koha::Issues 2016-04-07 00:31:22 +00:00
Labels Bug 14468: (QA followup) remove useless diags 2015-10-27 10:38:15 -03:00
LDAP
Letters Bug 13215: Fix GetLetterTemplates should return default templates if branchcode is not defined 2014-11-27 11:42:26 -03:00
Members Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
OAI Bug 16172: fix OAI Server tests broken by bug 15946 2016-03-31 16:51:38 +00:00
Patron Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
Record Bug 13642 - Add Unit test for C4::Record::marc2dcxml 2016-01-27 06:23:08 +00:00
Reports Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
Reserves Bug 13592: Add an option to charge for any hold placed 2015-12-31 15:59:05 +00:00
Search Bug 10933: (followup of the followup) fix the previous patch to work with master 2015-10-27 13:06:01 -03:00
Serials Bug 15168: (followup) remove useless diags 2015-11-17 15:47:46 -03:00
Template/Plugin Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
Utils Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
www Bug 16160: Fix t/../www/search_utf8.t for layout change 2016-03-30 13:44:16 +00:00
XSLT_Handler Bug 13262 - Add parameters to XSLT Handler transform method 2015-02-05 15:24:29 -03:00
00-strict.t
Accounts.t Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
Acquisition.t Bug 7736 Add Edifact order fields to Acquisition.t 2016-04-01 20:03:17 +00:00
AdditionalField.t Bug 10855: Remove additional field values when subscription is removed 2015-10-02 15:10:31 -03:00
Amazon.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
AudioAlerts.t Bug 11431: (QA followup) remove diags 2015-11-06 15:08:37 -03:00
Auth.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Auth_with_cas.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Auth_with_ldap.t Bug 15889: LDAP authentication: Only update mapped attributes 2016-03-31 16:33:31 -06:00
AuthorisedValues.t Bug 10363: Use Koha::AuthorisedValue[s] in the admin page 2015-10-19 12:46:27 -03:00
AuthoritiesMarc.t Bug 10985: [UNIMARC] Fix authority summary 2015-04-22 11:54:36 -03:00
BackgroundJob.t Bug 13606: Add tests and fix existing ones 2015-04-23 13:18:49 -03:00
Barcodes.t Bug 15877 - Unit tests 2016-04-07 05:36:13 +00:00
Barcodes_ValueBuilder.t Bug 15081: (QA followup) Fix issue with Barcodes_ValueBuilder.t 2015-11-04 12:32:57 -03:00
Biblio.t Bug 14306: Follow-up for URLs in 555$u 2016-03-07 17:58:33 +00:00
BiblioObject.t Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
Bookseller.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Branch.t Bug 15629: Fix tests - Koha::Library does not have ->categories but ->get_categories 2016-02-24 03:55:07 +00:00
Breeding.t Bug 12898: (regression test) test terms inside double quotes 2014-09-14 02:02:51 -03:00
Budgets.t Bug 15004: Ensure that the reset_all_budgets behavior is kept 2016-01-27 06:05:02 +00:00
Category.t Bug 15081: (followup) Make test files using TestBuilder handle their transactions 2015-11-04 12:32:57 -03:00
Charset.t Bug 8218 : Add a maintenance script to sanitize biblio records 2014-11-11 15:38:36 -03:00
check_sysprefs.t Bug 14383: Fix some typos in comments and documentation 2015-06-22 17:34:46 -03:00
Circulation.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Circulation_Branch.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Circulation_dateexpiry.t Bug 15081: (followup) Make test files using TestBuilder handle their transactions 2015-11-04 12:32:57 -03:00
Circulation_issue.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Circulation_Issuingrule.t Bug 15757: Make GetLoanLength defaults to 0 instead of 21 2016-04-22 00:24:06 +00:00
Circulation_issuingrules.t Bug 15757: Make GetLoanLength defaults to 0 instead of 21 2016-04-22 00:24:06 +00:00
Circulation_OfflineOperation.t Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
Circulation_transfers.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
ClassSource.t
ColumnsSettings.t Bug 16177: Fix tests for ColumnsSsettings.t 2016-04-01 19:08:23 +00:00
Context.t Bug 11998: Use Koha::Cache to cache sysprefs 2016-03-15 07:08:28 +00:00
Contract.t Bug 14693: Contract.t should generate dates based on current date 2015-08-21 10:43:38 -03:00
CourseReserves.t Bug 15530 - Add Unit Test 2016-01-27 00:58:14 +00:00
Csv.t
db_structure.t Bug 16173: db_structure.t shouldn't have a fixed number of tests 2016-04-01 19:14:53 +00:00
DecreaseLoanHighHolds.t Bug 14694 [QA Followup] - Update Koha::Borrower references to Koha::Patron 2016-03-08 17:45:04 +00:00
default_search_class.pl Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
External_BakerTaylor.t
Filter_MARC_ViewPolicy.t Bug 15870: Follow up to address comment #20 2016-03-24 20:15:40 +00:00
Fines.t Bug 13590: Add ability to charge fines at start of charge period 2015-10-22 14:51:24 -03:00
FrameworkPlugin.t Bug 14199: Unify marc orgcode plugins, not overwriting existing values 2016-02-26 14:04:28 +00:00
Heading_MARC21.t
Hold.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Holds.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
HoldsQueue.t Bug 11998: Make HoldsQueue.t tests pass [TO REVERT] 2016-03-15 07:08:29 +00:00
Holidays.t Bug 15081: (followup) Make test files using TestBuilder handle their transactions 2015-11-04 12:32:57 -03:00
ILSDI_Services.t Bug 14257: Follow-up - Add documentation, fix typo, fix test 2016-03-31 20:31:06 +00:00
ImportBatch.t Bug 6520: Add unit test for C4::ImportBatch::GetRecordFromImportBiblio 2015-04-16 13:40:59 -03:00
Installer.t
Items.t Bug 11998: Use C4::Context->preference in Koha/Schema/Result/Item.pm 2016-03-15 07:08:28 +00:00
Items_DelItem.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
KitchenSinkPlugin.kpz
Koha.t Bug 16157: Move the selected flag from GetAuthorisedValues to the templates 2016-04-07 00:16:09 +00:00
Koha_Authority.t Bug 15578: Insert authority records before processing tests 2016-01-23 18:28:49 +00:00
Koha_borrower_modifications.t Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
Koha_Database.t Bug 13645: Cache the DBIx connection 2015-02-20 14:37:08 -03:00
Koha_Misc_Files.t
Koha_template_plugin_Branches.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Koha_template_plugin_KohaDates.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Languages.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Letters.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Linker_FirstMatch.t
Log.t Bug 15939: Action logs - Do not default dates to today 2016-03-02 00:53:14 +00:00
MarcModificationTemplates.t Bug 15669: Add a test for GetModificationTemplates 2016-03-03 22:11:44 +00:00
Members.t Bug 10612: (QA followup) 2016-04-01 19:52:14 +00:00
Members_Attributes.t Bug 15163: Do not erase patron attributes if limited to another library 2016-03-21 16:56:37 +00:00
Members_columns.t
MungeMarcPrice.t Bug 15084: Replace C4::Budgets::GetCurrencies with Koha::Acquisition::Currencies->search 2016-03-03 20:39:01 +00:00
NewsChannels.t Bug 14977: Followup to fix issue with NewsChannels.t 2015-10-29 11:58:52 -03:00
Overdues.t Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types 2015-12-31 12:47:16 +00:00
Passwordrecovery.t Bug 15585: Remove "shift on reference is experimental" warning 2016-03-22 23:08:21 +00:00
Patron.t Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
PatronLists.t
Patrons.t Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
Plugins.t Bug 12412: Add ability for plugins to convert arbitrary files to MARC from record staging tool 2015-05-04 15:33:51 -03:00
QueryParser.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Ratings.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Record.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
RecordProcessor_EmbedSeeFromHeadings.t Bug 15380: Move Koha::Authority to Koha::MetadataRecord::Authority 2015-12-31 18:50:41 +00:00
Reports.t Bug 5327: Shifting a db dependent test to the right place 2012-02-01 18:15:19 +01:00
Reports_Guided.t Bug 16224: Fix t/db_dependent/Reports_Guided.t 2016-04-20 19:48:44 +00:00
ReportsGuided.t Bug 15800: Koha::AuthorisedValues - Remove C4::Koha::IsAuthorisedValueCategory 2016-03-02 03:54:16 +00:00
Reserves.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Review.t Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
rollingloans.t Bug 13315 - Add feedback for last item checked out to circulation.pl 2015-04-13 14:52:26 -03:00
RotatingCollections.t Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
Search.t Bug 9819: Make the tests pass 2015-12-30 15:50:15 +00:00
Serials.t Bug 15168: Remove C4:Serials::ItemizeSerials 2015-11-17 15:34:00 -03:00
Serials_2.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Service.t
ShelfBrowser.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
SIP_ILS.t Bug 7904: (QA followup) fix tests 2015-02-05 15:50:32 -03:00
SIPILS.t Bug 15947: move SIPILS.t to DB-dependent test directory 2016-03-02 22:02:10 +00:00
Sitemapper.t Bug 14778: Example - Replace DBI::Mock with Test::DBIx::Class - Sitemapper.t 2015-10-23 12:01:18 -03:00
Stats.t
SuggestionEngine_ExplodedTerms.t Bug 12653: remaining prog reference in t/db_dependent/SuggestionEngine_ExplodedTerms.t 2014-10-29 23:37:54 -03:00
Suggestions.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
sysprefs.t Bug 11998: Use Koha::Cache to cache sysprefs 2016-03-15 07:08:28 +00:00
Tags.t Bug 12916 - Missing Test to demonstrate warnings. 2014-10-30 00:31:26 -03:00
Templates.t Bug 5338: (QA followup) update the tests for the new reports 2015-05-19 13:54:09 -03:00
TestBuilder.t Bug 15601: Fix TestBuilder tests 2016-01-23 19:01:41 +00:00
Upload.t Bug 14893: Separate temporary storage per instance in Upload.pm 2016-01-29 01:17:55 +00:00
UsageStats.t Bug 16176: Fix a test about OpenLibrarySearch 2016-04-01 19:10:25 +00:00
Virtualshelves.t Bug 14544: [QA Follow-up] Added some test descriptions 2015-11-05 10:00:31 -03:00
XISBN.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
XSLT_Handler.t Bug 13262: (QA followup) fix duplicate variable definition 2015-02-05 15:25:50 -03:00
zebra_config.pl Bug 15082: t/db_dependent/Search.t shouldn't mock the DB connection 2015-10-29 14:10:23 -03:00