Koha/C4
Jonathan Druart 76c38d10d0 Bug 27707: (bug 26639 follow-up) Fix renewals when RenewalSendNotice is set
Since bug 26639 we have auto savepoint enabled and the LOCK TABLE query
in C4::Circulation::SendCirculationAlert is not correctly handled.
From the MySQL doc that is copied few lines before, "LOCK TABLE will
commit any transactions", but here we don't have a savepoint and the
release for a non-existent savepoint will throw a DBI exception.

This patch removes the unecessary transaction and prevent the following
error when a renewal is done:
> DBIx::Class::Storage::DBI::mysql::_exec_svp_release(): DBI Exception: DBD::mysql::db do failed: SAVEPOINT savepoint_0 does not exist [for Statement "RELEASE SAVEPOINT savepoint_0"] at /usr/share/koha/lib/C4/Circulation.pm line 3590

Test plan:
1. Enable RenewalSendNotice
2. Add some email address to patron and select the email box from the message preference "Item checkout and renewal" in order to receive renewal emails.
3. Check 1 item out to a patron
4. Renew it

Signed-off-by: Andrew Nugged <nugged@gmail.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-02-16 14:51:23 +01:00
..
AuthoritiesMarc
Barcodes Bug 26673: Fix perlcritic complains 2020-11-02 08:42:20 +01:00
ClassSortRoutine
ClassSplitRoutine
Creators
External
Form
Heading
ILSDI Bug 17229: Check if patron is expired in CanItemBeReserved 2021-01-19 15:45:11 +01:00
Installer
Labels
Linker
Members Bug 24447: Changing 'DUE' to example in database that exists. 2021-01-22 13:46:41 +01:00
OAI Bug 25460: Update OAI sets when adding/editing/deleting item records 2020-10-15 12:56:30 +02:00
Output
Patroncards
Reports Bug 27380: Move get_prepped_report to object and use for svc/reports 2021-02-12 12:29:56 +01:00
Search
Serials
SIP Bug 27589: Access item fields as hash 2021-02-08 14:55:59 +01:00
Utils
Accounts.pm Bug 22394: Remove C4::Accounts::manualinvoice 2020-11-04 12:59:33 +01:00
Acquisition.pm Bug 26584: Remove unused C4::Acquisition::CloseBasket function 2020-11-05 15:24:20 +01:00
Auth.pm Bug 18506: (QA follow-up) opacShibOnly -> OPACShibOnly 2021-02-09 09:46:08 +01:00
Auth_cas_servers.yaml.sample
Auth_with_cas.pm
Auth_with_ldap.pm
Auth_with_shibboleth.pm
AuthoritiesMarc.pm Bug 25313: Add skip_merge to ModAuthority 2020-11-18 12:03:03 +01:00
BackgroundJob.pm
Barcodes.pm
Biblio.pm Bug 11299: (follow-up) Rebase on recent changes 2021-01-14 14:03:49 +01:00
Boolean.pm
Breeding.pm Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Budgets.pm
Calendar.pm
Charset.pm
Circulation.pm Bug 27707: (bug 26639 follow-up) Fix renewals when RenewalSendNotice is set 2021-02-16 14:51:23 +01:00
ClassSortRoutine.pm
ClassSource.pm
ClassSplitRoutine.pm
Context.pm Bug 24786: (follow-up) Cache the register_name in the session 2020-11-06 15:40:00 +01:00
Contract.pm
CourseReserves.pm
Creators.pm
Debug.pm
Heading.pm
HoldsQueue.pm Bug 27068: Perltidy _checkHoldPolicy 2021-02-12 13:08:56 +01:00
HTML5Media.pm Bug 27422: YouTube videos are HTTPS only 2021-02-08 17:09:34 +01:00
ImportBatch.pm Bug 27669: Fix 'importing' and 'reverting' statuses when importing/reverting a batch 2021-02-12 15:41:03 +01:00
ImportExportFramework.pm Bug 27569: Fix ODS export - take empty string into account 2021-02-16 10:22:13 +01:00
InstallAuth.pm Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Installer.pm Bug 27491: Rename system preference opaclanguages to OPACLanguages 2021-01-22 14:59:27 +01:00
ItemCirculationAlertPreference.pm
Items.pm Bug 4037: Correctly join the itemtypes array 2021-02-09 09:23:51 +01:00
Koha.pm
Labels.pm
Languages.pm Bug 27491: Rename system preference opaclanguages to OPACLanguages 2021-01-22 14:59:27 +01:00
Letters.pm Bug 26922: Better error handling in SendAlerts 2020-11-20 15:44:20 +01:00
Linker.pm
Log.pm
MarcModificationTemplates.pm
Matcher.pm
Members.pm Bug 27050: Allow multiple category_codes in delete_patrons.pl 2021-02-08 17:09:34 +01:00
Message.pm
NewsChannels.pm
Output.pm
Overdues.pm Bug 27079: Floating point comparison correction 2020-11-27 09:37:40 +01:00
Patroncards.pm
Record.pm Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Reports.pm Bug 27486: Rename system preference delimiter to CSVDelimiter 2021-01-29 09:03:45 +01:00
Reserves.pm Bug 26634: Remove GetHoldRule subroutine in C4::Reserves 2020-12-21 10:07:38 +01:00
Ris.pm Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
RotatingCollections.pm Bug 12556: (QA follow-up) Fix QA Script failures 2020-10-14 14:50:07 +02:00
Scheduler.pm
Scrubber.pm
Search.pm Bug 20410: Remove OpacGroupResults and PazPar2 2021-02-08 16:12:42 +01:00
Serials.pm
Service.pm Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
ShelfBrowser.pm Bug 26673: Remove shebangs from Perl modules 2020-10-26 00:14:42 +01:00
SMS.pm Bug 19134: C4::SMS falils on long driver name 2017-08-25 10:51:24 -03:00
SocialData.pm
Stats.pm
Suggestions.pm
Tags.pm
Templates.pm
TmplToken.pm
TmplTokenType.pm
TTParser.pm Bug 26673: Remove #!/usr/bin/env perl from .pm modules too 2020-10-26 00:14:42 +01:00
UsageStats.pm Bug 20410: Remove OpacGroupResults and PazPar2 2021-02-08 16:12:42 +01:00
XISBN.pm Bug 26364: Don't discard the passed isbn 2021-01-07 15:37:15 +01:00
XSLT.pm Bug 27581: Rename USeICU preference to UseICUStyleQuotes 2021-02-08 14:56:00 +01:00