Koha/t/db_dependent
Kyle M Hall 80897930b7 Bug 2720 - Overdues which debar automatically should undebar automatically when returned
This patch adds a more extensible and flexible debarments system to Koha. The fields
borrowers.debarred and borrowers.debarredcomment are retained for compatibility and
speed.

This system supports having debarments for multiple reasons. There are currently
three types of debarments:
OVERDUES    - Generated by overdue_notices.pl if the notice should debar a patron
SUSPENSION  - A punative debarment generated on checkin via an issuing rule
MANUAL      - A debarment created manually by a librarian

OVERDUE debarments are cleared automatically when all overdue items have been returned,
if the new system preference AutoRemoveOverduesRestrictions is enabled. It is disabled
by default to retain current default functionality.

Whenever a borrowers debarments are modified, the system updates the borrowers debarment
fields with the highest expiration from all the borrowers debarments, and concatenates
the comments from the debarments together.

Test plan:
 1) Apply patch
 2) Run updatedatabase.pl
 3) Verify the borrower_debarments table has been created and
    populated with the pre-existing debarments
 4) Run t/db_dependent/Borrower_Debarments.t
 5) Manually debar a patron, with an expiration date
 6) Verify the patron cannot be issued to
 7) Add another manual debarment with a different expiration date
 8) Verify the 'restricted' message lists the date farthest into the future
 9) Add another manual debarment with no expiration date
10) Verify the borrower is now debarred indefinitely
11) Delete the indefinite debarment
12) Verify the debarment message lists an expiration date dagain
13) Enable the new system preference AutoRemoveOverduesRestrictions
14) Set an overdue notice to debar after 1 day of being overdue
15) Check out an item to a patron and backdate the due date to yesterday
16) Run overdue_notices.pl
17) Verify the OVERDUES debarment was created
18) Return the item
19) Verify the OVERDUES debarment was removed
20) Disable AutoRemoveOverduesRestrictions
21) Repeat steps 15 though 18, verify the OVERDUES debarment was *not* removed
22) Add issuing rules so that an overdue item causes a temporary debarment
23) Check out an item to a patron and backdate the due date by a year
24) Return the item
25) Verify the SUSPENSION debarment was added to the patron

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
2013-10-31 01:53:22 +00:00
..
Acquisition Bug 7688: (follow-up) update test cases to reflect change in NewSubscription() 2013-10-30 02:27:20 +00:00
Circulation Bug 10599: (follow-up) fix incomplete test case 2013-09-18 16:56:23 +00:00
data Bug 7421: add regression tests for UNIMARC authorities DOM indexing 2013-10-10 21:02:04 +00:00
Labels Bug 10333: Labels/t_Batch.t needs to create its own data 2013-09-08 02:07:19 +00:00
LDAP
Members Bug 10481: Unit tests for C4::Members::AddEnrolmentFeeIfNeeded 2013-08-16 15:08:41 +00:00
Record
Reports
Serials Bug 7688: (follow-up) rewrite 'for' loop in unit tests 2013-10-30 00:38:52 +00:00
www Bug 8300: Add mechanized unit test for batch import 2013-05-01 07:57:11 -04:00
00-strict.t
Accounts.t
Acquisition.t Bug 10403: add ability to change fund on receipt 2013-10-22 12:57:25 +00:00
Amazon.t
Auth.t Bug 9611: (follow-up) move new password hashing routines to separate module 2013-10-09 03:29:22 +00:00
Auth_ParseSearchHistoryCookie.t move Auth_ParseSearchHistoryCookie.t to db_dependent directory 2013-07-28 19:42:51 +00:00
Auth_with_cas.t
AuthoritiesMarc.t
BackgroundJob.t Bug 10601: (follow-up) unit tests for new ->set() and ->get() 2013-09-18 17:21:47 +00:00
Barcodes.t
Biblio.t
Bookseller.t Bug 7688: (follow-up) update test cases to reflect change in NewSubscription() 2013-10-30 02:27:20 +00:00
Borrower_Debarments.t Bug 2720 - Overdues which debar automatically should undebar automatically when returned 2013-10-31 01:53:22 +00:00
Branch.t Bug 10508: (follow-up) remove Perl 5.14 construct 2013-08-28 14:24:34 +00:00
Budgets.t Bug 10535: (follow-up) wrap Budgets.t in transaction 2013-10-17 23:06:49 +00:00
check_sysprefs.t
Circulation.t Bug 7639: (follow-up) add Unit Tests 2013-09-17 15:22:07 +00:00
Circulation_Branch.t Bug 10683: (follow-up) improvements to the unit tests 2013-10-09 03:51:55 +00:00
Circulation_issue.t Bug 10493: (follow-up) fix test errors 2013-10-23 04:25:34 +00:00
Circulation_Issuingrule.t Bug 10767: (follow-up) remove FIXME comments 2013-08-28 14:44:01 +00:00
Circulation_issuingrules.t Bug 10298: Followup: Adapt existing code 2013-08-09 16:35:43 +00:00
Circulation_OfflineOperation.t Bug 10710: (follow-up) perltidy new code 2013-08-28 14:52:43 +00:00
Circulation_transfers.t Bug 10698: (follow-up) remove now-superfluous FIXME comment 2013-10-09 03:48:02 +00:00
ClassSource.t Bug 10644: (follow-up) remove inadvertant dependence on Perl 5.14 2013-08-09 18:53:20 +00:00
Context.t Bug 10927: remove disused C4::Utils module 2013-10-03 14:53:02 +00:00
CourseReserves.t Bug 10332: further improvements to course reserves tests 2013-06-18 16:40:43 -07:00
Csv.t Bug 10853: (follow-up) expand unit tests for C4::Csv 2013-10-11 03:25:42 +00:00
External_BakerTaylor.t
Heading_MARC21.t
Holds.t bug 2394: regression test for canreservefromotherbranches 2013-08-09 17:44:17 +00:00
HoldsQueue.t Bug 10243: (follow-up) add unit tests 2013-10-30 03:13:23 +00:00
Holidays.t
ILSDI_Services.t Bug 10667: (follow-up) fix reference to UT library in test case 2013-09-16 19:22:22 +00:00
Items.t Bug 10872: UT for GetHiddenItemnumbers and POD fix 2013-09-18 15:55:46 +00:00
KitchenSinkPlugin.kpz Bug 7804 - Add Koha Plugin System - QA Followup 3 - Additional Unit Tests 2013-03-20 14:50:38 -04:00
Koha.t Bug 10078: (follow-up) add regression test 2013-10-30 05:02:45 +00:00
Koha_Authority.t Bug 5202: merge authorities from the authority file and reservoir 2013-10-10 21:32:27 +00:00
Koha_borrower_modifications.t Bug 7067 - QA Followup - Fix failing tests 2012-12-14 08:09:01 -05:00
Koha_Database.t Bug 8798: moving code to Koha::Database and adding tests 2013-10-14 21:08:02 +00:00
Koha_template_plugin_KohaBranchName.t Bug 10494: test cases for the KohaBranchName plugin 2013-06-30 18:44:57 -07:00
Koha_template_plugin_KohaDates.t
Linker_FirstMatch.t
Log.t
Members.t Bug 10080 - Change system pref IndependantBranches to IndependentBranches 2013-05-22 07:58:23 -07:00
Members_columns.t Bug 7785: (follow-up) standardize POD 2013-08-13 16:15:30 +00:00
PatronLists.t Bug 10565: (follow-up) don't assume borrowernumber 1 exists in unit test 2013-10-14 21:30:34 +00:00
Plugins.t Bug 9909: Don't install KitchenSink plugin if plugin dir isn't writable 2013-03-22 21:52:41 -04:00
Ratings.t
Record.t bug 6201: (follow-up) update unit tests 2013-10-09 05:26:27 +00:00
RecordProcessor_EmbedSeeFromHeadings.t
Reports.t
Reports_Guided.t Bug 10761: (follow-up) remove inadvertant dependence on Perl 5.14 2013-08-21 16:29:18 +00:00
ReportsGuided.t Bug 9659 follow-up: correct syntax for older Perl 2013-04-26 21:32:49 -04:00
Reserves.t Bug 10949: restore ability to successfully print hold slips 2013-10-02 14:38:30 +00:00
rollingloans.t
RotatingCollections.t Bug 10653: (follow-up) minor tweaks to RotatingCollections tests 2013-08-16 16:09:13 +00:00
Search.t Bug 10271: regression test for search using indexes containing 'ns' 2013-10-28 16:10:33 +00:00
Search_SearchHistory.t Bug 10361: (follow-up) add tests for search history functions 2013-09-04 14:22:50 +00:00
Serials.t Bug 7688: (follow-up) rewrite t/db_dependant/Serials.t 2013-10-30 00:35:38 +00:00
Serials_2.t
Service.t
ShelfBrowser.t Bug 10856: Improve the previous and next items on the shelf browser 2013-10-04 15:56:35 +00:00
SIP_ILS.t
SQLHelper.t
SuggestionEngine_ExplodedTerms.t Bug 8846 conflict resolution: correct path 2012-11-01 08:41:30 -04:00
Suggestions.t
sysprefs.t Bug 10325: (follow-up) add test for overriding system preferences 2013-09-08 02:28:45 +00:00
Tags.t
UploadedFile.t
VirtualShelves.t Bug 10499: VirtualShelves.t - wrap tests in a database transaction 2013-07-16 14:17:27 +00:00
VirtualShelves_Page.t
XISBN.t Bug 10539: Followup for removing KohaTest unit tests 2013-09-05 15:06:05 +00:00
zebra_config.pl Bug 7421: add regression tests for UNIMARC authorities DOM indexing 2013-10-10 21:02:04 +00:00