Koha/Koha
Nick Clemens e3c31212df
Bug 33470: Don't calculate overridden hold limits
This patch can largely be checked in the code to ensure it makes sense, it
moves a conditional up one level for the two different checks that could prevent holds

To test:
1 - Attempt to place a hold via the REST API with an invalid pickup location
    Set pickup location as no in branches to make this easy
2 - Confirm you get an error
3 - Attempt again with header (bug 27760):
    x-koha-override: any
4 - Hold is placed
5 - Repeat 1-4 above but with an item that cannot be held
6 - Apply patch
7 - Repeat 1-4 above
8 - Results should be the same

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-05-05 10:18:37 -03:00
..
Account Bug 29021: (QA follow-up) Fix for new parameter, add unit test 2023-01-30 10:39:14 -03:00
Acquisition Bug 33262: Add new field to REST API route for orders 2023-05-05 10:18:34 -03:00
App
ArticleRequest
Auth Bug 31378: (QA follow-up) Defer store until JSON fields are populated 2022-11-18 12:29:55 -03:00
Authority
BackgroundJob Bug 32782: Koha to KBart mapping for UNIMARC 2023-05-05 09:13:19 -03:00
Biblio Bug 31889: (follow-up) Correct item order 2022-11-07 07:53:34 -03:00
BiblioUtils
Cache
Cash
Charges
Checkouts
Club
CodeList/Unimarc
Config
Course
Database Bug 33584: (follow-up) Remove DEFAULT_GENERATED from column info 2023-04-24 12:08:01 -03:00
Edifact
ERM Bug 33490: Fix ambiguous query error 2023-05-05 09:13:36 -03:00
Exceptions Bug 33229: Clear patron reading history when privacy is set to never 2023-04-14 15:39:41 -03:00
Exporter
ExternalContent
Filter/MARC
Hold
Illrequest Bug 21548: ILLLIBS patron category / partner_code seems extraneous 2023-03-31 12:14:51 +02:00
Import Bug 32437: (QA follow-up) Change to replace POD 2023-03-31 13:13:28 +02:00
Indexer
Item Bug 24606: (QA follow-up) Add test for encoding/decoding 2022-11-18 12:04:27 -03:00
Library
List
MetadataRecord
Middleware
Misc
Notice Bug 33360: Extend Koha::Notice::Util with domain groups 2023-04-14 11:35:30 -03:00
Number
OAI/Server
Object
Objects Bug 33083: Add a generic class to handle methods for collections of records 2023-03-13 15:11:59 -03:00
Old
Patron Bug 12029: Remove 'params' from filter_by_unread 2023-04-20 15:48:47 -03:00
Patrons Bug 31095: Remove GetDebarments from Patron::Import 2023-01-31 10:19:38 -03:00
pdfformat
Plugins Bug 29672: Clear cache of enabled plugins when a plugin's state change 2022-11-03 11:28:16 -03:00
RecordProcessor
REST Bug 33470: Don't calculate overridden hold limits 2023-05-05 10:18:37 -03:00
Result
Schema Bug 33262: DBIC schema 2023-05-05 10:18:34 -03:00
SearchEngine Bug 33159: Simplify ES handling and fix zebra handling 2023-03-31 11:56:53 +02:00
Serial
Sitemapper
SMS
SMTP Bug 27424: Clarify logic 2023-01-31 10:52:49 -03:00
Subscription
SuggestionEngine
Tags
Template/Plugin Bug 32127: Sort by description in Koha::Template::Plugin::Categories 2023-04-14 11:35:23 -03:00
Ticket Bug 31028: Add catalog concern management page to staff 2023-03-06 11:23:17 -03:00
UI Bug 32484: (QA follow-up) Few typos 2023-04-21 10:36:30 -03:00
Util
XSLT Bug 12758: Add new module call in Koha::XSLT::Base 2022-11-09 09:52:25 -03:00
Z3950Responder
Account.pm Bug 31895: (QA follow-up) Rollback change, add comment 2022-11-07 11:16:28 -03:00
ActionLog.pm
ActionLogs.pm
AdditionalContent.pm
AdditionalContents.pm
AdditionalField.pm
AdditionalFields.pm
AdditionalFieldValue.pm
AdditionalFieldValues.pm
AdvancedEditorMacro.pm
AdvancedEditorMacros.pm
ApiKey.pm
ApiKeys.pm
ArticleRequest.pm
ArticleRequests.pm
AudioAlert.pm
AudioAlerts.pm
AuthorisedValue.pm Bug 30920: (follow-up) Flush on delete 2023-03-13 15:11:44 -03:00
AuthorisedValueCategories.pm
AuthorisedValueCategory.pm Bug 32997: Add REST API endpoint to list authorised values for multiple given categories 2023-03-02 12:00:15 -03:00
AuthorisedValues.pm
Authorities.pm Bug 33083: Add a generic class to handle methods for collections of records 2023-03-13 15:11:59 -03:00
Authority.pm Bug 31794: Add REST endpoint to get an authority 2023-03-06 14:45:26 -03:00
AuthUtils.pm Bug 33341: Address some perlcritic errors in 5.36 2023-03-28 14:50:33 +02:00
BackgroundJob.pm Bug 33044: Return job id if there is no connection to rabbit 2023-03-06 09:51:45 -03:00
BackgroundJobs.pm Bug 31969: Use filter_by_last_update 2022-11-25 09:40:09 -03:00
Biblio.pm Bug 33447: Make *->pickup_locations methods throw an exception on missing parameter 2023-04-20 15:48:32 -03:00
BiblioFramework.pm
BiblioFrameworks.pm
Biblioitem.pm
Biblioitems.pm
Biblios.pm Bug 33447: Make *->pickup_locations methods throw an exception on missing parameter 2023-04-20 15:48:32 -03:00
BiblioUtils.pm
Cache.pm
Caches.pm
Calendar.pm
Checkout.pm
Checkouts.pm
CirculationRule.pm
CirculationRules.pm Bug 23012: (QA follow-up) Combine method to get both values 2022-10-24 17:43:29 -03:00
Cities.pm
City.pm
ClassSortRule.pm
ClassSortRules.pm
ClassSource.pm Bug 30920: (follow-up) Flush on delete 2023-03-13 15:11:44 -03:00
ClassSources.pm
ClassSplitRule.pm
ClassSplitRules.pm
Club.pm
Clubs.pm
Config.pm
CookieManager.pm
Course.pm
Courses.pm
CoverImage.pm
CoverImages.pm
CsvProfile.pm
CsvProfiles.pm
CurbsidePickup.pm
CurbsidePickupIssue.pm
CurbsidePickupIssues.pm
CurbsidePickupOpeningSlot.pm
CurbsidePickupOpeningSlots.pm
CurbsidePickupPolicies.pm
CurbsidePickupPolicy.pm Bug 32891: Fix slot selection in last hour 2023-02-21 10:22:28 -03:00
CurbsidePickups.pm
Database.pm
DateUtils.pm
Desk.pm
Desks.pm
EDI.pm Bug 28672: (QA follow-up) Method calls cannot be interpolated directly 2023-02-07 15:39:31 -03:00
Edifact.pm
Email.pm
Encryption.pm
Exception.pm
Exceptions.pm Bug 32334: Add general exception FileNotFound 2023-04-12 11:21:55 -03:00
ExternalContent.pm
FrameworkPlugin.pm
Hold.pm Bug 31894: Extend after_hold_action hook 2022-11-09 10:05:32 -03:00
Holds.pm Bug 32529: Add Koha::Holds->filter_by_found 2023-01-05 09:21:10 -03:00
I18N.pm
Illbackend.pm Bug 22440: Move backend statuses api endpoint 2023-05-05 09:13:43 -03:00
Illcomment.pm
Illcomments.pm
Illrequest.pm Bug 22440: New ILL requests table 2023-05-05 09:13:41 -03:00
Illrequestattribute.pm Bug 22440: Add standard accessors for later usage 2023-05-05 09:13:41 -03:00
Illrequestattributes.pm Bug 22440: New ILL requests table 2023-05-05 09:13:41 -03:00
Illrequests.pm Bug 22440: Add Koha::Illrequests->filter_by_visible 2023-05-05 09:13:40 -03:00
ImportBatch.pm
ImportBatches.pm
ImportBatchProfile.pm
ImportBatchProfiles.pm
Item.pm Bug 33447: Make *->pickup_locations methods throw an exception on missing parameter 2023-04-20 15:48:32 -03:00
Items.pm Bug 32019: (follow-up) Fix terminology and styling 2023-02-20 09:54:20 -03:00
ItemType.pm Bug 30920: (follow-up) Flush on delete 2023-03-13 15:11:44 -03:00
ItemTypes.pm
KeyboardShortcut.pm
KeyboardShortcuts.pm
Libraries.pm
Library.pm Bug 30920: (follow-up) Flush on delete 2023-03-13 15:11:44 -03:00
Linktracker.pm
Localization.pm Bug 30920: (follow-up) Flush on delete 2023-03-13 15:11:44 -03:00
Localizations.pm
Logger.pm Bug 33020: (QA follow-up) POD and chmod 2023-02-27 11:33:50 -03:00
Manual.pm Bug 33346: Add Help link to Koha manual in ERM module 2023-03-31 12:11:06 +02:00
MarcOverlayRule.pm
MarcOverlayRules.pm
MarcSubfieldStructure.pm
MarcSubfieldStructures.pm
MessageAttribute.pm
MessageAttributes.pm
MetadataIterator.pm
MetadataRecord.pm
MetaSearcher.pm
MoreUtils.pm
OAuth.pm
OAuthAccessToken.pm
OAuthAccessTokens.pm
Object.pm Bug 33161: (follow-up) Remove stray variables and fix POD 2023-03-10 10:20:10 -03:00
Objects.pm
Patron.pm Bug 33229: Remove unecessary txn 2023-04-14 15:39:42 -03:00
Patrons.pm Bug 31937: Fix Patrons::search_unsubscribed - sharpen condition 2022-11-17 13:41:24 -03:00
Plugins.pm Bug 29672: (QA follow-up) Add POD 2022-11-03 11:29:43 -03:00
ProblemReport.pm
ProblemReports.pm
PseudonymizedTransaction.pm
PseudonymizedTransactions.pm
Quote.pm
Quotes.pm
Rating.pm
Ratings.pm
RDF.pm
Recall.pm Bug 18398: Update C4::Message enqueue to use $patron->notice_email_address 2023-03-31 13:13:33 +02:00
Recalls.pm Bug 18398: Update C4::Message enqueue to use $patron->notice_email_address 2023-03-31 13:13:33 +02:00
RecordProcessor.pm
Report.pm
Reports.pm
Review.pm
Reviews.pm
Schema.pm
Script.pm
SearchEngine.pm
SearchField.pm
SearchFields.pm
SearchFilter.pm
SearchFilters.pm
SearchMarcMap.pm
SearchMarcMaps.pm
Serial.pm
Serials.pm
SharedContent.pm
SimpleMARC.pm
Sitemapper.pm
Statistic.pm
Statistics.pm
StockRotationItem.pm
StockRotationItems.pm
StockRotationRota.pm
StockRotationRotas.pm
StockRotationStage.pm
StockRotationStages.pm
Subscription.pm
Subscriptions.pm
Suggestion.pm
SuggestionEngine.pm
Suggestions.pm Bug 33238: Fix bad suggestions query (Bug 29886 follow-up) 2023-04-17 09:39:43 -03:00
Tag.pm
Tags.pm
Ticket.pm Bug 31028: (follow-up) Update notice module codes 2023-03-06 11:23:17 -03:00
Tickets.pm Bug 31028: Add new Koha::Object(s) classes 2023-03-06 11:23:17 -03:00
Token.pm
TrackedLink.pm
TrackedLinks.pm
UploadedFile.pm
UploadedFiles.pm
Uploader.pm
Virtualshelf.pm
Virtualshelfcontent.pm
Virtualshelfcontents.pm
Virtualshelfshare.pm
Virtualshelfshares.pm
Virtualshelves.pm
Z3950Responder.pm
Z3950Server.pm
Z3950Servers.pm