Katrin Fischer 8218653df7 Bug 18680: Add an empty entry by default to sort1/sort2 values in patron account ... When using sort1/sort2 with authorised values to create a pull down list, there will be no empty entry unless one is manually added to the authorised values list. This is not a good default behaviour, as it can easily cause errors on patron creation. Without the empty entry, the first alphabetic value is pre-selected and will be saved if not explicitly changed. It also doesn't allow to mark sort1/sort2 as mandatory, as the value is always 'set', the required message won't be triggered. This adds an empty parameter to av-build-dropbox.inc to allow selectively adding this empty entry without causing side-effects in other places this include is used. To test: - Create authorised values for either Bsort1 or Bsort2 authorised value category - Create a new patron: - you should see a pull down list on one and an input field for the other - for the pull down list, there will be no empty entry and the first alphabetic value will be preselected - Make your sort1 and sort2 mandatory using BorrowerMandatoryField - Verify there is still on empty entry - Apply patch - Repeat tests and verify that the behaviour is as expected - There should now be an empty entry - When the field is marked mandatory and empty is left, the required warning will be shown. Signed-off-by: David Roberts <david@koha-ptfs.co.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>		2020-04-20 12:28:04 +01:00
..
catalogue	Bug 18433: Add missing filter	2020-02-19 16:07:58 +00:00
csv_headers	Bug 12502: Add vendor note, internal note, ordernumber and isbn to late orders page	2020-01-20 16:37:21 +00:00
mana	Bug 23013: Upgrade DataTables in the staff client	2019-08-22 15:23:19 +01:00
modals
str	Bug 8643: Add important constraint to marc subfields	2020-02-11 14:33:29 +00:00
virtualshelves/merge
about-team.inc	Bug 24402: About template corrections	2020-03-16 11:01:35 +00:00
accounts.inc	Bug 25010: Fix typo 'rewewal' in debit types	2020-04-03 14:26:35 +01:00
acquisitions-add-to-basket.inc	Bug 24347: Add a 'search to order' option similar to 'search to hold'	2020-01-30 10:58:03 +00:00
acquisitions-menu.inc	Bug 22868: Move suggestions_manage subperm out of acquisition perm	2020-01-30 08:27:00 +00:00
acquisitions-search.inc
acquisitions-toolbar.inc	Bug 22957: Remove type attribute from script tags: Staff client includes 1/2	2019-07-15 11:27:58 +01:00
additem.js.inc	Bug 22957: Remove type attribute from script tags: Staff client includes 1/2	2019-07-15 11:27:58 +01:00
additional-fields-display.inc
additional-fields-entry.inc
admin-items-search-field-form.inc
admin-menu.inc	Bug 4461: Add problem reports link to mainpage and admin home	2020-04-06 11:18:20 +01:00
adv-search.inc
auth-finder-search.inc
authorities-search-results.inc
authorities-search.inc
authorities-toolbar.inc	Bug 22023: Further improve responsive layout handling of staff client menu bar	2019-03-13 05:31:28 +00:00
authorities.inc
authorities_js.inc	Bug 23947: Phase out jquery.cookie.js: Authority merge	2020-01-29 09:09:33 +00:00
av-build-dropbox.inc	Bug 18680: Add an empty entry by default to sort1/sort2 values in patron account	2020-04-20 12:28:04 +01:00
biblio-default-view.inc
biblio-title-head.inc	Bug 11529: Prevent too many spaces/break lines in the title tag	2019-08-05 18:43:26 +01:00
biblio-title.inc	Bug 11529: (follow-up) Fix QA issues	2019-08-05 15:03:19 +01:00
biblio-view-menu.inc	Bug 10352: Use a new object_type parameter instead of the module's name	2020-01-10 08:36:37 +00:00
blocked-fines.inc	Bug 21757: Clenup of moremember.pl and its templates	2019-04-29 12:12:40 +00:00
blocking_errors.inc	Bug 22786: Prevent fund creation for locked budgets	2019-09-06 13:17:47 +01:00
borrower_debarments.inc
branch-selector.inc	Bug 23184: Don't select branches for export by default	2019-11-21 11:32:31 +00:00
budgets-active-currency.inc
budgets-admin-search.inc
budgets-admin-toolbar.inc	Bug 22786: Prevent fund creation for locked budgets	2019-09-06 13:17:47 +01:00
calendar.inc	Bug 23268: Make "Suspend all holds" calendar select a date from tomorrow	2020-03-10 15:20:19 +00:00
cat-menu.inc
cat-search.inc
cat-toolbar.inc	Bug 8595: Rename 'host item' to 'host record'	2020-03-20 15:35:15 +00:00
catalog-strings.inc	Bug 22957: Remove type attribute from script tags: Staff client includes 1/2	2019-07-15 11:27:58 +01:00
cataloging-search.inc
cateditor-ui.inc	Bug 24789: [follow-up] Fix saving of macros	2020-03-16 15:08:36 +00:00
cateditor-widgets-marc21.inc	Bug 23045: TextMarc errors on blank lines	2019-07-01 14:52:37 +01:00
category-out-of-age-limit.inc	Bug 17492: (QA follow-up) Correct template variable	2019-07-01 15:20:31 +01:00
chart.inc	Bug 23626: [alternate] Default to including all rows	2019-10-09 14:31:59 +01:00
checkin-search.inc
checkouts-table-footer.inc	Bug 20194: Display both biblioitems.itemtype and items.itype in circulation screens	2019-11-03 07:50:19 +00:00
checkouts-table.inc	Bug 20194: Display both biblioitems.itemtype and items.itype in circulation screens	2019-11-03 07:50:19 +00:00
circ-menu.inc	Bug 25069: Fix AddressFormat="fr" behavior	2020-04-14 08:25:31 +01:00
circ-nav.inc	Bug 24837: Rename selectbranchprinter.pl to set-library.pl	2020-03-24 11:07:22 +00:00
circ-patron-search-results.inc	Bug 24627: Correct style of clubs search results during hold process	2020-03-16 10:59:28 +00:00
circ-search.inc
cities-admin-search.inc
clubs-table.inc	Bug 24627: Correct style of clubs search results during hold process	2020-03-16 10:59:28 +00:00
columns_settings.inc	Bug 12502: (follow-up) Adds formatting for datatables export	2020-01-20 16:37:21 +00:00
contracts-admin-search.inc
country-list.inc
currencies-admin-search.inc
datatables.inc	Bug 24662: Remove global variables MSG_* from datatables.inc	2020-03-11 13:49:15 +00:00
date-format.inc
delimiter_text.inc
desks-admin-search.inc	Bug 13881: Add desk management	2020-03-25 09:19:15 +00:00
doc-head-close-receipt.inc
doc-head-close.inc	Bug 24661: (RM follow-up) Check lang is defined	2020-02-25 14:28:54 +00:00
doc-head-open.inc	Bug 24732: Set DumpTemplateVars Dumper options for Indent and Sort	2020-03-02 10:08:31 +00:00
empty_line.inc
facets.inc	Bug 14715: (follow-up) Keep results per page setting when selecting facets and sorting results	2020-03-26 12:03:42 +00:00
filter-orders.inc	Bug 14669: (RM follow-up) Ensure updated include compiles	2019-10-09 07:30:51 +01:00
form-blocks.inc
format_price.inc	Bug 22957: Remove type attribute from script tags: Staff client includes 1/2	2019-07-15 11:27:58 +01:00
greybox.inc	Bug 22957: Remove type attribute from script tags: Staff client includes 1/2	2019-07-15 11:27:58 +01:00
guided-reports-view.inc
header.inc	Bug 24837: Rename selectbranchprinter.pl to set-library.pl	2020-03-24 11:07:22 +00:00
holds_table.inc	Bug 24802: Updating holds can cause suspensions to apply to wrong hold	2020-03-06 09:56:40 +00:00
home-search.inc
html_helpers.inc
i18n.inc
ill-availability-table.inc	Bug 23173: (follow-up) Fix QA script errors	2020-04-06 11:05:14 +01:00
ill-list-table-strings.inc	Bug 18589: (follow-up) Fix QA tool failures	2019-03-22 20:21:47 +00:00
ill-list-table.inc	Bug 18589: (follow-up) Fix QA tool failures	2019-03-22 20:21:47 +00:00
ill-toolbar.inc	Bug 22099: Fixed ILL toolbar to say Refresh when displaying requests	2019-06-03 18:56:29 +01:00
installer-doc-head-close.inc	Bug 22451: Use Asset everywhere	2019-04-16 13:17:32 +00:00
installer-intranet-bottom.inc	Bug 22451: Use Asset everywhere	2019-04-16 13:17:32 +00:00
installer-strings.inc	Bug 22973: Remove type attribute from script tags: Staff client includes 2/2	2019-05-30 10:25:21 +00:00
intranet-bottom.inc	Bug 24230: fix intranet_js plugin hook before body end tag	2019-12-13 15:28:33 +00:00
intranetstylesheet.inc
js-date-format.inc	Bug 24455: (follow-up) Document function	2020-03-25 13:54:19 +00:00
js_includes.inc	Bug 23944: Phase out use of jquery.cookie.js in favor of js.cookie.js	2020-01-29 09:08:30 +00:00
keyboard_shortcuts.inc	Bug 17179: Add keyboard shortcuts to repeat (duplicate) a field, and cut text	2019-10-09 14:36:09 +01:00
labels-toolbar.inc	Bug 7468: Print barcodes by range	2020-01-21 11:28:19 +00:00
langmenu-staff-top.inc
last-borrower.inc
letters-search.inc
member-alt-address-style-de.inc	Bug 3766: Cities/Towns only on one address	2019-04-17 12:25:25 +00:00
member-alt-address-style-fr.inc	Bug 3766: Cities/Towns only on one address	2019-04-17 12:25:25 +00:00
member-alt-address-style-us.inc	Bug 3766: Cities/Towns only on one address	2019-04-17 12:25:25 +00:00
member-alt-contact-style-de.inc	Bug 3766: Cities/Towns only on one address	2019-04-17 12:25:25 +00:00
member-alt-contact-style-fr.inc	Bug 3766: Cities/Towns only on one address	2019-04-17 12:25:25 +00:00
member-alt-contact-style-us.inc	Bug 3766: Cities/Towns only on one address	2019-04-17 12:25:25 +00:00
member-display-address-style-de.inc
member-display-address-style-fr.inc
member-display-address-style-us.inc
member-display-alt-address-style-de.inc
member-display-alt-address-style-fr.inc
member-display-alt-address-style-us.inc
member-main-address-style-de.inc	Bug 3766: Cities/Towns only on one address	2019-04-17 12:25:25 +00:00
member-main-address-style-fr.inc	Bug 3766: Cities/Towns only on one address	2019-04-17 12:25:25 +00:00
member-main-address-style-us.inc	Bug 3766: Cities/Towns only on one address	2019-04-17 12:25:25 +00:00
members-toolbar.inc	Bug 24776: Remove Borrowers.HasOverdues call	2020-03-16 14:52:07 +00:00
merge-record-strings.inc
merge-record.inc
messaging-preference-form.inc	Bug 22744: Remove the 'do not notify' buttons	2019-09-23 11:57:40 +01:00
noadd-warnings.inc
onboarding_messages.inc
page-numbers.inc	Bug 14715: (follow-up) Keep results per page setting when selecting facets and sorting results	2020-03-26 12:03:42 +00:00
password_check.inc	Bug 22973: Remove type attribute from script tags: Staff client includes 2/2	2019-05-30 10:25:21 +00:00
patron-article-requests.inc
patron-return-claims.inc	Bug 14697: Enhance the return claims feature	2019-10-31 12:04:21 +00:00
patron-search-box.inc	Bug 23697: (QA follow-up) Rename PatronAutocompletion to PatronAutoComplete	2019-10-08 14:51:12 +01:00
patron-search.inc	Bug 17374: (follow-up) Remove spaces from include file	2020-03-10 15:18:29 +00:00
patron-title.inc	Bug 24514: Add option to exclude title from patron-title.inc	2020-02-19 11:18:15 +00:00
patron-toolbar.inc	Bug 22023: Further improve responsive layout handling of staff client menu bar	2019-03-13 05:31:28 +00:00
patroncards-errors.inc	Bug 24837: Rename selectbranchprinter.pl to set-library.pl	2020-03-24 11:07:22 +00:00
patroncards-toolbar.inc	Bug 22698: Fix incorrect button classes	2019-04-16 13:17:33 +00:00
patronfields.inc	Bug 17374: (QA follow-up) Make search labels match with patron record	2020-03-10 15:18:29 +00:00
patrons-admin-search.inc
payments.inc	Bug 24525: (QA follow-up) Make payment type required with cash registers	2020-02-10 09:17:22 +00:00
permissions.inc	Bug 4461: Adding user flags for managing OPAC problem reports	2020-04-06 11:18:13 +01:00
popup-bottom.inc
pos-menu.inc	Bug 25138: Terminology: Point of sale should use library instead of branch	2020-04-17 13:50:23 +01:00
prefs-admin-search.inc
prefs-menu.inc	Bug 23321: (RM follow-up) Accounts vs. Accounting	2019-09-27 10:37:19 +01:00
quotes-toolbar.inc	Bug 22023: Further improve responsive layout handling of staff client menu bar	2019-03-13 05:31:28 +00:00
quotes-upload-toolbar.inc	Bug 22698: Fix incorrect button classes	2019-04-16 13:17:33 +00:00
relatives-issues-table.inc	Bug 22468: Standardize on labelling ccode table columns as Collections	2020-04-15 12:32:49 +01:00
renew_results.inc	Bug 23051: (QA follow-up) Missing curly and tabs and fix test	2020-03-06 10:03:41 +00:00
renew_strings.inc	Bug 23051: (follow-up) Add renewal feedback and move code to subroutines and test	2020-03-06 10:03:34 +00:00
reports-menu.inc	Bug 20415: add Koha.ArePluginsEnabled Template Toolkit method	2020-03-26 11:41:54 +00:00
reports-toolbar.inc	Bug 23812: Download icon is an upload icon	2019-10-17 14:53:43 +01:00
resort_form.inc	Bug 25014: Fix capitalization for "Call Number" in staff and OPAC sort options	2020-04-03 14:26:34 +01:00
rotating-collections-toolbar.inc	Bug 22698: Fix incorrect button classes	2019-04-16 13:17:33 +00:00
search_indexes.inc
select2.inc	Bug 22451: Use Asset everywhere	2019-04-16 13:17:32 +00:00
serials-menu.inc	Bug 23446: Fix display issue in serials navigation	2019-08-16 11:41:55 +01:00
serials-search.inc
serials-toolbar.inc	Bug 23065: Rename "New subscription" button when default to current serial	2019-06-13 12:28:00 +01:00
slip-print.inc	Bug 22973: Remove type attribute from script tags: Staff client includes 2/2	2019-05-30 10:25:21 +00:00
stockrotation-toolbar.inc	Bug 22209: Move stock rotation stage and item forms into modals	2019-08-08 16:05:50 +01:00
strings.inc	Bug 23885: Move staff client search results JavaScript into separate file	2020-01-29 09:05:01 +00:00
subscriptions-search.inc
subtypes_unimarc.inc
suggestions-add-search.inc
timepicker.inc	Bug 22973: Remove type attribute from script tags: Staff client includes 2/2	2019-05-30 10:25:21 +00:00
tools-item-action.inc
tools-menu.inc	Bug 9422: Don't allow access to 'Upload patron images' when patronimages syspref is off	2020-04-03 14:26:32 +01:00
tools-nomatch-action.inc	Bug 23236: Remove 'its items may still be processed' in action if no match is found	2020-03-18 08:41:35 +00:00
tools-overlay-action.inc
validator-strings.inc	Bug 22973: Remove type attribute from script tags: Staff client includes 2/2	2019-05-30 10:25:21 +00:00
vendor-menu.inc
virtualshelves-toolbar.inc	Bug 22698: Fix incorrect button classes	2019-04-16 13:17:33 +00:00
waiting_holds.inc	Bug 24514: Add option to exclude title from patron-title.inc	2020-02-19 11:18:15 +00:00
wysiwyg-systempreferences.inc	Bug 22661: TinyMCE/WYSIWYG editor doesn't translate	2019-11-03 07:39:54 +00:00
xslt-handler.inc
z3950-admin-search.inc
z3950_search.inc	Bug 22973: Remove type attribute from script tags: Staff client includes 2/2	2019-05-30 10:25:21 +00:00