Koha/Koha
Martin Renvoize 693a0449d0 Bug 24434: Reinstate updateWrongTransfer
This patch re-instates the call to updateWrongTransfer to ensure the
transfer line is updated to reflect the new frombranch.

Test plan
note: when applying the patches, also update the database

1/ Check an item out from it's home library
2/ Check the item in at another library
   (with AutomaticItemReturn system preferences enabled)
2a/ Accept the transfer and note we now have a transfer present from the
    items check-in library to it's home library
3/ Check the item in at a third library
3a/ Note you are asked to return the item to it's home library.
3b/ With the patch applied, the modal title should highlight that a
    'Wrong transfer' was detected.
4/ Go to the item record and note the holding library has been updated
   to reflect where the item was most recently checked in.
4a/ With the patch applied the item status should reflect the last
    checked in branch as the 'from' branch of the transfer.
5/ check-in from a 4th library, but use the 'Print slip' option for
   accepting the transfer and confirm that also works.
6/ check-in from a 5th library, but use the 'Cancel' option and check
   that this results in the item staying at it's current location and the
   final transfer having been cancelled.

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2021-06-18 10:37:17 -04:00
..
Account Bug 28482: Refresh line from DB to get stored value 2021-06-18 06:33:27 -04:00
Acquisition Bug 23971: Rename pref with AcquisitionLog 2021-04-23 11:58:49 +02:00
App
ArticleRequest
Authority
BackgroundJob
Biblio
BiblioUtils
Cache
Cash
Charges
Checkouts
Club Bug 28272: Fix many things... 2021-05-11 09:04:13 +02:00
Config
Course
Edifact Bug 27793: Store FTX free text in vendor note 2021-05-07 14:44:00 +02:00
Exceptions Bug 26312: (follow-up) Fix passing of exception messages 2021-04-16 11:48:31 +02:00
Exporter
ExternalContent
Filter/MARC Bug 23583: Handle OpacHiddenItems with yaml_preference 2021-04-21 15:25:07 +02:00
Illrequest
Indexer
Item Bug 24434: Reinstate updateWrongTransfer 2021-06-18 10:37:17 -04:00
Library
List
MetadataRecord Bug 28268: Improve memory usage when indexing authorities in Elasticsearch 2021-05-17 12:34:33 +02:00
Middleware
Misc
Notice
Number
OAI/Server Bug 27584: Refactor OAI-PMH paging to improve performance 2021-05-07 14:44:00 +02:00
Object
Objects Bug 23271: Prevent crash if called without parameters 2021-04-21 15:25:07 +02:00
Old Bug 28272: Fix note_seen, desk_id, cancellation_reason 2021-05-10 17:55:30 +02:00
Patron Bug 28220: Add more tests 2021-05-17 12:29:23 +02:00
Patrons Bug 28220: UI changes 2021-05-17 12:29:24 +02:00
pdfformat
Plugins
RecordProcessor
REST Bug 27931: Add GET /items/:item_id/pickup_locations 2021-06-18 08:44:45 -04:00
Schema Bug 28490: Add DBIx schema changes for testing 2021-06-18 07:47:34 -04:00
SearchEngine Bug 27724: Use lenient also in Elasticsearch authorities search 2021-05-19 14:52:19 +02:00
Serial
Sitemapper
SMS
SMTP
Subscription
SuggestionEngine
Tags
Template/Plugin Bug 24154: (follow-up) Make parameter and variable more explicit, add tests 2021-05-10 10:27:53 +02:00
Util Bug 22569: Add a 'Transfers to send' report 2021-03-11 11:51:40 +01:00
XSLT
Z3950Responder
Account.pm Bug 27636: (QA follow-up) Restore force AutoReconcile 2021-04-30 17:07:31 +02:00
ActionLog.pm
ActionLogs.pm
AdditionalField.pm
AdditionalFields.pm
AdditionalFieldValue.pm
AdditionalFieldValues.pm
AdvancedEditorMacro.pm
AdvancedEditorMacros.pm
ApiKey.pm
ApiKeys.pm
ArticleRequest.pm
ArticleRequests.pm
AudioAlert.pm
AudioAlerts.pm
AuthorisedValue.pm
AuthorisedValueCategories.pm
AuthorisedValueCategory.pm
AuthorisedValues.pm
Authorities.pm
Authority.pm
AuthUtils.pm
BackgroundJob.pm Bug 26742: Remove die from connect 2021-03-05 12:27:22 +01:00
BackgroundJobs.pm
Biblio.pm Bug 18989: (QA follow-up) Make Koha::Biblio->hidden_in_opac aware of OpacHiddenItemsHidesRecord 2021-05-12 14:12:07 +02:00
BiblioFramework.pm
BiblioFrameworks.pm
Biblioitem.pm
Biblioitems.pm
Biblios.pm Bug 28273: Add Koha::Biblios->pickup_locations 2021-05-20 08:43:34 +02:00
BiblioUtils.pm
Cache.pm Bug 28276: Do not fetch config ($KOHA_CONF) from memcached 2021-05-10 10:28:04 +02:00
Caches.pm
Calendar.pm
Checkout.pm Bug 28272: Fix note_seen, desk_id, cancellation_reason 2021-05-10 17:55:30 +02:00
Checkouts.pm Bug 23207: Automatic checkin items should never be overdue 2021-04-22 14:37:14 +02:00
CirculationRule.pm
CirculationRules.pm
Cities.pm
City.pm
ClassSortRule.pm
ClassSortRules.pm
ClassSource.pm
ClassSources.pm
ClassSplitRule.pm
ClassSplitRules.pm
Club.pm
Clubs.pm
Config.pm Bug 28276: Do not fetch config ($KOHA_CONF) from memcached 2021-05-10 10:28:04 +02:00
Course.pm
Courses.pm
CoverImage.pm
CoverImages.pm
CsvProfile.pm
CsvProfiles.pm
Database.pm Bug 28276: Do not fetch config ($KOHA_CONF) from memcached 2021-05-10 10:28:04 +02:00
DateUtils.pm
Desk.pm
Desks.pm
EDI.pm Bug 27793: Store FTX free text in vendor note 2021-05-07 14:44:00 +02:00
Edifact.pm
Email.pm Bug 28017: Allow non-FQDN (@localhost) addresses 2021-04-01 18:51:37 +02:00
Exceptions.pm
ExternalContent.pm
FrameworkPlugin.pm
Hold.pm Bug 28254: (QA follow-up) override -> force 2021-05-04 14:22:08 +02:00
Holds.pm Bug 27069: Adapt uses of holdallowed 2021-04-07 16:08:04 +02:00
I18N.pm
Illcomment.pm
Illcomments.pm
Illrequest.pm
Illrequestattribute.pm
Illrequestattributes.pm
Illrequests.pm
ImportBatch.pm
ImportBatches.pm
ImportBatchProfile.pm
ImportBatchProfiles.pm
Item.pm Bug 27064: (QA follow-up) Pass 'replace' through to Koha::Item::Transfer->cancel 2021-06-18 07:11:51 -04:00
Items.pm Bug 28286: Replace < 1 with <= 0 2021-05-10 15:46:55 +02:00
ItemType.pm
ItemTypes.pm
KeyboardShortcut.pm
KeyboardShortcuts.pm
Libraries.pm
Library.pm Bug 22569: Add a 'Transfers to send' report 2021-03-11 11:51:40 +01:00
Linktracker.pm
Localization.pm
Localizations.pm
Logger.pm
Manual.pm
MarcSubfieldStructure.pm
MarcSubfieldStructures.pm
MessageAttribute.pm
MessageAttributes.pm
MetadataIterator.pm
MetadataRecord.pm
MetaSearcher.pm
MoreUtils.pm
News.pm
NewsItem.pm
OAuth.pm
OAuthAccessToken.pm
OAuthAccessTokens.pm
Object.pm Bug 27819: Fix Object POD 2021-04-28 11:16:14 +02:00
Objects.pm Bug 21549: Make filter_by_last_update returns a Koha::Objects-based object 2021-04-14 15:34:27 +02:00
Patron.pm Bug 28490: Revert "Bug 26995: Remove references to relationship column" 2021-06-18 07:47:34 -04:00
Patrons.pm Bug 21549: Rename filter_by_dateexpiry with filter_by_expiration_date 2021-04-14 15:34:27 +02:00
Plugins.pm
ProblemReport.pm
ProblemReports.pm
PseudonymizedTransaction.pm
PseudonymizedTransactions.pm
Quote.pm
Quotes.pm
Rating.pm
Ratings.pm
RDF.pm
RecordProcessor.pm
Report.pm Bug 24695: (QA follow-up) Fix POD 2021-04-12 15:27:50 +02:00
Reports.pm Bug 24695: Move to Koha::Report->is_sql_valid 2021-04-12 15:27:50 +02:00
Review.pm
Reviews.pm
Schema.pm
Script.pm
SearchEngine.pm Bug 24000: Some modules do not return 1 2021-04-06 15:56:30 +02:00
SearchField.pm
SearchFields.pm
SearchMarcMap.pm
SearchMarcMaps.pm
Serial.pm
Serials.pm
SharedContent.pm
SimpleMARC.pm
Sitemapper.pm
Statistic.pm
Statistics.pm
StockRotationItem.pm Bug 22569: Add a 'Transfers to send' report 2021-03-11 11:51:40 +01:00
StockRotationItems.pm
StockRotationRota.pm
StockRotationRotas.pm
StockRotationStage.pm
StockRotationStages.pm
Subscription.pm
Subscriptions.pm
Suggestion.pm
SuggestionEngine.pm
Suggestions.pm
Tag.pm
Tags.pm
Token.pm
UploadedFile.pm Bug 28123: Quote filename value in Content-Disposition header 2021-04-16 12:28:18 +02:00
UploadedFiles.pm
Uploader.pm
Virtualshelf.pm
Virtualshelfcontent.pm
Virtualshelfcontents.pm
Virtualshelfshare.pm
Virtualshelfshares.pm
Virtualshelves.pm
Z3950Responder.pm
Z3950Server.pm
Z3950Servers.pm