Main Koha release repository https://koha-community.org
Find a file
Jan Kissig 909a72c58f
Bug 36880: Record overlay rules are not validated
This patch fixes validation of rules, confirmation on deletion of rules and removes some unused source code.

1) Validation of record overlay rules on edit and add action
2) Validation when editing an existing rule
3) Adds confirm when deleting multiple rules

Test plan:
1)
 a) open http://localhost:8081/cgi-bin/koha/admin/marc-overlay-rules.pl
 b) just click + Add rule
 c) a new rule with an empty tag is saved

2)
 a) edit an existing rule
 b) empty input value for tag
 c) click Save and check that the rule has now an empty value for tag

3)
 a) delete a rule by checking the checkbox and clicking Delete selected
 b) delete a rule by clicking the Delete button under Actions
 c) notice that b) asks for confirmation

apply patch
1) redo steps and check that form does not get submitted and the input is marked as required

2) redo steps and check that clicking on Save will not submit the form and mark input as required

3) redo steps and check that a standard confirm popup appears

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-06-27 11:50:06 +02:00
acqui Bug 37152: Aquisitions basket and OPAC suggestion deletion should use the op cud-delete 2024-06-27 11:49:57 +02:00
admin Bug 36880: Record overlay rules are not validated 2024-06-27 11:50:06 +02:00
api Bug 37021: Change item_id type as integer in holds endpoint 2024-06-11 11:54:48 +01:00
authorities Bug 25387: (QA follow-up) Tidy 2024-06-27 11:49:59 +02:00
basket
bin
bookings
C4 Bug 37016: Invalid due date in SIP renew response 2024-06-27 11:50:05 +02:00
catalogue Bug 35294: Fix typos in catalogue code comments 2024-06-13 14:26:22 +01:00
cataloguing Bug 36794: Illegitimate modification of biblionumber subfield content (999 $c) 2024-05-13 10:36:11 +02:00
circ Bug 37014: Fix after-modal-POST to transmit "not_returned" message 2024-06-21 15:02:53 +02:00
clubs
course_reserves
debian Bug 33563: Add comments for Elasticsearch security config 2024-06-27 11:49:58 +02:00
docs Bug 37003: (follow-up) Amend 22.11 RMaint 2024-06-25 18:34:14 +02:00
erm
errors
etc Bug 33563: Add comments for Elasticsearch security config 2024-06-27 11:49:58 +02:00
ill Bug 35106: CSRF fix 2024-04-29 18:53:09 +02:00
installer Bug 33317: DBRev 24.06.00.009 2024-06-25 18:34:19 +02:00
Koha Bug 37157: Fix Malformed UTF-8 character in JSON string before decode_json 2024-06-27 11:50:06 +02:00
koha-tmpl Bug 36880: Record overlay rules are not validated 2024-06-27 11:50:06 +02:00
labels Bug 36931: Fix label-item-search.pl by removing CSRF requirement 2024-05-24 15:36:46 +02:00
lib Bug 35681: Use ::Bootstrap version of FromANSI 2024-05-02 16:47:39 +02:00
members Bug 36476: Add holds priority column to members/summary-print.pl pending holds table 2024-06-21 15:02:57 +02:00
misc Bug 37036: Pass along the branches table for auto renewals 2024-06-21 15:02:55 +02:00
offline_circ
opac Bug 37152: Aquisitions basket and OPAC suggestion deletion should use the op cud-delete 2024-06-27 11:49:57 +02:00
patron_lists
patroncards Bug 36877: (follow-up) Fix op eq edit to op eq edit_form in edit-batch.pl 2024-05-17 12:03:52 +02:00
plugins
pos Bug 33478: Apply formatting to RECEIPT 2024-04-26 20:15:44 +02:00
preservation
recalls Bug 33478: Apply formatting to RECALL_REQUESTER_DET 2024-04-26 20:15:45 +02:00
reports Bug 36380: Add filter value on patron statistics report summary 2024-05-10 15:19:11 +02:00
reserve Bug 30579: Disentangle multi-hold and single bib forms 2024-05-07 15:53:57 +02:00
reviews
rotating_collections
serials Bug 37165: Can't edit frequencies due to stray cud- in modify op 2024-06-27 11:49:57 +02:00
services
skel
suggestion
svc Bug 36891: Restore returning 404 from svc/bib when the bib number doesn't exist 2024-06-27 11:50:00 +02:00
t Bug 37157: Fix Malformed UTF-8 character in JSON string before decode_json 2024-06-27 11:50:06 +02:00
tags
tools Bug 37129: Patron attributes linked to an authorized value don't show a select menu in batch modification 2024-06-21 15:02:48 +02:00
virtualshelves Bug 36858: Remove warnings 2024-05-22 16:18:11 +02:00
xt Bug 36374: flag JS files to keep tidy 2024-04-29 15:19:33 +02:00
.editorconfig
.eslintrc.json
.gitignore Bug 36546: (QA follow-up) Add bundle spec to .gitignore 2024-04-30 15:55:37 -03:00
.htaccess
.mailmap Bug 36943: (follow-up) 24.05.00 - Update .mailmap 2024-05-24 15:36:40 +02:00
.perlcriticrc
.perltidyrc
.prettierrc.js Bug 36400: (follow-up) remove option editorconfig from .prettierrc.js 2024-04-22 08:57:40 +02:00
.proverc.dist
.stylelintrc.json
about.pl Bug 32693: About script: Process only the tab being queried 2024-04-22 12:39:24 +02:00
app.psgi Bug 36149: Add userenv middleware to app.psgi 2024-05-14 15:04:37 -03:00
build-resources.PL
changelanguage.pl
cpanfile Bug 25159: Add ability to specify a pre-modified version of action log data and store as diff 2024-05-02 16:47:42 +02:00
cypress.config.ts
fix-perl-path.PL
gulpfile.js Bug 36730: (Bug 35428 follow-up) po files (sometimes) fail to update 2024-05-07 15:53:44 +02:00
help.pl
INSTALL
Koha.pm Bug 33317: DBRev 24.06.00.009 2024-06-25 18:34:19 +02:00
kohaversion.pl
LICENSE
mainpage.pl Bug 30493: (QA follow-up) Fix for the only_my_library case as well 2024-06-21 15:02:54 +02:00
Makefile.PL Bug 36546: Deploy swagger_bundle.json via make 2024-04-30 14:32:10 +02:00
MANIFEST.SKIP
package.json Bug 36546: Deploy swagger_bundle.json via make 2024-04-30 14:32:10 +02:00
README
README.md
README.robots
rewrite-config.PL
tsconfig.json
webpack.config.js Bug 35919: Add record sources admin page 2024-04-26 17:06:04 +02:00
yarn.lock Bug 36546: Fix js-yaml dependency in package.json 2024-04-30 14:32:09 +02:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo