Robin Sheat 95056d17b7 Bug 11947 - renumber reserves when hold is confirmed ... Currently when a reserve is moved to "waiting" status because it's acknowledged on checkin, the reserve priorities aren't renumbered. This causes things to go a bit haywire in the UI, in particular, some reserves can unjustly end up with priority 1 when they shouldn't. It also seemed to mess with the logic of who should get it next, but I didn't look too closely at that. This patch forces a renumbering so that all the priorities remain copacetic. Test plan: * have a few borrowers, say 4. * have a biblio with a single item (you can scale this up, it should work just the same.) * issue the item to borrower A * have borrowers B, C, and D place a hold on the item * return the item, acknowledge that it'll be put aside for B. * view the holds on the item. Without the patch: * the hold priorities in the UI end up being "waiting, 2, 1" when they should be "waiting, 1, 2". * in the database "reserves" table, they're really "0, 2, 3" when they should be "0, 1, 2". With the patch: * the hold priorities in the UI end up being "waiting, 1, 2" * in the database, they're "0, 1, 2" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Test plan confirms that the problem exists and that the patch corrects it. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script, especially t/db_dependent/Reserves.t. Improves priority calculation. Signed-off-by: Galen Charlton <gmc@esilibrary.com>		2014-04-15 14:18:19 +00:00
..
AuthoritiesMarc
Barcodes	Bug 11539: removing 2 unused files	2014-01-14 20:55:28 +00:00
ClassSortRoutine	Bug 9770: fix sorting of Dewey call numbers that contain prefixes	2013-07-15 16:12:47 +00:00
Creators	Bug 10763 - [SIGNED-OFF] Update POD of C4::Creators::Lib::html_table() to use TT syntax	2013-08-20 14:31:34 +00:00
External	Bug 10320: (follow-up) correct license statement	2013-09-08 07:04:45 +00:00
Form
Heading
ILSDI	Bug 8918: Fix reserve priority in ILS-DI	2014-03-10 17:31:05 +00:00
Installer	Bug 11096: support the retrieval of large MARCXML records	2014-02-28 19:50:09 +00:00
Labels	Bug 11402: make Labels::_guide_box return undef if undefned data is passed	2013-12-30 16:17:35 +00:00
Linker
Members
OAI	Bug 9295: Introduce operator equal/ notequal to OAI set mapping instead of hardcoded 'equal' value.	2013-10-10 23:03:30 +00:00
Output
Patroncards
Reports	Bug 11718 - Use new DataTables include in reports templates	2014-03-12 17:33:25 +00:00
Search
Serials	Bug 7688: (follow-up) update license statements	2013-10-30 02:56:32 +00:00
SIP	Bug 11783: ensure CD field in SIP patron information response is populated	2014-02-19 16:55:13 +00:00
Utils	Bug 11474: (follow-up) correct typos in POD	2014-01-06 05:46:32 +00:00
VirtualShelves	Bug 10853: All existing routing to get a CSV should return a MARC csv	2013-10-11 02:16:33 +00:00
Accounts.pm	Bug 2546: make description of standard fine types translatable	2013-12-05 18:44:33 +00:00
Acquisition.pm	Bug 11550: Add UT for C4::Acquisition::GetOrder	2014-03-12 14:16:20 +00:00
Auth.pm	Bug 10952: (follow-up) clear seach history from session after saving it to DB	2014-01-10 16:49:01 +00:00
Auth_cas_servers.yaml.orig
Auth_with_cas.pm	Bug 10927: remove disused C4::Utils module	2013-10-03 14:53:02 +00:00
Auth_with_ldap.pm	Bug 10908: restore docs on principal_name LDAP option	2013-10-21 15:28:11 +00:00
AuthoritiesMarc.pm	Bug 11096: support the retrieval of large MARCXML records	2014-02-28 19:50:09 +00:00
BackgroundJob.pm	Bug 10601: (follow-up) improvements to ->set() and ->get()	2013-09-18 17:23:44 +00:00
Barcodes.pm
Biblio.pm	Bug 9823: Refactor return from GetReservesFromBiblionumber	2014-01-30 16:19:55 +00:00
Bookseller.pm	Bug 7965: Silence warns in staff log	2014-01-10 15:42:09 +00:00
Boolean.pm	Bug 10080 - Change system pref IndependantBranches to IndependentBranches	2013-05-22 07:58:23 -07:00
Branch.pm	Bug 11051: remove unneccessary SQL queries in GetBranches	2014-01-10 16:02:39 +00:00
Breeding.pm	Bug 11419: display Z39.50 search errors more completely	2013-12-27 00:25:39 +00:00
Budgets.pm	Bug 10983: Remove unused private subroutines from C4::Budgets	2013-12-13 15:14:18 +00:00
Calendar.pm
Category.pm	Bug 7919: FIX the "all" categories method	2013-01-02 16:50:52 -05:00
Charset.pm	Bug 11730: ensure that C4::Charset loads C4::Context	2014-02-18 21:52:21 +00:00
Circulation.pm	Bug 11960: replace unnecessary call of GetMemberDetails by CanBookBeRenewed	2014-04-11 16:22:43 +00:00
ClassSortRoutine.pm
ClassSource.pm	Bug 10643: fix inappropriate uses of $sth->finish() in C4::ClassSource.pm	2013-08-09 15:32:22 +00:00
Context.pm	Bug 11701: Fix C4::Context::Zconn	2014-03-25 14:43:03 +00:00
Contract.pm
CourseReserves.pm	bug 8215: (followup) rename GetItemReservesInfo	2013-05-21 15:51:03 -07:00
Creators.pm
Csv.pm	Bug 10853: All existing routing to get a CSV should return a MARC csv	2013-10-11 02:16:33 +00:00
Dates.pm
Debug.pm
Heading.pm
HoldsQueue.pm	Bug 11711 - Use new DataTables include in circ templates	2014-04-08 23:47:27 +00:00
HTML5Media.pm	Bug 8377: Followup move style in a css file and do not pass template to a pm	2012-12-27 09:28:00 -05:00
Images.pm
ImportBatch.pm	Bug 11923: fix option to sort contents of MARC record batches by citation descending	2014-03-13 15:10:56 +00:00
ImportExportFramework.pm	Bug 11666: remove SQL as an option for MARC framework exports and imports	2014-02-05 19:48:27 +00:00
Input.pm
Installer.pm	Bug 10523: Remove two obsolete routines from Installer.pm	2013-10-31 16:51:47 +00:00
ItemCirculationAlertPreference.pm
Items.pm	Bug 11803: use $dbh consistently in _koha_modify_item	2014-02-25 14:55:32 +00:00
ItemType.pm	Bug 10513: display a warning/message when returning a chosen item type	2013-09-16 17:45:31 +00:00
Koha.pm	Bug 11279: (follow-up) remove unnecessary check on number of quotes	2013-12-19 15:06:39 +00:00
Labels.pm
Languages.pm	Bug 10309 - New OPAC theme based on Bootstrap	2013-10-14 23:13:05 +00:00
Letters.pm	Bug 11760: In notices, output road type description rather than code	2014-03-12 17:26:55 +00:00
Linker.pm
Log.pm
Maintainance.pm
MarcModificationTemplates.pm	Bug 11479: Remove experimental given/when keywords	2014-02-20 15:55:21 +00:00
Matcher.pm	Bug 11096: support the retrieval of large MARCXML records	2014-02-28 19:50:09 +00:00
Members.pm	Bug 7567 - Use, display, filter News by library	2014-04-07 18:14:19 +00:00
Message.pm
NewsChannels.pm	Bug 7567: (follow-up) construct values clause in SQL statement more idiomatically	2014-04-07 18:14:21 +00:00
Output.pm	Bug 10016: force zero browser-side caching of SCO pages	2013-10-21 18:05:12 +00:00
Overdues.pm	Bug 11359: Add the borrower's cardnumber and phonenumber to the branch overdues report	2014-03-10 20:25:26 +00:00
Patroncards.pm
Print.pm
Ratings.pm
Record.pm	Bug 11066: make RIS and Bibtex exports RDA compatible	2014-01-03 15:54:38 +00:00
Reports.pm
Reserves.pm	Bug 11947 - renumber reserves when hold is confirmed	2014-04-15 14:18:19 +00:00
Review.pm
Ris.pm	Bug 11066: make RIS and Bibtex exports RDA compatible	2014-01-03 15:54:38 +00:00
RotatingCollections.pm	Bug 11384: rename the collections_tracking.ctId column	2013-12-23 16:14:57 +00:00
Scheduler.pm
Scrubber.pm
Search.pm	Bug 11096: support the retrieval of large MARCXML records	2014-02-28 19:50:09 +00:00
Serials.pm	Bug 11861: Add ISSN column in serials claims table	2014-03-12 17:42:41 +00:00
Service.pm
ShelfBrowser.pm	Bug 10856: (follow-up) if callnumbers are equal, order should be on itemnumber	2013-10-04 15:57:03 +00:00
SMS.pm
SocialData.pm
SQLHelper.pm	Bug 11221: ensure that SQLHelper uses NULL rather than 0000-00-00 as default date value	2013-11-19 15:29:08 +00:00
Stats.pm
Suggestions.pm	Bug 10277 - Add C4::Context->IsSuperLibrarian()	2013-12-30 15:47:23 +00:00
Tags.pm
Templates.pm	Bug 7684: multiple fixes for inventory	2013-11-01 00:10:49 +00:00
TmplToken.pm
TmplTokenType.pm
TTParser.pm
UploadedFile.pm
VirtualShelves.pm	Bug 11799: Housekeeping: Remove _biblionumber_sth from VirtualShelves.pm	2014-02-21 18:24:11 +00:00
XISBN.pm	Bug 11096: support the retrieval of large MARCXML records	2014-02-28 19:50:09 +00:00
XSLT.pm	Bug 10550: Fix database typo wthdrawn	2013-09-08 01:58:41 +00:00