Main Koha release repository https://koha-community.org
Find a file
Owen Leonard 981b601c39
Bug 25909: Recent change to datatables JS in the OPAC causes errors
This patch reverts some changes made by Bug 25287 which prematurely
introduced the double-underscore i18n function. The i18n features
haven't been fully implemented in the OPAC.

Some lines are reverts to the previous version, and some are additions,
for instance where Bug 25287 introduced new DataTables features and a
new string translation is required.

In addition to i18n changes, the patch also reverts the default
configuration of DataTables in the OPAC so that the "dom" configuration
option is set back to "t." This turns off features like pagination
buttons, filters, etc. which were previously disabled by default.

Enabling these features requires revision to the OPAC CSS in order for
them to display well.

To test, apply the patch and view a page in the OPAC which includes a
DataTable. For instance: checkouts on the "your summary" page, serial
issues on the "full subscription history" page.

Tables should display correctly and sorting should work correctly. There
should be no other DataTables controls visible.

To test translatability:

To test, apply the patch and test that the correct strings are
translatable. In this example I'm testing fr-FR:

    - Update a translation:

      > cd misc/translator
      > perl translate update fr-FR

    - Open the corresponding .po file for the strings pulled from
      the templates  e.g.  misc/translator/po/fr-FR-opac-bootstrap.po
    - Locate strings pulled from bootstrap/en/includes/datatables.inc
      for translation, e.g.:

      #. SCRIPT
      #: opac-tmpl/bootstrap/en/includes/datatables.inc:4
      msgid "Copy to clipboard"
      msgstr ""

    - Edit the "msgstr" string however you want (it's just for testing)
    - Install the updated translation:

      > perl translate install fr-FR

Open the translated copy of datatables.inc and confirm that the
translated string appears.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2020-07-16 15:33:29 +01:00
acqui Bug 25750: fix fallback to ecost_tax_included/ecost_tax_excluded 2020-07-09 11:50:42 +02:00
admin Bug 25440: Fix for "uninitialized $maxsuspensiondays" in smart-rules.pl 2020-06-29 13:44:05 +02:00
api/v1 Bug 25944: Schema fix for illrequests route 2020-07-16 15:32:51 +01:00
authorities Bug 25428: Correctly encode link if authority subfield is a URL 2020-05-22 09:33:16 +01:00
basket Bug 17842: Simplify the code 2020-06-12 10:32:35 +02:00
C4 Bug 25566: Add option to ignore found holds and use it when checking high holds 2020-07-16 15:32:18 +01:00
catalogue Bug 23591: Hide archived suggestions 2020-04-14 16:36:41 +01:00
cataloguing Bug 25553: Make date columns sortable on the edit items table 2020-06-24 14:23:23 +02:00
circ Bug 15400: (follow-up) Restore 'years' string, remove untranslatable string 2020-06-29 12:37:02 +02:00
clubs Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} 2020-02-17 10:44:45 +00:00
course_reserves Bug 22970: Allow to change homebranch in batch add course reserves 2020-05-12 11:40:54 +01:00
debian Bug 25752: Stay in cwd after koha-shell 2020-07-09 11:50:42 +02:00
docs Bug 21395: (QA follow-up) Remove some introduced issues 2020-06-29 12:37:02 +02:00
errors Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
etc Bug 23975: (RM follow-up) Comment example configuration 2020-05-22 12:09:29 +01:00
ill Bug 23173: (follow-up) Small improvements in efficiency 2020-04-06 11:05:09 +01:00
installer Bug 25851: DBRev 20.06.00.004 2020-07-16 15:17:11 +01:00
Koha Bug 25850: (QA follow-up) Match logic in is_holiday 2020-07-16 15:28:02 +01:00
koha-tmpl Bug 25909: Recent change to datatables JS in the OPAC causes errors 2020-07-16 15:33:29 +01:00
labels Bug 24735: Remove QueryParser-related code 2020-03-02 11:13:03 +00:00
members Bug 15400: Display date of birth and age more consistantly 2020-06-29 12:37:02 +02:00
misc Bug 21395: Fix misc/admin/koha-preferences 2020-06-29 15:43:41 +02:00
offline_circ Bug 23463: Replace ModItem with Koha::Item->store 2020-03-23 09:26:30 +00:00
opac Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
patron_lists
patroncards Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
plugins Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
pos Bug 25139: Corrections to date picker handling 2020-04-15 08:33:07 +01:00
reports Bug 21395: (QA follow-up) Remove some introduced issues 2020-06-29 12:37:02 +02:00
reserve Bug 25516: Fix for "Can't call method unblessed on unblessed reference" 2020-05-19 08:29:34 +01:00
reviews Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
rotating_collections
serials Bug 25081: Fix wrong comment 2020-04-08 11:53:37 +01:00
services
skel
suggestion Bug 24819: (follow-up) Rename suggestor to suggester 2020-04-20 13:36:42 +01:00
svc Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
t Bug 25566: Add option to ignore found holds and use it when checking high holds 2020-07-16 15:32:18 +01:00
tags Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
tmp/modified_authorities
tools Bug 21395: (QA follow-up) Remove some introduced issues 2020-06-29 12:37:02 +02:00
virtualshelves Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} 2020-02-17 10:44:45 +00:00
xt Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
.editorconfig Bug 24774: Set JSON indentation of 2 spaces in .editorconfig 2020-03-19 09:24:52 +00:00
.eslintrc.json Bug 23834: Add default ESLint configuration 2019-11-03 08:02:39 +00:00
.gitignore
.htaccess
.mailmap
.perlcriticrc Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
.scss-lint.yml
about.pl Bug 25807: Add Template 3.008 to the exclude list 2020-06-29 12:37:01 +02:00
changelanguage.pl
cpanfile Bug 25807: Add Template 3.008 to the exclude list 2020-06-29 12:37:01 +02:00
fix-perl-path.PL Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
gulpfile.js
help.pl
INSTALL
Koha.pm Bug 25851: DBRev 20.06.00.004 2020-07-16 15:17:11 +01:00
koha_perl_deps.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
kohaversion.pl
LICENSE
mainpage.pl Bug 4461: Fix status and borrowernumber fields in problem_reports and more 2020-04-06 11:18:59 +01:00
Makefile.PL Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
MANIFEST.SKIP
package.json Bug 23025: security vulnerability detected in fstream < 1.0.12 defined in yarn.lock 2019-11-27 11:30:17 +00:00
README
README.md
README.robots
rewrite-config.PL Bug 21395: Fix QA errors 2020-06-29 12:37:02 +02:00
yarn.lock Bug 23025: Update yarn.lock 2019-11-27 11:30:17 +00:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo