Main Koha release repository https://koha-community.org
Find a file
Jonathan Druart 9f16ab9e75
Bug 18743: Fix suggestion listing when organized by library
There are some weird behaviors happening when using the "Organize by:
library" dropdown along with the library filter (in the "Acquisition
information" box).

I am suggesting the following test plan:
0. Create several suggestion from different libraries

A. You are superlibrarian and IndependentBranches is not set (=No)
1. Hit /suggestion/suggestion.pl
=> Default view shows the suggestions from your library
2. Filter by another library
=> You see the suggestions from this library
3. Filter by "Any" libraries
=> You see all the suggestions
4. "Organize by library"
=> You see all the suggestions, organized by library
5. Filter by a specific library
=> You see the suggestion from your library, all in one tab

B. You are not superlibrarian and IndependentBranches is not set (=No)
Same as A.

C. You are superlibrarian and IndependentBranches is set
Same as A.

D. You are not superlibrarian and IndependentBranches is set
You will never see suggestions coming from outside your library

QA: To be clear: the whole script needs a rewrite, but here we are just
trying to fix weird behaviors.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2019-10-25 13:16:29 +01:00
acqui Bug 23863: Editing a basket clears create_items value 2019-10-24 10:56:01 +01:00
admin Bug 23049: (follow-up) Types should not be deletable 2019-10-24 17:25:03 +01:00
api/v1 Bug 23805: Update 'W' to 'WRITEOFF' for consistency 2019-10-24 17:35:20 +01:00
authorities Bug 19994: Used Modern::Perl in Authorities perl scripts 2019-01-28 14:58:23 +00:00
basket Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
C4 Bug 18743: Fix suggestion listing when organized by library 2019-10-25 13:16:29 +01:00
catalogue Bug 23049: Update existing code to use debit_type 2019-10-24 17:24:15 +01:00
cataloguing Bug 15497: Limit itemtypes by branch in additem.pl 2019-09-12 16:31:06 +01:00
circ Bug 23551: Fix AddRenewal call in circ/renew.pl 2019-10-17 14:40:47 +01:00
clubs
course_reserves Bug 21003: Removed warning and changed wording on add_items-step2.tt 2019-03-23 09:51:36 +00:00
debian Bug 23346: Add without-db-name parameter to koha-dump 2019-10-21 10:02:58 +01:00
docs Update docs/teams.yaml for 19.11.x development cycle 2019-10-22 15:15:33 +01:00
errors
etc Bug 13937: Fix the daemon log path. 2019-10-08 14:40:12 +01:00
ill Bug 21460: (follow-up) Fix bugs found in QA 2019-04-25 10:46:56 +00:00
installer Bug 23579: Remove default value for MEDIUMTEXT borrower_modifications.changed_fields 2019-10-25 10:46:39 +01:00
Koha Bug 23805: DBRev 19.06.00.044 2019-10-24 17:35:21 +01:00
koha-tmpl Bug 23805: Update mancredit to use the new credit types 2019-10-24 17:35:21 +01:00
labels Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
members Bug 23805: Update mancredit to use the new credit types 2019-10-24 17:35:21 +01:00
misc Bug 23049: Update existing code to use debit_type 2019-10-24 17:24:15 +01:00
offline_circ Bug 22600: Add 'interface' to accountlines 2019-04-10 19:43:11 +00:00
opac Bug 23049: Update debit_type_code 'Res' to 'RESERVE' 2019-10-24 17:24:18 +01:00
OpenILS
patron_lists
patroncards Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
plugins Bug 21073: (QA follow-up) Avoid unnecessary unless/else construct 2019-06-18 17:30:44 +01:00
reports Bug 23805: Update 'W' to 'WRITEOFF' for consistency 2019-10-24 17:35:20 +01:00
reserve Bug 22922: Use jQuery datepicker instead of <input type="date"> 2019-10-21 10:01:01 +01:00
reviews
rotating_collections Bug 21500: Remove warnings in rotating collections 2018-10-09 15:02:45 +00:00
serials Bug 23435: Add multiple copies of an item when receiving in serials 2019-10-17 14:59:40 +01:00
services
skel
suggestion Bug 18743: Fix suggestion listing when organized by library 2019-10-25 13:16:29 +01:00
svc Bug 23390: Introduce placeholder syntax for report column names 2019-08-13 11:46:06 +01:00
t Bug 23579: (RM follow-up) Fix failing tests 2019-10-25 13:13:26 +01:00
tags Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
tmp/modified_authorities
tools Bug 22996: Move barcode separators to a preference 2019-09-10 09:34:34 +01:00
virtualshelves Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
xt Bug 21576: Keep compatibility with QA script 2018-10-26 17:09:52 +00:00
.editorconfig
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
.mailmap
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
about.pl Bug 14570: Add about.pl entry for wrong relationship data 2019-08-20 16:06:36 +01:00
changelanguage.pl Bug 21299: (QA follow-up) Rename module and subroutine 2018-11-07 21:52:17 +00:00
fix-perl-path.PL
gulpfile.js Bug 21751: Replace fixFloat with HC-sticky to fix Chrome display 2019-02-04 14:13:35 +00:00
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
INSTALL
Koha.pm Bug 23805: DBRev 19.06.00.044 2019-10-24 17:35:21 +01:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl Bug 21907: Fix article requests count for non-superlibrarians 2019-02-04 14:50:40 +00:00
Makefile.PL Bug 17851: Add elasticsearch config to koha-conf.xml 2019-10-07 14:09:10 +01:00
MANIFEST.SKIP
package.json Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00
README
README.md
README.robots
rewrite-config.PL Bug 17851: Add elasticsearch config to koha-conf.xml 2019-10-07 14:09:10 +01:00
yarn.lock Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo